Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1142257rwl; Wed, 29 Mar 2023 13:21:15 -0700 (PDT) X-Google-Smtp-Source: AKy350auCW15WK6GtnpP3rCk7rQvbXrRNfSvZOVPDeb3CqOrfPBgUTq5Qh/ImqEkmq7SYzAUlIgN X-Received: by 2002:a17:906:2ecd:b0:931:636e:de5a with SMTP id s13-20020a1709062ecd00b00931636ede5amr20520197eji.31.1680121275310; Wed, 29 Mar 2023 13:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680121275; cv=none; d=google.com; s=arc-20160816; b=mARQEeGdPKwqyA0lcfMlZinkEVKmXJjJHwnmLdqa23fVgBZGkV2kiueMIYECyHK3RQ 8gql6Iehj+SsS6SZSgKzj57hi+/jHOs8IB2iOId1MsopLXieWUI5Q40ZGQqeCfIrKTcg AlGXZtHjFkqr6KrW/AY756OzcUQA9fQEi7OIRZjPso35u56R5TxldptdwulfnIWxnTUE wOwVcRfOJ5D20I7GgZxvOdGP6y7Gp63aYzXtGKhr5JYz3fDggG1ttxocpxn/O8jiO6da G6BVEl32tjOQMmx5f3aQB0+5lF7IcHbLcGsEgDFBlRCpPHbmzM2UQusHq3scZf96nQIy vMcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GQ/BnFe9Q8YTrp9m/Oja+3F+vgOfqDylgmr9jLCscRs=; b=A5UHWB49ZDLwi9ZL54S6B7ZGQbAVsPXk4W5ASVlA+aHN1vPFDk74CRsZvlp6vNhvva mkC7HPWZ7evJ+RzhToY3fxR+TkU0QtWpSCqWDM9PBBy/VsHhtsO3s56TYjwTMxZGu5TJ QgReJ/q8BQdE4vXNxI2hwVPt8FfmX+YoVs5/rZRUrfjQhxwE9+vjj1/qaUJM4wD0duiU Eo5PyWgXn6nGPtE8fYKU5nNMf9FviaFFqgyWU3jf5y4JXQF8bZfHvvMCzK3pfXn//vPs In7/zyI6eFGtFvgZpawV/dFjw4SYKUo+SJLWJ6v6J1vs3iciH4d872Cv/2yiICk+GHVS 71xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P5U564E9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w18-20020a17090652d200b0091883920748si30462524ejn.12.2023.03.29.13.20.49; Wed, 29 Mar 2023 13:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P5U564E9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbjC2UQY (ORCPT + 99 others); Wed, 29 Mar 2023 16:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjC2UQW (ORCPT ); Wed, 29 Mar 2023 16:16:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8027830C7; Wed, 29 Mar 2023 13:16:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1ADD261E26; Wed, 29 Mar 2023 20:16:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAEB3C433D2; Wed, 29 Mar 2023 20:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680120980; bh=GQ/BnFe9Q8YTrp9m/Oja+3F+vgOfqDylgmr9jLCscRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P5U564E993rrDoh13ZYMd/KR6rZkNdIdAbkwy4AMMyuaZ2UnsINcIgdKLJGQbZT1R zUAUZnpQCzF0TlpEQXZmdxZiDMl23kcqvk8c8s2jxRsSMekf7FDxCi9gR1oX2Da8hi aag+2sE6WG2TyEHXWa4HzYKbVaDqQKSeZs+SUyrFuRdRhxxhHTm9szdrtMzu032YBF pnLWBxLnUyF1yY234OeM4zx5JvWcQ8+nbW2h2BxGSx1xSG/83/MuR/yVSH7mdi1xg2 0jWbdD9E6OkE4eGUQzkyJv6rP5bdfMAHDI8/GyVgtoddbv/rL55kO33CXzMD08MgAw CkixnBQ6Xb9Yw== Date: Wed, 29 Mar 2023 21:16:10 +0100 From: Conor Dooley To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Vineet Gupta , Russell King , Neil Armstrong , Linus Walleij , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Stafford Horne , Helge Deller , Michael Ellerman , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Max Filippov , Christoph Hellwig , Robin Murphy , Lad Prabhakar , Conor Dooley , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-oxnas@groups.io, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 09/21] riscv: dma-mapping: skip invalidation before bidirectional DMA Message-ID: <764e8d2f-ed98-49dc-8fdb-112d59359148@spud> References: <20230327121317.4081816-1-arnd@kernel.org> <20230327121317.4081816-10-arnd@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2LJh6dsRB07q9YeN" Content-Disposition: inline In-Reply-To: <20230327121317.4081816-10-arnd@kernel.org> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2LJh6dsRB07q9YeN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 27, 2023 at 02:13:05PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > For a DMA_BIDIRECTIONAL transfer, the caches have to be cleaned > first to let the device see data written by the CPU, and invalidated > after the transfer to let the CPU see data written by the device. >=20 > riscv also invalidates the caches before the transfer, which does > not appear to serve any purpose. Rationale makes sense to me.. Reviewed-by: Conor Dooley Thanks for working on all of this Arnd! --2LJh6dsRB07q9YeN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZCScigAKCRB4tDGHoIJi 0jHpAP47kMhf2uxHoGKhD+jHsEYnFgTHptLnAfIJV6N+QeFoOAD/YxG6hd8qhesW 6Tw9EqBEW/4auX2CLsbK7xE8fP5A9wg= =os1C -----END PGP SIGNATURE----- --2LJh6dsRB07q9YeN--