Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1676378702.git.quic_charante@quicinc.com> <20230328155027.f0f7571bd430e7525481c6ca@linux-foundation.org>
In-Reply-To: <20230328155027.f0f7571bd430e7525481c6ca@linux-foundation.org>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Wed, 29 Mar 2023 14:36:52 -0700
Message-ID: <CAJuCfpEznM+R6uG+-qYGy=CG=8OR2EthEjNObrWVRirRba2p+g@mail.gmail.com>
Subject: Re: [PATCH V7 0/2] mm: shmem: support POSIX_FADV_[WILL|DONT]NEED for
 shmem files
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Charan Teja Kalla <quic_charante@quicinc.com>, hughd@google.com,
        willy@infradead.org, markhemm@googlemail.com, rientjes@google.com,
        shakeelb@google.com, quic_pkondeti@quicinc.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 28, 2023 at 3:50=E2=80=AFPM Andrew Morton <akpm@linux-foundatio=
n.org> wrote:
>
> On Tue, 14 Feb 2023 18:21:48 +0530 Charan Teja Kalla <quic_charante@quici=
nc.com> wrote:
>
> > This patch aims to implement POSIX_FADV_WILLNEED and POSIX_FADV_DONTNEE=
D
> > advices to shmem files which can be helpful for the drivers who may wan=
t
> > to manage the pages of shmem files on their own, like, that are created
> > through shmem_file_setup[_with_mnt]().
>
> Could we please have some additional review of this series?

The series LGTM but unfortunately I'm not a shmem expert. I asked
Minchan to take a look as well.
Thanks!

>
> Thanks.