Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230324094205.33266-1-angelogioacchino.delregno@collabora.com> <20230324094205.33266-6-angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230324094205.33266-6-angelogioacchino.delregno@collabora.com>
From:   Alexandre Mergnat <amergnat@baylibre.com>
Date:   Thu, 30 Mar 2023 01:17:01 +0200
Message-ID: <CAFGrd9qS4mzXWRftbR7dFqtvs9Uc4qzBQMAjRo3rAwN70jDoyA@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] soc: mediatek: mtk-pmic-wrap: Add support for
 MT6331 w/ MT6332 companion
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     matthias.bgg@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, flora.fu@mediatek.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, kernel@collabora.com,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>

Regards,
Alexandre

Le ven. 24 mars 2023 =C3=A0 10:42, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> a =C3=A9crit :
>
> Add support for the MT6331 PMIC and for its companion MT6332 PMIC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@coll=
abora.com>
> ---
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 47 ++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/=
mtk-pmic-wrap.c
> index 366e40b802e4..ceeac43f7bd1 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -170,6 +170,40 @@ static const u32 mt6323_regs[] =3D {
>         [PWRAP_DEW_RDDMY_NO] =3D          0x01a4,
>  };
>
> +static const u32 mt6331_regs[] =3D {
> +       [PWRAP_DEW_DIO_EN] =3D            0x018c,
> +       [PWRAP_DEW_READ_TEST] =3D         0x018e,
> +       [PWRAP_DEW_WRITE_TEST] =3D        0x0190,
> +       [PWRAP_DEW_CRC_SWRST] =3D         0x0192,
> +       [PWRAP_DEW_CRC_EN] =3D            0x0194,
> +       [PWRAP_DEW_CRC_VAL] =3D           0x0196,
> +       [PWRAP_DEW_MON_GRP_SEL] =3D       0x0198,
> +       [PWRAP_DEW_CIPHER_KEY_SEL] =3D    0x019a,
> +       [PWRAP_DEW_CIPHER_IV_SEL] =3D     0x019c,
> +       [PWRAP_DEW_CIPHER_EN] =3D         0x019e,
> +       [PWRAP_DEW_CIPHER_RDY] =3D        0x01a0,
> +       [PWRAP_DEW_CIPHER_MODE] =3D       0x01a2,
> +       [PWRAP_DEW_CIPHER_SWRST] =3D      0x01a4,
> +       [PWRAP_DEW_RDDMY_NO] =3D          0x01a6,
> +};
> +
> +static const u32 mt6332_regs[] =3D {
> +       [PWRAP_DEW_DIO_EN] =3D            0x80f6,
> +       [PWRAP_DEW_READ_TEST] =3D         0x80f8,
> +       [PWRAP_DEW_WRITE_TEST] =3D        0x80fa,
> +       [PWRAP_DEW_CRC_SWRST] =3D         0x80fc,
> +       [PWRAP_DEW_CRC_EN] =3D            0x80fe,
> +       [PWRAP_DEW_CRC_VAL] =3D           0x8100,
> +       [PWRAP_DEW_MON_GRP_SEL] =3D       0x8102,
> +       [PWRAP_DEW_CIPHER_KEY_SEL] =3D    0x8104,
> +       [PWRAP_DEW_CIPHER_IV_SEL] =3D     0x8106,
> +       [PWRAP_DEW_CIPHER_EN] =3D         0x8108,
> +       [PWRAP_DEW_CIPHER_RDY] =3D        0x810a,
> +       [PWRAP_DEW_CIPHER_MODE] =3D       0x810c,
> +       [PWRAP_DEW_CIPHER_SWRST] =3D      0x810e,
> +       [PWRAP_DEW_RDDMY_NO] =3D          0x8110,
> +};
> +
>  static const u32 mt6351_regs[] =3D {
>         [PWRAP_DEW_DIO_EN] =3D            0x02F2,
>         [PWRAP_DEW_READ_TEST] =3D         0x02F4,
> @@ -1182,6 +1216,8 @@ static int mt8186_regs[] =3D {
>
>  enum pmic_type {
>         PMIC_MT6323,
> +       PMIC_MT6331,
> +       PMIC_MT6332,
>         PMIC_MT6351,
>         PMIC_MT6357,
>         PMIC_MT6358,
> @@ -2041,6 +2077,16 @@ static const struct pwrap_slv_type pmic_mt6323 =3D=
 {
>                 PWRAP_SLV_CAP_SECURITY,
>  };
>
> +static const struct pwrap_slv_type pmic_mt6331 =3D {
> +       .dew_regs =3D mt6331_regs,
> +       .type =3D PMIC_MT6331,
> +       .comp_dew_regs =3D mt6332_regs,
> +       .comp_type =3D PMIC_MT6332,
> +       .regops =3D &pwrap_regops16,
> +       .caps =3D PWRAP_SLV_CAP_SPI | PWRAP_SLV_CAP_DUALIO |
> +               PWRAP_SLV_CAP_SECURITY,
> +};
> +
>  static const struct pwrap_slv_type pmic_mt6351 =3D {
>         .dew_regs =3D mt6351_regs,
>         .type =3D PMIC_MT6351,
> @@ -2086,6 +2132,7 @@ static const struct pwrap_slv_type pmic_mt6397 =3D =
{
>
>  static const struct of_device_id of_slave_match_tbl[] =3D {
>         { .compatible =3D "mediatek,mt6323", .data =3D &pmic_mt6323 },
> +       { .compatible =3D "mediatek,mt6331", .data =3D &pmic_mt6331 },
>         { .compatible =3D "mediatek,mt6351", .data =3D &pmic_mt6351 },
>         { .compatible =3D "mediatek,mt6357", .data =3D &pmic_mt6357 },
>         { .compatible =3D "mediatek,mt6358", .data =3D &pmic_mt6358 },
> --
> 2.40.0
>