Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 16:22:56 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Zhi Wang <zhi.wang.linux@gmail.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        Kai Huang <kai.huang@intel.com>
Subject: Re: [PATCH v13 017/113] KVM: TDX: Add place holder for TDX VM
 specific mem_enc_op ioctl
Message-ID: <20230329232256.GB1108448@ls.amr.corp.intel.com>
References: <cover.1678643051.git.isaku.yamahata@intel.com>
 <7cdfc307ea8717849e71063ceebf1e328448e773.1678643052.git.isaku.yamahata@intel.com>
 <20230325110550.00006091@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230325110550.00006091@gmail.com>
Precedence: bulk

On Sat, Mar 25, 2023 at 11:05:50AM +0200,
Zhi Wang <zhi.wang.linux@gmail.com> wrote:

> > diff --git a/arch/x86/include/asm/kvm-x86-ops.h b/arch/x86/include/asm/kvm-x86-ops.h
> > index b46dcac078b2..58fbaa05fc8c 100644
> > --- a/arch/x86/include/asm/kvm-x86-ops.h
> > +++ b/arch/x86/include/asm/kvm-x86-ops.h
> > @@ -117,7 +117,7 @@ KVM_X86_OP(enter_smm)
> >  KVM_X86_OP(leave_smm)
> >  KVM_X86_OP(enable_smi_window)
> >  #endif
> > -KVM_X86_OP_OPTIONAL(dev_mem_enc_ioctl)
> > +KVM_X86_OP(dev_mem_enc_ioctl)
> 
> I guess it should be KVM_X86_OP(mem_enc_ioctl) here.

Yes, thanks for catching it.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>