DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:subject:from:reply-to:to:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding;
        b=NGE4HBvk3uxwTUh4LWV/vfX7a/M0BBi3S2fDFOePWuSUrxZx4n7+KbvnJrRyHy26FEYZrzqVwUwX6vHdVxpRYKNI+Hb2JAi2OuofaretDlRznlOSm8InlFRb2bVdLlQc41656z4VKfpwpiKZqGhsLF2AhrPwRicBqfIY/RyeuDg=
Subject: Redundent/missing code in dik_show_trace
	(arch/alpha/kernel/traps.c)
From: Gilboa Davara <gilboad@gmail.com>
Reply-To: gilboad@gmail.com
To: linux-kernel@vger.kernel.org
Content-Type: text/plain
Date: Fri, 21 Sep 2007 21:07:15 +0200
Message-Id: <1190401635.6759.7.camel@gilboa-home-dev.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 947
Lines: 42

Hello all,

As the title suggest.
"i" is declared as 0 and never assigned a new value.
Down the code there's an if (i>40) and a certain dangling piece of code.
I assume that I should have gotten a string length (?) from somewhere?

Am I missing something?

- Gilboa

---
static void
dik_show_trace(unsigned long *sp)
{
	long i = 0;
	printk("Trace:\n");
	while (0x1ff8 & (unsigned long) sp) {
		extern char _stext[], _etext[];
		unsigned long tmp = *sp;
		sp++;
		if (tmp < (unsigned long) &_stext)
			continue;
		if (tmp >= (unsigned long) &_etext)
			continue;
		printk("[<%lx>]", tmp);
		print_symbol(" %s", tmp);
		printk("\n");
		if (i > 40) {
			printk(" ...");
			break;
		}
	}
	printk("\n");
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/