Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230329110723.3458843-1-sadiyakazi@google.com>
In-Reply-To: <20230329110723.3458843-1-sadiyakazi@google.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Wed, 29 Mar 2023 20:10:47 -0400
Message-ID: <CAFd5g45kEm2Kmwac3DTYVgWOcXLfp3b8_59euXOiJW8RVxRX0Q@mail.gmail.com>
Subject: Re: [PATCH v1] list: test: Test the klist structure
To:     Sadiya Kazi <sadiyakazi@google.com>
Cc:     davidgow@google.com, skhan@linuxfoundation.org, corbet@lwn.net,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 29, 2023 at 7:07=E2=80=AFAM Sadiya Kazi <sadiyakazi@google.com>=
 wrote:
>
> Add KUnit tests to the klist linked-list structure.
> These perform testing for different variations of node add
> and node delete in the klist data structure (<linux/klist.h>).
>
> Limitation: Since we use a static global variable, and if
> multiple instances of this test are run concurrently, the test may fail.
>
> Signed-off-by: Sadiya Kazi <sadiyakazi@google.com>

Looks good!

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>