Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> <ZCRRaHHKVt7fpvmD@cmpxchg.org>
In-Reply-To: <ZCRRaHHKVt7fpvmD@cmpxchg.org>
From:   Zhaoyang Huang <huangzhaoyang@gmail.com>
Date:   Thu, 30 Mar 2023 09:38:48 +0800
Message-ID: <CAGWkznFRHbYv2ev3FU10zapka_6MDQ+g_-b0jufzqcAEAKUqFA@mail.gmail.com>
Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ke.wang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 29, 2023 at 10:55=E2=80=AFPM Johannes Weiner <hannes@cmpxchg.or=
g> wrote:
>
> On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote:
> > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> >
> > folio will skip of being set as workingset in lru_deactivate_fn.
>
> Can you please elaborate why that's undesirable? What's the problem
> you're fixing?
If I am correct, folio will skip being set as workingset when moving
from active lru to inactive lru, which is performed on every folio in
shrink_active_list during normal reclaim.