Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 09:51:19 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Chris Hyser <chris.hyser@oracle.com>
CC:     <linux-kernel@vger.kernel.org>, <dietmar.eggemann@arm.com>,
        <peterz@infradead.org>, <vincent.guittot@linaro.org>
Subject: Re: [PATCH] sched/numa: Fix divide by zero for
 sysctl_numa_balancing_scan_size.
Message-ID: <ZCTrF/YtBLdLLdup@chenyu5-mobl1>
References: <20230329162610.4130188-1-chris.hyser@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230329162610.4130188-1-chris.hyser@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/EHHujrElsgRptoxDDPD/nppSLW0FWv8McIu0wrOys5D+JWJL+BySl5saiZ7?=
 =?us-ascii?Q?BXwhOLTorvDtfh8RITDvsuSDbNLU61wghpY8jP/4BGZKUy1ygtNmJfbibvvi?=
 =?us-ascii?Q?kzvpy19ZQy4ROR/m9dKy/J4+Lq4vkeD/DjIkW1ixOKeF/Fb6vKJ7qbtzjorA?=
 =?us-ascii?Q?XOsWJ/laUyXW7AWzBK7MnJZeCCGyoLCuST3wWlgvG5bs2O0TsiJyUFjkNBuX?=
 =?us-ascii?Q?8vytRhcRn1s7d0Zsoroisi62GM4HywnBUcqkpQEQL4YJGI7nPTTWoDUUiqcO?=
 =?us-ascii?Q?wwZNzMt8dc8RoEqiTyxOL+KfRaNhnRjwta6uviISBAgnGAkKd49pa6SHww9/?=
 =?us-ascii?Q?eSxozmqB9FejHUWU0jTtzxBjQRXES3PXVaqs7brD4pabCfHCDlK6rybeaObF?=
 =?us-ascii?Q?aWjtdPOC2ky7/tzrajXOb2vHaOrFq3bQC7+w1TFGtoYZMDgcOeL79sJzOKM+?=
 =?us-ascii?Q?zXDpOCMRXTqjnjLZItDjH47HK+gx7LrveTiIZjLudC901O4Lvn+Hn6Rj8UlZ?=
 =?us-ascii?Q?xVmocBpjfgAtATGsG9hahgjrW9l5vQeGWj1scrkcteGZ5FMOCJrFNBCOkc6d?=
 =?us-ascii?Q?9n8tq9YBKlsilVrAWgzkylyi9qIlTcLwXiQQyj+fMT/OFer/c3pc1Kqi9E2z?=
 =?us-ascii?Q?SJj+Ejfj0OAk57mpj/a7H0W7nyZGVVw7OIkCyg5z/YtKHWKmbFYkDOGN1vU/?=
 =?us-ascii?Q?ajfpzK+gtEMtcRYCHQ/bdKmLCW/En9arY0yn09dnLTwnCVhcHINN8OHjbjDy?=
 =?us-ascii?Q?ToYq7/rcd6M8DDLl+3baXgfVL4ODMq2QO9xO8rYTUcXWHbqauEdGbvRjSLDu?=
 =?us-ascii?Q?CoYfO8fxF2Qurf0iD4zxmzFJhRpCG3pooTXRUxVNvHfj8evQFlWunP/hJEXo?=
 =?us-ascii?Q?2CiZGL/6B8xwVCVvBHsIHRVz0uBe3Cg7b0peb2u15O7349Jt9hS/w44OU61I?=
 =?us-ascii?Q?D5/bcF67IhJFpFJjSo8pdErkRfUfzQzzIwxlPtDvD9znOAySU5yTR8aPJQG+?=
 =?us-ascii?Q?OEEcy0f2zDsQZogQ+nQJJWsoXocr/EFJg5vFKjF4cH8gmMbgOJ5+/O7moHCS?=
 =?us-ascii?Q?LBEFYQUkkyRQTfvB9Afk4K8XharPH8i7Qs4XVYzmBDShOdHtkm4LzPeXSQee?=
 =?us-ascii?Q?cr5xhI0WCstB91UmGtiiSasbxL5zQJ55buY/WSeCgPMSuIVSgR5rLIImIy6o?=
 =?us-ascii?Q?2fUN0SHsMj7jVMcZ99t7qyW9kj/hE4oK7DE6zQmGq4osvhLvvrIBhkXRYroi?=
 =?us-ascii?Q?zIZ0Fes+QinWpp02oMZGSPk0kEVLICRPfmIUNDz8ar7TH/Z+SLeNfeHUQ3b8?=
 =?us-ascii?Q?hYfCsbaobBTsBubCL5yMTBXndM6mAq8OT+tPOfMKabhpdjX+CQ1+UvQToTGr?=
 =?us-ascii?Q?CvrxwIdWBtkDFUs2K09LaojWf4TZVzScciS00wEzhkWKh/bmCRvXQW5O/tJk?=
 =?us-ascii?Q?xaws/62FfbX4ffIGz/rgf59uCtDLpJMnpdp8zRkvN4j4Be7UanM4l+HS9UPy?=
 =?us-ascii?Q?6WlZjhKWZ31EOwKpMS4sF6yq0QokX8yIOPsTeZaENJlHMDfbYfktxCIvieKN?=
 =?us-ascii?Q?/l3xh7rSm5APPNqhCwMavw6/op4z0xXHBHNQLmwW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebf3048-d00c-4775-f7e6-08db30c14ae3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 01:51:34.8363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /gmUJbp7HaWJCposiZ+LsS5bTR0mv6K2cGKJ1aOIupKN5BguvOUKDNgcez5KitEXTKgWaOJBvCctFmrVpKB1VA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5702
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-03-29 at 12:26:10 -0400, Chris Hyser wrote:
> From: chris hyser <chris.hyser@oracle.com>
> 
> Commit 6419265899d9 ("sched/fair: Fix division by zero
> sysctl_numa_balancing_scan_size") prevented a divide by zero by using
> sysctl mechanisms to return EINVAL for a sysctl_numa_balancing_scan_size
> value of zero. When moved from a sysctl to a debugfs file, this checking
> was lost.
> 
> This patch puts zero checking back in place.
> 
> Signed-off-by: Chris Hyser <chris.hyser@oracle.com>
> ---
>  kernel/sched/debug.c | 50 +++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 49 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index 1637b65ba07a..dfd0fe6123ec 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -278,6 +278,54 @@ static const struct file_operations sched_dynamic_fops = {
>  
>  #endif /* CONFIG_PREEMPT_DYNAMIC */
>  
> +#ifdef CONFIG_NUMA_BALANCING
> +
> +static ssize_t sched_numa_scan_write(struct file *filp, const char __user *ubuf,
> +				     size_t cnt, loff_t *ppos)
> +{
> +	char buf[16];
> +	unsigned int scan_size;
> +
> +	if (cnt > 15)
> +		cnt = 15;
> +
> +	if (copy_from_user(&buf, ubuf, cnt))
> +		return -EFAULT;
> +	buf[cnt] = '\0';
> +
> +	if (kstrtouint(buf, 10, &scan_size))
> +		return -EINVAL;
error code of kstrtouint() includes -ERANGE other than -EINVAL, how
about return the error code directly?

thanks,
Chenyu