Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <48d7ba60-aa7b-8d93-fcf0-c7e64908e9f5@ti.com>
Date:   Thu, 30 Mar 2023 08:34:19 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [RFC PATCH 1/2] gpio: davinci: Do not clear the bank intr enable
 bit in save_context
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Dhruva Gole <d-gole@ti.com>
CC:     Vibhore Vardhan <vibhore@ti.com>, Tony Lindgren <tony@atomide.com>,
        Vignesh <vigneshr@ti.com>, Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Devarsh Thakkar <devarsht@ti.com>
References: <20230323122910.991148-1-d-gole@ti.com>
 <CACRpkdY_rhe69Y4AbEp8iws1fpL0bUkP5iBMN68EB+wxhFyHTw@mail.gmail.com>
From:   "J, KEERTHY" <j-keerthy@ti.com>
In-Reply-To: <CACRpkdY_rhe69Y4AbEp8iws1fpL0bUkP5iBMN68EB+wxhFyHTw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/28/2023 6:59 PM, Linus Walleij wrote:
> On Thu, Mar 23, 2023 at 1:29 PM Dhruva Gole <d-gole@ti.com> wrote:
> 
>> The interrupt enable bits might be set if we want to use the GPIO as
>> wakeup source. Clearing this will mean disabling of interrupts in the GPIO
>> banks that we may want to wakeup from.
>> Thus remove the line that was clearing this bit from the driver's save
>> context function.
>>
>> Fixes: 0651a730924b ("gpio: davinci: Add support for system suspend/resume PM")
>> Cc: Devarsh Thakkar <devarsht@ti.com>
>> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> 
> Looks like the right solution to me.
> I'm a bit surprised given how long we have had this driver.
> I suppose people have used out-of-tree patches for suspend/resume. :(
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Keerthy <j-keerthy@ti.com>

> 
> Yours,
> Linus Walleij