Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 09:26:12 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Yang Shi <yang@os.amperecomputing.com>
Cc:     rafael@kernel.org, scott@os.amperecomputing.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        vincent.guittot@linaro.org, lukasz.luba@arm.com,
        ionela.voinescu@arm.com
Subject: Re: [PATCH] cpufreq: CPPC: use 10ms delay instead of 2us to avoid
 high error
Message-ID: <20230330035612.ekh2lpqzohggg6uf@vireshk-i7>
References: <20230328193846.8757-1-yang@os.amperecomputing.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230328193846.8757-1-yang@os.amperecomputing.com>
Precedence: bulk

+ few folks.

On 28-03-23, 12:38, Yang Shi wrote:
> When testing CPPC cpufreq on our platform, we noticed the error may be quite
> high and the high error may happen quite often.  For example, on a platform
> with a maximum frequency of 2.8GHz when the CPUs were fully loaded (100% load),
> we saw cpuinfo_cur_freq may show 4GHz, it means the error is > 40%.  And the
> high error (> 1%) happened 256 times out of 2127 samples (sampled every 3
> seconds) in an approximate 2hrs test.
> 
> We tried to enlarge the delay, and tested with 100us, 1ms and 10ms.  The
> below is the results.
> 
> 100us:
> The highest error is 4GHz, 22 times out of 3623 samples
> 
> 1ms:
> The highest error is 3.3GHz, 3 times out of 2814 samples
> 
> 10ms:
> No high error anymore
> 
> Increase the measurement delay in cppc_cpufreq_get_rate to 10ms to avoid
> high measurement errors.
> 
> Signed-off-by: Yang Shi <yang@os.amperecomputing.com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 022e3555407c..c2bf65448d3d 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -851,7 +851,7 @@ static unsigned int cppc_cpufreq_get_rate(unsigned int cpu)
>  	if (ret)
>  		return ret;
>  
> -	udelay(2); /* 2usec delay between sampling */
> +	mdelay(10); /* 10msec delay between sampling */
>  
>  	ret = cppc_get_perf_ctrs(cpu, &fb_ctrs_t1);
>  	if (ret)
> -- 
> 2.39.2

-- 
viresh