Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1598947rwl; Wed, 29 Mar 2023 21:41:18 -0700 (PDT) X-Google-Smtp-Source: AKy350bksw0iNwaoM1CaBQ0InGUocpNPbHOVLe9BiMOP+EPFaQO2hD4MJg3v+WJzfgZtX2uKCeNn X-Received: by 2002:a05:6a20:7da7:b0:d9:f4e9:546d with SMTP id v39-20020a056a207da700b000d9f4e9546dmr1130613pzj.6.1680151277784; Wed, 29 Mar 2023 21:41:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680151277; cv=none; d=google.com; s=arc-20160816; b=phWtf/ZwgkjAktvlT4p68A6B506xMR+q7kKd8syfTmdrXfLyXBKUVRHcB2X6V7+K/o m9vwy3N0VaB1UosE/3vsF8de/foEPlpfk8C+MSJBNNdhj5gh9oMB3h67j+30+jevDHJc CxqEuG1tsK+g6XW21z/OI4jL9MwA7oYnMuKHXuKH3uP+B9Pl9eICO/mXR4qbIrnOvfPy QDdZeX/Xbl6yvZ7ShdR/zCN19n6CaQfrGcK6VgpLMsX4zzoEGOIuoIvE824hk65TOsRP hiTFACVkcZIJWYI1S9YqLpHTEXujC75DYAEXya9Kq67qVcEdduDXLK/uFP+Xn21asf8u j7QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=N2JGRV/p5sQ5JeBtGy6JzoBqWMYZ6gvTejv5C703vlI=; b=otCU4DQqDw6z1T3hZQA+J2xtgUZtqru2p4Ztz1Zm1G7GXH0SKHSkhy4YvXMtTXURb1 oME9BzcZOtlA6Kk8Vm8Z1poiHrGz4TtMkX1HgaYmaqs+v5bGgcJOISsfdlSHWYWPuDW0 69YZkpM35rjkvqg7+rx3evPokekqQK2J8PqBGaI+Q62X27HH8uuez0CbqMFeuh7mnByB Z2HYrNt35PraJWFyC3ZCCIeqpVgLgB3M49fB+AOxJ+NAnhs+Q9Aqok3jYVzwT1Lab/Vr HiXe5LJUB8JmjvZeBu3VbgnYk0ucdqMfcGcRzUbg4xcfAEzN68qYcDxH1VcLjDBB1By6 NzAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WS36mhqo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r23-20020a63e517000000b004fb64c27835si33105293pgh.524.2023.03.29.21.41.04; Wed, 29 Mar 2023 21:41:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WS36mhqo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbjC3EcX (ORCPT + 99 others); Thu, 30 Mar 2023 00:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjC3EcV (ORCPT ); Thu, 30 Mar 2023 00:32:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D38C10D7; Wed, 29 Mar 2023 21:32:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51B7EB8258C; Thu, 30 Mar 2023 04:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BA01C433D2; Thu, 30 Mar 2023 04:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680150738; bh=BpCkRkfg8i2crE/yPAM4A8j0OQ5LOXAgBqv/LL75Vwc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WS36mhqouLME5EXpvXM6z1aFwhqzU//QhVXjalxXfvk/m6Uz4GR2TZKA5bu/Qkx6/ nHfX6slRdxHA3zW0Xapga3Xk6m0YPbw49DuWiIjcQMgS6qNg4m/I/jVqMs85K0MXN7 1aXpMm9RtKxnhjOZJ0CzvAZlUsPRHYOkjNfh64myejkRM2xbkJL7rahIisXextMqyV 5fILFORu/kCIDeBYpaylop5TSfqsK03EJjNGc220yK10dNIyeEyd6DPPRhdXJL9nuU Sv3wVqxx/MNXh4VHSggV+KzjlftiYu4UFBoJtSLaAPic1BVu3tFLFf5iJPkOiVQcoZ 7/d3a1XYWqlTg== Date: Wed, 29 Mar 2023 21:32:16 -0700 From: Jakub Kicinski To: Sricharan R Cc: , , , , , , , Subject: Re: [PATCH] net: qrtr: Do not do DEL_SERVER broadcast after DEL_CLIENT Message-ID: <20230329213216.7b0447e9@kernel.org> In-Reply-To: <1680095250-21032-1-git-send-email-quic_srichara@quicinc.com> References: <1680095250-21032-1-git-send-email-quic_srichara@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Mar 2023 18:37:30 +0530 Sricharan R wrote: > When the qrtr socket is released, qrtr_port_remove gets called, which > broadcasts a DEL_CLIENT. After this DEL_SERVER is also additionally > broadcasted, which becomes NOP, but triggers the below error msg. > > "failed while handling packet from 2:-2", since remote node already > acted upon on receiving the DEL_CLIENT, once again when it receives > the DEL_SERVER, it returns -ENOENT. > > Fixing it by not sending a 'DEL_SERVER' to remote when a 'DEL_CLIENT' > was sent for that port. You use the word "fix" so please add a Fixes tag. > Signed-off-by: Ram Kumar D > Signed-off-by: Sricharan R Spell out full names, please.