Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <78e35d88-8a4e-3b36-bbbd-94048c0c5b54@redhat.com>
Date:   Thu, 30 Mar 2023 06:47:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v6 0/6] ksm: support tracking KSM-placed zero-pages
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>, yang.yang29@zte.com.cn
Cc:     imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn
References: <202302100915227721315@zte.com.cn>
 <20230328153852.26c2577e4bd921c371c47a7e@linux-foundation.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230328153852.26c2577e4bd921c371c47a7e@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29.03.23 00:38, Andrew Morton wrote:
> On Fri, 10 Feb 2023 09:15:22 +0800 (CST) <yang.yang29@zte.com.cn> wrote:
> 
>> The core idea of this patch set is to enable users to perceive the number of any
>> pages merged by KSM, regardless of whether use_zero_page switch has been turned
>> on, so that users can know how much free memory increase is really due to their
>> madvise(MERGEABLE) actions. But the problem is, when enabling use_zero_pages,
>> all empty pages will be merged with kernel zero pages instead of with each
>> other as use_zero_pages is disabled, and then these zero-pages are no longer
>> monitored by KSM.
> 
> We appear to have some outstanding activity on this quite old patchset.
>  From my notes:
> 
> - An unresponded-to question from Claudia:
> 	https://lkml.kernel.org/r/20230307192421.30ab869c@p-imbrenda
> 
> - Hoping for overall review from David

I already shared some feedback in [1]. I think we should try to simplify 
this handling, as proposed in that mail. Still waiting for a reply.

[1] 
https://lore.kernel.org/all/9d7a8be3-ee9e-3492-841b-a0af9952ef36@redhat.com/

-- 
Thanks,

David / dhildenb