Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d12e0fa-2a40-dc24-ee70-677d5242fd7b@infradead.org>
Date:   Wed, 29 Mar 2023 22:37:50 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: loongarch wakeup build error
Content-Language: en-US
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>
Cc:     loongarch@lists.linux.dev
References: <11215033-fa3c-ecb1-2fc0-e9aeba47be9b@infradead.org>
 <af6281f5-9c6c-d2d7-5978-b637b8d18473@loongson.cn>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <af6281f5-9c6c-d2d7-5978-b637b8d18473@loongson.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 3/29/23 20:33, Tiezhu Yang wrote:
> 
> 
> On 03/30/2023 06:55 AM, Randy Dunlap wrote:
>> Hi,
>>
>> I don't know if this has been reported previously, so here goes.
>>
>> When CONFIG_SUSPEND is not set:
>>
>> loongarch64-linux-ld: drivers/acpi/sleep.o: in function `acpi_pm_prepare':
>> sleep.c:(.text+0x278): undefined reference to `loongarch_wakeup_start'
>> loongarch64-linux-ld: sleep.c:(.text+0x27c): undefined reference to `loongarch_wakeup_start'
>> loongarch64-linux-ld: sleep.c:(.text+0x27c): undefined reference to `loongarch_wakeup_start'
>>
>> A complete randconfig file is attached.
>>
> 
> I can reproduce this build error on LoongArch.
> 
> Here is the call trace:
> 
> acpi_pm_prepare()
>   __acpi_pm_prepare()
>     acpi_sleep_prepare()
>       acpi_get_wakeup_address()
>         loongarch_wakeup_start()
> 
> 
> loongarch_wakeup_start() is defined in arch/loongarch/power/suspend_asm.S
> which is built under CONFIG_SUSPEND. In order to fix the build error, just
> define a empty loongarch_wakeup_start() if CONFIG_SUSPEND is not set.
> 
> diff --git a/arch/loongarch/include/asm/acpi.h b/arch/loongarch/include/asm/acpi.h
> index 4198753aa1d0..7b812a836a5a 100644
> --- a/arch/loongarch/include/asm/acpi.h
> +++ b/arch/loongarch/include/asm/acpi.h
> @@ -39,9 +39,14 @@ extern int loongarch_acpi_suspend(void);
>  extern int (*acpi_suspend_lowlevel)(void);
>  extern void loongarch_suspend_enter(void);
> 
> +#ifdef CONFIG_SUSPEND
> +extern void loongarch_wakeup_start(void);
> +#else
> +static inline void loongarch_wakeup_start(void) {}
> +#endif
> +
>  static inline unsigned long acpi_get_wakeup_address(void)
>  {
> -    extern void loongarch_wakeup_start(void);
>      return (unsigned long)loongarch_wakeup_start;
>  }
> 
> If the above change makes sense, I will send a formal patch later.

LGTM and builds cleanly.
Thanks.

-- 
~Randy