Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1689860rwl; Wed, 29 Mar 2023 23:31:55 -0700 (PDT) X-Google-Smtp-Source: AKy350ZV7izp9EeNYHe8BoFOG49dOrEXdisC8b9mzmBfbUrNb5EaUuWm6DuJxBQeb+JjYOkxYiPL X-Received: by 2002:a05:6402:268e:b0:502:1f7b:f0a6 with SMTP id w14-20020a056402268e00b005021f7bf0a6mr23238171edd.0.1680157914859; Wed, 29 Mar 2023 23:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680157914; cv=none; d=google.com; s=arc-20160816; b=swfSyQIKx7ySvie9R3tgAg/j/GjX7ouF1zUpchdg/uTetm312RLl//rCGFG+qrheTG QcW9jqNxXbxAyfsCAIiR6rm2I0eXfRJLHwlXbogxUX7fVnP6uHHebW9rO0oaU3cqw99d qP+ztvB+fktWjoFfM0NeqpcaUH47rtvdmPN+EUNLQ9MmAMzJ9eZrmvFYRZOEM+c3ok2b fv4cj1jemw8yo5lqJEFZqkc9NYDgC6OWR8DvJv+VTLo9wkT2Yab/MWXGzJhQuiSfKVJH JrsJcY4rR5rGntVGX1xKBgFyjsY69KB1LgpwgQPtOIY2ENDAYptcJldw8kODv2VlKdCs tn2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fCca0hcWNHHp+poYrKE2O16BpH6WOBH3FF8iHomkgt8=; b=Gg3r4m1rHuawBQ2EsQ6UFIbhEex6iZEJWpdorlLPqasmRpJXbGwIiVzGd7zLnMGrzz JKZdu2TCmwobMcNqDPWfOaAHxARJ/v9COAiF9uhCryLQOPwCAwzjlVxafr0BlqdhNC+0 xZNznzJOgljF2W7hUVVmmaeroSZdHP03j4VSbThjqSNBKnpSzCQ8X1ViwoeI9K3exD+h 419URAaVFbaLVNThsbsN273XOcS9cMgVXxaHCeqZgCY81hNZOzK2rJLJW1lTdxm/Qj3I CMq2HTa0rdUj7RVieqtGuIv54zkTy4ktCKIVM/Y7LAyXRESOD88e7TjA3SZmpnHcJDkx dC+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EnIhxxT7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020aa7cf8a000000b0050220a6041asi17992993edx.311.2023.03.29.23.31.29; Wed, 29 Mar 2023 23:31:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EnIhxxT7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230195AbjC3GXj (ORCPT + 99 others); Thu, 30 Mar 2023 02:23:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjC3GXi (ORCPT ); Thu, 30 Mar 2023 02:23:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 989E32720; Wed, 29 Mar 2023 23:23:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28649B825E9; Thu, 30 Mar 2023 06:23:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E141C4339B; Thu, 30 Mar 2023 06:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680157414; bh=35+b81mwaRluJ6TgE8e0K/buT6xsMedun7q+hsyUAnU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EnIhxxT7pm5ZfPOPsdbIksn3dfqxaSREYNxpueJoxt8WHzM+fpGOZUTq0XOrssizK aJpn3HY3ysCnoQzkyNyQhGLiQXN6YnhRYc3QVmRTPc9v8b/sBGbI4ZZprLzaqgCKvE v/X48DKsW9tO6Ka6akF8lBvH4DkoLxK5VWcO2FtTrvt8REa4KPCpQXPCGR4fIW2U8t zbXswVAh/WbDS52pZ6ENoRS/C5ZSYiBWTKX+8y9H66ILGuxNRDlew1aO0Orba6vKr5 oD3VpCtKS0cI4cuugvY7Fdg2k4SS3oSANMVtBB47cFSwO9Y7PsveQsKWMufg7n1GGH TYEuy8o5J/kKA== Date: Thu, 30 Mar 2023 09:23:30 +0300 From: Leon Romanovsky To: Sai Krishna Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sgoutham@marvell.com, richardcochran@gmail.com, Subbaraya Sundeep Subject: Re: [net PATCH 7/7] octeontx2-pf: Disable packet I/O for graceful exit Message-ID: <20230330062330.GP831478@unreal> References: <20230329170619.183064-1-saikrishnag@marvell.com> <20230329170619.183064-8-saikrishnag@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329170619.183064-8-saikrishnag@marvell.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2023 at 10:36:19PM +0530, Sai Krishna wrote: > From: Subbaraya Sundeep > > At the stage of enabling packet I/O in otx2_open, If mailbox > timeout occurs then interface ends up in down state where as > hardware packet I/O is enabled. Hence disable packet I/O also > before bailing out. This patch also free the LMTST per cpu structure > on teardown, if the lmt_info pointer is not NULL. > > Fixes: 1ea0166da050 ("octeontx2-pf: Fix the device state on error") > Signed-off-by: Subbaraya Sundeep > Signed-off-by: Sunil Kovvuri Goutham > Signed-off-by: Sai Krishna > --- > drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 11 ++++++++++- > drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 8 +++++--- > 2 files changed, 15 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky