Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3be8f20-fe56-489e-440c-53ca66f00508@ti.com>
Date:   Thu, 30 Mar 2023 11:50:31 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support
Content-Language: en-US
To:     Apurva Nandan <a-nandan@ti.com>, Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230327083100.12587-1-a-nandan@ti.com>
From:   Bhavya Kapoor <b-kapoor@ti.com>
In-Reply-To: <20230327083100.12587-1-a-nandan@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27/03/23 14:01, Apurva Nandan wrote:
> Add support for eMMC card connected to main sdhci0 instance.
>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>

Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>

> ---
>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index 7480f37e89e8..1622a01a4667 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -21,6 +21,7 @@ chosen {
>
>   	aliases {
>   		serial2 = &main_uart8;
> +		mmc0 = &main_sdhci0;
>   		mmc1 = &main_sdhci1;
>   		i2c0 = &main_i2c0;
>   	};
> @@ -225,6 +226,14 @@ exp2: gpio@22 {
>   	};
>   };
>
> +&main_sdhci0 {
> +	/* eMMC */
> +	status = "okay";
> +	non-removable;
> +	ti,driver-strength-ohm = <50>;
> +	disable-wp;
> +};
> +
>   &main_sdhci1 {
>   	/* SD card */
>   	status = "okay";
> --
> 2.34.1
Looks correct to me.