Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i36794607:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-238-g746678b8b6-fm-20230329.001-g746678b8
Mime-Version: 1.0
Message-Id: <5db9b27a-90df-4916-90da-4e8daeebf9e3@app.fastmail.com>
In-Reply-To: <ZCTOxOGDPoJoZDNW@infradead.org>
References: <20230329071405.1568021-1-geert+renesas@glider.be>
 <ZCTOxOGDPoJoZDNW@infradead.org>
Date:   Thu, 30 Mar 2023 08:51:15 +0200
From:   "Arnd Bergmann" <arnd@kernel.org>
To:     "Christoph Hellwig" <hch@infradead.org>,
        "Geert Uytterhoeven" <geert+renesas@glider.be>
Cc:     "Desnes Nunes" <desnesn@redhat.com>,
        "Christoph Hellwig" <hch@lst.de>,
        "Marek Szyprowski" <m.szyprowski@samsung.com>,
        "Robin Murphy" <robin.murphy@arm.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, "kernel test robot" <lkp@intel.com>,
        noreply@ellerman.id.au
Subject: Re: [PATCH -next] dma-debug: Use %pa to format phys_addr_t
Content-Type: text/plain
Precedence: bulk

On Thu, Mar 30, 2023, at 01:50, Christoph Hellwig wrote:
> I've applied this as it is the first fix I got into my mailbox for it.
>
> Arnd sent one a little later, which uses %pap instead of %pa, which
> confused me a bit.  The documentation seems to allow both without
> any recommendation which one to use, which confuses me even further.

Indeed, I wasn't aware of this either, apparently aaf07621b8bb
("vsprintf: add %pad extension for dma_addr_t use") introduced the
%pap form at the same time as %pad but made it the same as the already
existing %pa. I also see that the %pa form is a lot more common than
%pap, so it's probably better to go with %pa for new users anyway.

    Arnd