Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>,
        Sai Krishna Gajula <saikrishnag@marvell.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>
Subject: RE: [EXT] Re: [net PATCH 1/7] octeontx2-af: Secure APR table update
 with the lock
Thread-Topic: [EXT] Re: [net PATCH 1/7] octeontx2-af: Secure APR table update
 with the lock
Thread-Index: AQHZYmDcLCUiV2jCj02anLGNhlsRqq8S07gAgAANe+A=
Date:   Thu, 30 Mar 2023 06:56:54 +0000
Message-ID: <DM6PR18MB2602944D58392C6FB6576BB8CD8E9@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20230329170619.183064-1-saikrishnag@marvell.com>
 <20230329170619.183064-2-saikrishnag@marvell.com>
 <20230330055532.GK831478@unreal>
In-Reply-To: <20230330055532.GK831478@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Irz6FLGLTWqERtXoXTFxaggXN+NsyN7liiSlydY+ST+D0gAe/6aHDYT/DMYS?=
 =?us-ascii?Q?bs5OfjzrIFUYJOiJmLMRPxPy2uq2TNewTXnA2bG7rchbvhtYhsP1C+YmkyK8?=
 =?us-ascii?Q?Kx2paT1boUZh4/XWme9vL7DMMot6/FzIbwmSt/vYUS6P/543Z/6Yay3yuuUu?=
 =?us-ascii?Q?XoRngh+Z52TwMoiczvjHHH+W/TEwBQS1fxZAu0q2G0muNWKwvNKO6P/TYYoe?=
 =?us-ascii?Q?G3RDmqk6OHC19kGIrksKdYDnqH6EF0ut81AR3OgW1/nNdnDr1tDPQrEKplnL?=
 =?us-ascii?Q?ceU9/Ihsa8jD4TlyZg8zxzhDXfN/ryAIjp6b+eV0Y7oKJKhm7gshgp/pTUfW?=
 =?us-ascii?Q?p3WaW0aqjR3Hw2TSrbF4PZ1JriqsdtKg2vzEf2GEO0DC3EqFFvkyKCBPQ9gC?=
 =?us-ascii?Q?dyaVnDk8ydPY9g+LwBThguyiAgpdk1XKevRKpkcnVj3gLwXFokzASWG+BPbw?=
 =?us-ascii?Q?UsQLdJ5j8gg1fH1bhKnE92zL7Ynk8xS3BinZrb1+pPiFzYfQE998BqnysKkX?=
 =?us-ascii?Q?UF8UvX/BD4E2EH5C99NFvQdj9bJRr9j94CrS/ridg0Ikkt9ahYHGD0q/SSwW?=
 =?us-ascii?Q?8c7J6BTS2ohRtIrBwPZjZMpvrnQ1F/bTgVA+r4xduOksOgkeHQZ/bg/fUdwT?=
 =?us-ascii?Q?WQyeIWOuULKzZacTLtQdvnSO+i6tHjHXw6pJ5vTMDW2DpLM8EPo9DNW+hZ4g?=
 =?us-ascii?Q?W43CU/bQ1x3S1aohl0j+li+CPlqiVeaTkSt0Z42XjgOIopbwJpygE7g2AdgR?=
 =?us-ascii?Q?tdWl3p5nXL4dfsqikxk9QJXDnIQ+1X16hNe01oKIFYXvGW6fHa6fBYM2g/qY?=
 =?us-ascii?Q?86UWxwrTO+0oJnq8m6SmQATNVTgzvNylFLTr/Y4fPANLZdr54SgjPimIAzT1?=
 =?us-ascii?Q?0ZWIS7VXREuW32ZrJqNm58iSJ1rD+K/mZb/txzTSmru7M3mHGVhbDqjI2Air?=
 =?us-ascii?Q?tEn1HqM2SXTVcI+gsxMHThRnT8cAFg1hNexqW3EvqB37hn6nzfLWHWyTF4SP?=
 =?us-ascii?Q?yvAEqWDIG3C4dnZMlZTMhC51iSMPOGOW9TEoPWT9m/W+FQ559YWjPl1zY8bg?=
 =?us-ascii?Q?xQkYhWLGRl9xk1C6MKXMTTwBo6JaLaEAfovTfbwkLpDyljs03zX+280TBLie?=
 =?us-ascii?Q?U+8jTWwF8V9uydWnoT5ddBOoEP9Qsb09ZKAJom6CULIYrvSHbRqNgBiS2lRJ?=
 =?us-ascii?Q?Vzeg9Ct6WnImUPSNq1j+X3LCbw6kpZVJx9cEvskxmhxd1Cis0Lalj2lUNgI1?=
 =?us-ascii?Q?N/6i28zghprZ0zHOsjKhIVwDz5DSeUcjAyAkQBXuEi+4al4DOam3WU9K/Fqq?=
 =?us-ascii?Q?MtssedByPxNNMl13jeJtUwDhf7QUrA6SaeNwGVeLRGVUTQFEb0VsOCAJVY4T?=
 =?us-ascii?Q?CMefRD2KY2OmvXWhzkKXlv0/e7Id0rUzeMl4sNDoyHyvJKmT9rSKfXcuTYGl?=
 =?us-ascii?Q?/z7s+HabGAdl6vfgoyy5aetvV1lTHnxA5UmGDiZNHO5y8ZYntzDE0pJMNx1v?=
 =?us-ascii?Q?xpr6xftdUN7gEhAAKVe/HJLorHErF8kSt8Ptpp38c78qpvOf5Alcjf64jg3o?=
 =?us-ascii?Q?KKIih0qAHZYisdIzVEc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB2602.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1768ccaa-4601-4238-c34b-08db30ebf2a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 06:56:54.8960
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JnMXQnQP4vJEIw8L14WFjIG+2WFSIvM0P0J22Z2tBOnNRJwM5Hko5KiiexxpcmXY0khGcIngJndRlsstRk+7hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4121
X-Proofpoint-ORIG-GUID: a_WWYU0lrbV0as-A2-let7zC0Ip-DVos
X-Proofpoint-GUID: a_WWYU0lrbV0as-A2-let7zC0Ip-DVos
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-30_02,2023-03-30_01,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Leon Romanovsky <leon@kernel.org>=20
>Sent: Thursday, March 30, 2023 11:26 AM
>To: Sai Krishna Gajula <saikrishnag@marvell.com>
>Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redh=
at.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri=
 Goutham <sgoutham@marvell.com>; >richardcochran@gmail.com; Geethasowjanya =
Akula <gakula@marvell.com>
>Subject: [EXT] Re: [net PATCH 1/7] octeontx2-af: Secure APR table update w=
ith the lock

>External Email

>----------------------------------------------------------------------
>On Wed, Mar 29, 2023 at 10:36:13PM +0530, Sai Krishna wrote:
>> From: Geetha sowjanya <gakula@marvell.com>
>>=20
>> APR table contains the lmtst base address of PF/VFs.
>> These entries are updated by the PF/VF during the device probe. Due to=20
>> race condition while updating the entries are getting corrupted. Hence=20
>> secure the APR table update with the lock.

>However, I don't see rsrc_lock in probe path.
>otx2_probe()
>-> cn10k_lmtst_init()
> -> lmt_base/lmstst is updated with and without mbox.lock.

>Where did you take rsrc_lock in probe flow?

rsrc_lock is initialized in AF driver. PF/VF driver in cn10k_lmtst_init() s=
end a mbox request to AF to update the lmtst table.=20
mbox handler in AF takes rsrc_lock to update lmtst table.

Thanks,
Geetha.

>Thanks

>>=20
>> Fixes: 893ae97214c3 ("octeontx2-af: cn10k: Support configurable LMTST=20
>> regions")
>> Signed-off-by: Geetha sowjanya <gakula@marvell.com>
>> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
>> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
>> ---
>>  drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>=20
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c=20
>> b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
>> index 4ad9ff025c96..8530250f6fba 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
>> @@ -142,16 +142,17 @@ int rvu_mbox_handler_lmtst_tbl_setup(struct rvu *r=
vu,
>>  	 * region, if so, convert that IOVA to physical address and
>>  	 * populate LMT table with that address
>>  	 */
>> +	mutex_lock(&rvu->rsrc_lock);
>>  	if (req->use_local_lmt_region) {
>>  		err =3D rvu_get_lmtaddr(rvu, req->hdr.pcifunc,
>>  				      req->lmt_iova, &lmt_addr);
>>  		if (err < 0)
>> -			return err;
>> +			goto error;
>> =20
>>  		/* Update the lmt addr for this PFFUNC in the LMT table */
>>  		err =3D rvu_update_lmtaddr(rvu, req->hdr.pcifunc, lmt_addr);
>>  		if (err)
>> -			return err;
>> +			goto error;
>>  	}
>> =20
>>  	/* Reconfiguring lmtst map table in lmt region shared mode i.e. make=20
>> @@ -181,7 +182,7 @@ int rvu_mbox_handler_lmtst_tbl_setup(struct rvu *rvu=
,
>>  		 */
>>  		err =3D rvu_update_lmtaddr(rvu, req->hdr.pcifunc, val);
>>  		if (err)
>> -			return err;
>> +			goto error;
>>  	}
>> =20
>>  	/* This mailbox can also be used to update word1 of=20
>> APR_LMT_MAP_ENTRY_S @@ -230,6 +231,7 @@ int rvu_mbox_handler_lmtst_tbl_s=
etup(struct rvu *rvu,
>>  	}
>> =20
>>  error:
>> +	mutex_unlock(&rvu->rsrc_lock);
>>  	return err;
>>  }
>> =20
>> --
>> 2.25.1
>>=20