Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 01:11:21 -0600
From:   Lucas De Marchi <lucas.demarchi@intel.com>
To:     Thomas Zimmermann <tzimmermann@suse.de>
CC:     suijingfeng <suijingfeng@loongson.cn>,
        David Airlie <airlied@linux.ie>, liyi <liyi@loongson.cn>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        Sui Jingfeng <15330273260@189.cn>
Subject: Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment
 clause
Message-ID: <20230330071121.pf4tg4pkwrfv2amc@ldmartin-desk2>
References: <20230325074636.136833-1-15330273260@189.cn>
 <a3370ae7-8c78-8170-f9c3-7f616a1fa382@suse.de>
 <20230330041726.w7boceq7ljymvfq2@ldmartin-desk2>
 <f42d8ab8-c765-2517-7d25-6ce1dea320e8@suse.de>
Content-Type: text/plain; charset="iso-8859-1"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f42d8ab8-c765-2517-7d25-6ce1dea320e8@suse.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?R7FoF7IVNsXIrNMPniKvxd9iNYnK2ZZ8h1hvVmZwHQmiE2IXZh7xJEOI4w?=
 =?iso-8859-1?Q?6isdBzw1ovtw5WHmCnkDk0k+RtwFcR98IBjOLOCG+Fl98meW1XYfQymwH3?=
 =?iso-8859-1?Q?ICD/J5Lq+RqK/GK9+8DKy3buYxp0cmF4GxQgM/dd6G/It3fefQRaNT7ytv?=
 =?iso-8859-1?Q?v3By/LoJIY+LsjEuCLHPPZR4k+q0arG2ub4oxWgOYl5fB1iOzrrkNkiPTM?=
 =?iso-8859-1?Q?VBpUl5AjhuHlnVKdx30dU5Wkmtf8FTtqwBCw+9fj8RtoEngLAkLmyGbETX?=
 =?iso-8859-1?Q?rbjcX+uquMH0GSEXWxwG8TuI6GKF9pNDxjrPr5uM2PEG2qyosR6+Z09s4q?=
 =?iso-8859-1?Q?r+nlMtxzXIBbIRu4FXiwZmYUKILQBIAi6lJM2pMaemrjRzbSVBX50FjnuX?=
 =?iso-8859-1?Q?CBcvrmVZKTpWy6igVGLmXvGzzGCL4o710YYE3cYZSsdaaLgpspFUJwHI0q?=
 =?iso-8859-1?Q?iTf80qk54qjP6wSiUOo7UY9cwHO6tMvloK7Fn4KFFt1kGCK7+dsmVEgCca?=
 =?iso-8859-1?Q?CVZq+QwcU8t0uJfT11PgSqIhNfGzbueDmuo+/SeqzbEVOHMYgGXHqv4MqH?=
 =?iso-8859-1?Q?53M5+S9vjsR892Cz9sqBvzaR1TPgLEgZ7ABQ/DIqkZkCIWFpzbo+JD6PCS?=
 =?iso-8859-1?Q?nVtLtAyALIsshS5NOuuiAhcJGCJ0XKSWWaYmdS/L4rLbN6qA+FxEIjFlwc?=
 =?iso-8859-1?Q?6/ha5k81yK/fvawY26pAtjsEn0gG0pFM2J+FakkjDiSQnXFeodACUYuKSE?=
 =?iso-8859-1?Q?rgbDFkmPTLqrfY4w6S/QQ+h1rM6JaJklzWpIDilCyw7qHOD6iHFIrQZqbs?=
 =?iso-8859-1?Q?+XLjrRO5+yE7EVNhQfY7ifjNze+AIaIwQJwno9bNDaGnKga0ofMYsH9+UO?=
 =?iso-8859-1?Q?T41iA6YzvU63FWJZj8SMNWJcPnIDrJq2dov12dA5ED+FHEJpLJ1dwntITd?=
 =?iso-8859-1?Q?V7J5EO9GMyDpym0QoV0rsiveWGm1wbbR8UUEAVgy6IHl1tSXMNMbtVsufj?=
 =?iso-8859-1?Q?ZB4K9suMX8haH0hoDo20ck62pIbyzA7EE2lg680xSE1U1yjOe7B68D5END?=
 =?iso-8859-1?Q?R4xWduzED4WpgbLv/KKM+r0iE8lqGHpQBQW0VEUSzKWXzg7BG+IOAOYuIk?=
 =?iso-8859-1?Q?s28nPz7SIm/Y7kdTFjzRYzAvGnwML9xjJn2lMJVAsH1kBFWl8X6ENmgGad?=
 =?iso-8859-1?Q?7ie3xxcC1TkTB2yv95HIUezlzLu3vQE3BMj+aUods4274NIS62Umrwc8Mh?=
 =?iso-8859-1?Q?scpxtboQBdQH1/1LStEMQp4pl2QNKL3fo4jXMRrOIphhyhuq6uxvcjqUD9?=
 =?iso-8859-1?Q?T2+lIyDFLh9WkyjXnakxMOjXE0Pai3Xx1DQ9YMsIZuwNnLMbQIBcp9f0Oz?=
 =?iso-8859-1?Q?0zWv89rpvEzblLaypr4p6iizLWjZskopjzFN3zt3iUrSgCiuXbj2RW8bd3?=
 =?iso-8859-1?Q?rMKGkkkm53yQ/0tlXhgLVwYl9K0JrNq4SSKNpivaBaHNrXHyeI3o1AaNx4?=
 =?iso-8859-1?Q?I0zEbKGcLwgD1l9vtHsX9/VgzhR3fTKklf5inHACcseoatLVqMOnJnrnyA?=
 =?iso-8859-1?Q?d5n8bnvcQGDD3dHDVhYV81baEoCiZn07v27Uc2oa9GAn/sFBRo5kwbfYiY?=
 =?iso-8859-1?Q?jhEmhG7K0boS6Roq1THQrlljy3qMtfC9LpLP4pq6AyAgAukXppYVE96Q?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e825ad95-9744-4e35-31f2-08db30ee0711
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 07:11:48.4268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gx5wFsG1Lp1TIffyKBMWuqCS6Wvulql7tsTvn1Xi7TD0XFdxtM0A5w9rZ+3l92G4shVIb+KNVyXlznJ7Jshdq4spXUbPPOsZ03W2EWTUOJ4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5710
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 30, 2023 at 08:57:36AM +0200, Thomas Zimmermann wrote:
>Hi
>
>Am 30.03.23 um 06:17 schrieb Lucas De Marchi:
>>On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote:
>>>(cc'ing Lucas)
>>>
>>>Hi
>>>
>>>Am 25.03.23 um 08:46 schrieb Sui Jingfeng:
>>>>?The assignment already done in drm_client_buffer_vmap(),
>>>>?just trival clean, no functional change.
>>>>
>>>>Signed-off-by: Sui Jingfeng <15330273260@189.cn>
>>>>---
>>>>?drivers/gpu/drm/drm_fbdev_generic.c | 5 ++---
>>>>?1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>>diff --git a/drivers/gpu/drm/drm_fbdev_generic.c 
>>>>b/drivers/gpu/drm/drm_fbdev_generic.c
>>>>index 4d6325e91565..1da48e71c7f1 100644
>>>>--- a/drivers/gpu/drm/drm_fbdev_generic.c
>>>>+++ b/drivers/gpu/drm/drm_fbdev_generic.c
>>>>@@ -282,7 +282,7 @@ static int drm_fbdev_damage_blit(struct 
>>>>drm_fb_helper *fb_helper,
>>>>????????????????? struct drm_clip_rect *clip)
>>>>?{
>>>>???? struct drm_client_buffer *buffer = fb_helper->buffer;
>>>>-??? struct iosys_map map, dst;
>>>>+??? struct iosys_map map;
>>>>???? int ret;
>>>>???? /*
>>>>@@ -302,8 +302,7 @@ static int drm_fbdev_damage_blit(struct 
>>>>drm_fb_helper *fb_helper,
>>>>???? if (ret)
>>>>???????? goto out;
>>>>-??? dst = map;
>>>>-??? drm_fbdev_damage_blit_real(fb_helper, clip, &dst);
>>>>+??? drm_fbdev_damage_blit_real(fb_helper, clip, &map);
>>>
>>>I see what you're doing and it's probably correct in this case.
>>>
>>>But there's a larger issue with this iosys interfaces. Sometimes 
>>>the address has to be modified (see calls of iosys_map_incr()). 
>>>That can prevent incorrect uses of the mapping in other places, 
>>>especially in unmap code.
>>
>>using a initializer for the cases it's needed IMO would make these kind
>>of problems go away, because then the intent is explicit
>>
>>>
>>>I think it would make sense to consider a separate structure for 
>>>the I/O location. The buffer as a whole would still be represented 
>>>by struct iosys_map.? And that new structure, let's call it struct 
>>>iosys_ptr, would point to an actual location within the buffer's
>>
>>sounds fine to me, but I'd have to take a deeper look later (or when
>>someone writes the patch).? It seems we'd replicate almost the entire
>>API to just accomodate the 2 structs.? And the different types will lead
>>to confusion when one or the other should be used
>
>I think we can split the current interface onto two categories: 
>mapping and I/O. The former would use iosys_map and the latter would 
>use iosys_ptr. And we'd need a helper that turns gets a ptr for a 
>given map.
>
>If I find the tine, I'll probably type up a patch.

yeah, a split would make it better rather than just make iosys_ptr
replace the current cases where we copy the struct. In this case most
places passing a buffer around in the same driver would migrate to
iosys_ptr.

thanks
Lucas De Marchi

>
>Best regards
>Thomas
>
>>
>>thanks
>>Lucas De Marchi
>>
>>>memory range. A few locations and helpers would need changes, but 
>>>there are not so many callers that it's an issue.? This would also 
>>>allow for a few debugging tests that ensure that iosys_ptr always 
>>>operates within the bounds of an iosys_map.
>>>
>>>I've long considered this idea, but there was no pressure to work 
>>>on it. Maybe now.
>>>
>>>Best regards
>>>Thomas
>>>
>>>>???? drm_client_buffer_vunmap(buffer);
>>>
>>>-- 
>>>Thomas Zimmermann
>>>Graphics Driver Developer
>>>SUSE Software Solutions Germany GmbH
>>>Maxfeldstr. 5, 90409 N?rnberg, Germany
>>>(HRB 36809, AG N?rnberg)
>>>Gesch?ftsf?hrer: Ivo Totev
>>
>>
>>
>
>-- 
>Thomas Zimmermann
>Graphics Driver Developer
>SUSE Software Solutions Germany GmbH
>Maxfeldstr. 5, 90409 N?rnberg, Germany
>(HRB 36809, AG N?rnberg)
>Gesch?ftsf?hrer: Ivo Totev