Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230330060105.29460-1-rdunlap@infradead.org> <e1b6f12a-899b-4985-8725-556bcb5d0991@spud>
In-Reply-To: <e1b6f12a-899b-4985-8725-556bcb5d0991@spud>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 30 Mar 2023 09:31:27 +0200
Message-ID: <CAMuHMdW2r1f7C_BdXn9BnDktLwHjBA_0Kvq6OeLJ1sZ7azhqkg@mail.gmail.com>
Subject: Re: [PATCH] iommu: PGTABLE_LPAE is also for RISCV
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev,
        Conor Dooley <conor@kernel.org>,
        linux-riscv@lists.infradead.org, geert+renesas@glider.be
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Conor,

On Thu, Mar 30, 2023 at 8:25 AM Conor Dooley <conor.dooley@microchip.com> wrote:
> On Wed, Mar 29, 2023 at 11:01:05PM -0700, Randy Dunlap wrote:
> > On riscv64, linux-next-20233030 (and for several days earlier),
> > there is a kconfig warning:
> >
> > WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE
> >   Depends on [n]: IOMMU_SUPPORT [=y] && (ARM || ARM64 || COMPILE_TEST [=n]) && !GENERIC_ATOMIC64 [=n]
> >   Selected by [y]:
> >   - IPMMU_VMSA [=y] && IOMMU_SUPPORT [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) && !GENERIC_ATOMIC64 [=n]
> >
> > and build errors:
> >
> > riscv64-linux-ld: drivers/iommu/io-pgtable-arm.o: in function `.L140':
> > io-pgtable-arm.c:(.init.text+0x1e8): undefined reference to `alloc_io_pgtable_ops'
> > riscv64-linux-ld: drivers/iommu/io-pgtable-arm.o: in function `.L168':
> > io-pgtable-arm.c:(.init.text+0xab0): undefined reference to `free_io_pgtable_ops'
> > riscv64-linux-ld: drivers/iommu/ipmmu-vmsa.o: in function `.L140':
> > ipmmu-vmsa.c:(.text+0xbc4): undefined reference to `free_io_pgtable_ops'
> > riscv64-linux-ld: drivers/iommu/ipmmu-vmsa.o: in function `.L0 ':
> > ipmmu-vmsa.c:(.text+0x145e): undefined reference to `alloc_io_pgtable_ops'
> >
> > Add RISCV as an allowed ARCH dependency to fix these problems.
> >
> > Fixes: d286a58bc8f4 ("iommu: Tidy up io-pgtable dependencies")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Joerg Roedel <joro@8bytes.org>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > Cc: iommu@lists.linux.dev
> > Cc: Conor Dooley <conor@kernel.org>
> > Cc: linux-riscv@lists.infradead.org
> > ---
> >  drivers/iommu/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -- a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -32,7 +32,7 @@ config IOMMU_IO_PGTABLE
> >  config IOMMU_IO_PGTABLE_LPAE
> >       bool "ARMv7/v8 Long Descriptor Format"
>
> I'm probably missing something here, but why would we want to enable
> "ARMv7/v8 Long Descriptor Format" on RISC-V?

Indeed, we should not enable it, unless compile-testing.

> Would it not be better to make the Renesas depend on, rather than
> select the option? It does seem highly arch specific, and I feel like
> Geert previously mentioned that the RZ/Five (their RISC-V offering)
> didn't use it.

I think the IPMMU_VMSA dependency should gain

        depends on ARM || ARM64 || COMPILE_TEST

> >       select IOMMU_IO_PGTABLE
> > -     depends on ARM || ARM64 || COMPILE_TEST
> > +     depends on ARM || ARM64 || RISCV || COMPILE_TEST
> >       depends on !GENERIC_ATOMIC64    # for cmpxchg64()
> >       help
> >         Enable support for the ARM long descriptor pagetable format.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds