Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ifd214418:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-238-g746678b8b6-fm-20230329.001-g746678b8
Mime-Version: 1.0
Message-Id: <004cfeda-1c40-4fce-b5d5-1ecc02a8909a@app.fastmail.com>
In-Reply-To: <CACRpkdZSJCZZEkD0V_wint+a1XKsbCQFuArFvPdFP8RSDsGLMQ@mail.gmail.com>
References: <0dcc1aac-9a6a-4d17-be68-a895cb6120da@app.fastmail.com>
 <CACRpkdZSJCZZEkD0V_wint+a1XKsbCQFuArFvPdFP8RSDsGLMQ@mail.gmail.com>
Date:   Thu, 30 Mar 2023 18:00:43 +1000
From:   Alistair <alistair@alistair23.me>
To:     "Linus Walleij" <linus.walleij@linaro.org>
Cc:     ye.xingchen@zte.com.cn,
        "Sebastian Reichel" <sebastian.reichel@collabora.com>,
        sre@kernel.org, pali@kernel.org, sravanhome@gmail.com,
        linux-pm@vger.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: power_supply_show_property Kernel Oops
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 30 Mar 2023, at 12:43 AM, Linus Walleij wrote:
> On Wed, Mar 29, 2023 at 1:16=E2=80=AFPM Alistair <alistair@alistair23.=
me> wrote:
>=20
> > [    2.466136]  string from vsnprintf+0x158/0x424
> > [    2.470603]  vsnprintf from vscnprintf+0x10/0x24
> > [    2.475241]  vscnprintf from sysfs_emit+0x50/0xac
> > [    2.479975]  sysfs_emit from power_supply_show_property+0x1d0/0x2=
6c
> > [    2.486269]  power_supply_show_property from add_prop_uevent+0x30=
/0x8c
> > [    2.492815]  add_prop_uevent from power_supply_uevent+0xb4/0xe4
> > [    2.498753]  power_supply_uevent from dev_uevent+0xc4/0x21c
> > [    2.504352]  dev_uevent from kobject_uevent_env+0x1cc/0x510
> > [    2.509953]  kobject_uevent_env from power_supply_changed_work+0x=
7c/0xb4
> > [    2.516675]  power_supply_changed_work from process_one_work+0x1e=
8/0x3e8
> > [    2.523396]  process_one_work from worker_thread+0x2c/0x504
> > [    2.528986]  worker_thread from kthread+0xcc/0xec
> > [    2.533716]  kthread from ret_from_fork+0x14/0x24
> > [    2.538443] Exception stack(0xf0dadfb0 to 0xf0dadff8)
>=20
> This looks like running a worker before something this worker is acces=
sing
> has been set up.
>=20
> > As it's on a consumer device I don't have a way to connect a debugge=
r. So I'm
> > a little stuck on what the problem is. The only related change I see=
 between
> > 6.2 and 6.3-rc4 is commit a441f3b90a340e5c94df36c33fb7000193ee0aa7
> > "power: supply: use sysfs_emit() instead of sprintf() for sysfs show=
()", but
> > that doesn't look like it would cause this oops.
>=20
> Did you try reverting it?

I did after I sent this. Reverting the commit doesn't fix the issue.

Alistair

>=20
> Yours,
> Linus Walleij
>=20