Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762855AbXIUUH6 (ORCPT ); Fri, 21 Sep 2007 16:07:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755285AbXIUUHv (ORCPT ); Fri, 21 Sep 2007 16:07:51 -0400 Received: from nic.NetDirect.CA ([216.16.235.2]:51456 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754370AbXIUUHu (ORCPT ); Fri, 21 Sep 2007 16:07:50 -0400 X-Originating-Ip: 72.143.66.27 Date: Fri, 21 Sep 2007 16:06:16 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Alexey Dobriyan cc: David Rientjes , linux-kernel@vger.kernel.org, andrea@suse.de, clameter@sgi.com Subject: Re: + oom-move-prototypes-to-appropriate-header-file.patch added to -mm tree In-Reply-To: <20070921195403.GC1857@martell.zuzino.mipt.ru> Message-ID: References: <200709210910.l8L9AttS028186@imap1.linux-foundation.org> <20070921170548.GA1857@martell.zuzino.mipt.ru> <20070921195403.GC1857@martell.zuzino.mipt.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-16.8, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, INIT_RECVD_OUR_AUTH -20.00, RCVD_IN_SORBS_DUL 20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 39 On Fri, 21 Sep 2007, Alexey Dobriyan wrote: > On Fri, Sep 21, 2007 at 12:38:03PM -0700, David Rientjes wrote: > > On Fri, 21 Sep 2007, Alexey Dobriyan wrote: > > > > > > Move the OOM killer's extern function prototypes to include/linux/oom.h and > > > > include it where necessary. > > > > > > > > Cc: Andrea Arcangeli > > > > Acked-by: Christoph Lameter > > > > > > NAK. Target in corresponding Kbuild is wrong. sched.h is overkill. > > > Could we please also drop extern's while in protos? > > > > > > > I'll prevent including sched.h in a follow-up patchset that I'll be > > posting soon (and you'll be Cc'd). Which Kbuild target are you referring > > to? > > It's header-y vs unifdef-y in include/linux/Kbuild. The former is > for plain headers exported to userspace as-is. The latter need > preprocessing to remove __KERNEL__, CONFIG_*, etc. AFAIK, the only preprocessing that's removed is "__KERNEL__". rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/