Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <502523a9-9737-d9ce-8ee5-ca8d39fc0c52@nvidia.com>
Date:   Thu, 30 Mar 2023 09:50:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 4/5] serial: 8250_tegra: Add explicit include for of.h
To:     Rob Herring <robh@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Marc Zyngier <maz@kernel.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-acpi@vger.kernel.org,
        devicetree@vger.kernel.org
References: <20230329-acpi-header-cleanup-v1-0-8dc5cd3c610e@kernel.org>
 <20230329-acpi-header-cleanup-v1-4-8dc5cd3c610e@kernel.org>
Content-Language: en-US
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20230329-acpi-header-cleanup-v1-4-8dc5cd3c610e@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnExQkFHRkhuY0NZWTA3SU1xMExMNzFEbzNWSk1jNXMvYjVvNTJnS0FVeUM5?=
 =?utf-8?B?eWh5SWRqOUxVcU5ucHcwSjZSeTAxMzZyK3drNUdsR2k5VlRCNVVjNTNCbW04?=
 =?utf-8?B?aXNKNS9jbnB4ckExRUx5TFBNdUZEN3hyRWM4alNBZlh3QVlOR0JHTHdCSVRP?=
 =?utf-8?B?VTNIbEk5eTdmc1FJNGFMajA1Q1hoMG9RdVgrcm1hZ1ZjOU9VbytPaTFnZUVW?=
 =?utf-8?B?Mk1WQW41SzRrUU1qQ3dhbW8xSFJUN2RvdkRjZVV5eHJoU1F6VHN6NCtjZnRo?=
 =?utf-8?B?VVZacSttQzRCZ1dwczBZSmRNNXVEYXlLSXFYUWRpeGZTQ0dNMTZpNWtnU2Qx?=
 =?utf-8?B?dzU2aEZsMDE3YmJ3eW9aTFNKZDArQVRhMTFiekdzbXpYTG9tVGVFK0QzSGlB?=
 =?utf-8?B?S2hWU20wbUlLYmRIdDBxT2Y4b2lJZzM2YkRxalBqTmZqVDhiN3Zhdjh3WlhW?=
 =?utf-8?B?d3ZDbmNXWkRNM1laMng4QVdvbFJHci9USFJVN2praXJoV1YyUXZCcGNMKy8y?=
 =?utf-8?B?M3FmWjVoajdLYlNJVGE4dXZndEU4aFZDYUVJRkxkaXd4eEdtbGx0MCs3K1gz?=
 =?utf-8?B?UUhDREg2QVdobUgycjhKSkM1eW5rdW9OU2hrVGJmS285SEFlbU5EakdSUUl4?=
 =?utf-8?B?U1NIc1BSanBweUd5cld2am8vaC9XQzEyNlIyalpZLytDdHR5UG1FTDNhSVVV?=
 =?utf-8?B?ZmUySlNZNmZYRkMwN2xMMDdUTW83RWNqT0VOanY5elhwdHNQOVJlNHQ0MnRy?=
 =?utf-8?B?Sm0vMCs4ckw1UmNqOXhXM0RudWFMcnZMNVJhVnc1b0lxQUxXZEE4NFZ6UUtn?=
 =?utf-8?B?QW1CaEp4bTFVQXR6MzdqYWN2TlJpRnZTU3E2RkJpekQrZmUwc3ZKOXRuNHg4?=
 =?utf-8?B?Z2c3aWd4REYvTk1rNDhKSnV1UnFzR2NhVWxMMHRIUnRxOVdvclhTcUZHWXZ6?=
 =?utf-8?B?QjgzR1VIZUxCdENMeEMxY2UwNjF2T1VGcW5PYVFVYTlEWXVuVTljaVpUZzd2?=
 =?utf-8?B?cGVpZy85bkdmNDhadWlsQzJQWW02bmhIN09FclUzeFZjZFlpSkYvTlhDTkJU?=
 =?utf-8?B?dW5UcmgvemhTVnRJYUY0OElTNXQxQklHUUs4TVVmbkpPTjY3S0JJN2JyaTYv?=
 =?utf-8?B?Q3ZIcmhWOStYdkVSdGRQMmtPN1Y0aCtwRURRVng2ZzRtZVZOaXN3dmtzM1do?=
 =?utf-8?B?OXczS2ttU0htemhLcUxDdUJGc0dWNk9YL1JFTEx0RzE0cjBGNk5YV2Vzek03?=
 =?utf-8?B?RVNoWitoMGh4R1NEMzRpS0o5cWtOTHFyT0c1cTBYRWF6WkZtN1gzUWtFaWZV?=
 =?utf-8?B?UzBwS21HRTlKWkVzdE8xVTd1N1Evd2duZmwyQTZqNktPeVFTU1JJWVJHWHIz?=
 =?utf-8?B?cXByMjYrUDduaENpeGlCUGZqTUJNU2dZSEtnV1BDZVUrMlFtOGozRS8vMEwz?=
 =?utf-8?B?UXJEdjI4UThoVHo1NllObVpFd2d4dHJDSFRiNENtVUxPWmNKQWxoZVNWdXJT?=
 =?utf-8?B?LzhXbUhZTm5va1EvWUMvN1FCU3JjZmNVcG9XTEZVcDk0QXE2WmtWemRadmNO?=
 =?utf-8?B?VTlhOHg0RThyeEpqTys4T2dLUnBjODQvV2RIcVNYcDhEaWxHb0ZPVzJpTkRK?=
 =?utf-8?B?ZlJleExVb1pOQTJMeWxaT0t1K2llQkpBekQ0M1VxeUtNMXdmRG16RDZHSDFt?=
 =?utf-8?B?bzRzN1p2NEorR3ZmNHNVNVNRYUhEWTV3RVZ1Tll5VGN2ZHorQkt5MzdYcmwy?=
 =?utf-8?B?N1MxeHVoSG9uTU5TNG5WOEtmZHZlNWlBKzVqSTB0VmJKU0hQTy9JS01tNXFl?=
 =?utf-8?B?NVRtWlorcWlzRVFrZ2dURHVnYWtuSG1WOFVodTk2a0dQTVl3SVpYS2ptOTVy?=
 =?utf-8?B?eTJtVEV4MEpMak1lVjFZYVN3Q0IxeTA0U052cWJwckQzTWdpelp3T1BZdDFB?=
 =?utf-8?B?OFJtNEpiNEgxUmJ0RytPNHZuV1B4SlVtWjAzU1NESVNqOVhkRmswSUhyWDcw?=
 =?utf-8?B?T3dEV1J5aDJ2NmFXKzArcnE3eHhGZHBHSUFpZjkrZEc4ZXZueWFTRXNEMFpO?=
 =?utf-8?B?SHJiTGF2THdtYm84SHhTTnFBVnQ3L0t1N0xJeXllR3FIV0tJSjVBSDlMb3Qv?=
 =?utf-8?B?R3ZxNDFWNVVaUEFWVXdhUlJBa1BSY3RvdHlIMW1HWmIwdi9nKzNMSDhiRm9a?=
 =?utf-8?B?eVE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 887686ea-9cf4-437b-7f29-08db30fbd702
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 08:50:41.0173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1A2OHZBSMWyPnKRifX0I/YPxAxz5T31l2E/AOwMR1z0pFDa4v3N7k4UYyW7MjUg0TnwoPbLwZyazuL2lxmpIQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6587
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29/03/2023 22:20, Rob Herring wrote:
> With linux/acpi.h no longer implicitly including of.h, add an explicit
> include of of.h to fix the following error:
> 
> drivers/tty/serial/8250/8250_tegra.c:68:15: error: implicit declaration of function 'of_alias_get_id' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   drivers/tty/serial/8250/8250_tegra.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_tegra.c b/drivers/tty/serial/8250/8250_tegra.c
> index e7cddeec9d8e..2509e7f74ccf 100644
> --- a/drivers/tty/serial/8250/8250_tegra.c
> +++ b/drivers/tty/serial/8250/8250_tegra.c
> @@ -11,6 +11,7 @@
>   #include <linux/delay.h>
>   #include <linux/io.h>
>   #include <linux/module.h>
> +#include <linux/of.h>
>   #include <linux/reset.h>
>   #include <linux/slab.h>
>   
> 


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic