Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 05:46:09 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Domenico Cerasuolo <cerasuolodomenico@gmail.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        surenb@google.com, brauner@kernel.org, chris@chrisdown.name
Subject: Re: [PATCH v5 4/4] sched/psi: allow unprivileged polling of N*2s
 period
Message-ID: <ZCVaYYmPZsFmc+/1@cmpxchg.org>
References: <20230330081100.11871-1-cerasuolodomenico@gmail.com>
 <20230330081100.11871-5-cerasuolodomenico@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330081100.11871-5-cerasuolodomenico@gmail.com>
Precedence: bulk

Hi Domenico,

thanks, the destruction path looks right to me now.

On Thu, Mar 30, 2023 at 10:11:00AM +0200, Domenico Cerasuolo wrote:
> @@ -1319,11 +1353,16 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
>  		rcu_assign_pointer(group->rtpoll_task, task);
>  	}
>  
> -	list_add(&t->node, &group->rtpoll_triggers);
> -	group->rtpoll_min_period = min(group->rtpoll_min_period,
> -		div_u64(t->win.size, UPDATES_PER_WINDOW));
> -	group->rtpoll_nr_triggers[t->state]++;
> -	group->rtpoll_states |= (1 << t->state);
> +	if (privileged) {
> +		list_add(&t->node, &group->rtpoll_triggers);
> +		group->rtpoll_min_period = min(group->rtpoll_min_period,
> +			div_u64(t->win.size, UPDATES_PER_WINDOW));
> +		group->rtpoll_nr_triggers[t->state]++;
> +		group->rtpoll_states |= (1 << t->state);
> +	} else {
> +		list_add(&t->node, &group->avg_triggers);
> +		group->avg_nr_triggers[t->state]++;
> +	}
>  
>  	mutex_unlock(&group->rtpoll_trigger_lock);

But creation needs the same treatment. group->avg_triggers and
avg_nr_triggers are protected by the avgs_lock, not the
rtpoll_trigger_lock.

I suppose the lock taking and the group->rtpoll_task creation
(anything with rtpoll in the name, really) should be within a big

	if (privileged) {
		rtpoll_trigger_lock()
		kthread_create()
		init-and-link()
		rtpoll_trigger_unlock()
	} else {
		avgs_lock()
		...
	}