Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXT] Re: [net PATCH 3/7] octeontx2-af: Add validation for lmac
 type
Thread-Topic: [EXT] Re: [net PATCH 3/7] octeontx2-af: Add validation for lmac
 type
Thread-Index: AQHZYmDeXzOo7CyzoU608CFuRZt47a8S2i4AgAA9ijA=
Date:   Thu, 30 Mar 2023 10:08:59 +0000
Message-ID: <BY3PR18MB470786C30C037BFD519147C3A08E9@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230329170619.183064-1-saikrishnag@marvell.com>
 <20230329170619.183064-4-saikrishnag@marvell.com>
 <20230330061840.GM831478@unreal>
In-Reply-To: <20230330061840.GM831478@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R7aGBCUwzNmLNfSr4keOtqRJ7JUBTUDeeZQmmmVQKaw/aWrOaI9mgqFCOnnk?=
 =?us-ascii?Q?2bvg4M+92XKl1uDnkzDJ+YsPOT8dMk/a8Rmml+QCcmKwSeYIU6tQG3NqILxh?=
 =?us-ascii?Q?Vu4CDszorUVw3sCYNsiysx5FIwVi4zkU/BqrvGXgtdtlOIrbCg7rCuaWiNTw?=
 =?us-ascii?Q?vxmgo8x+oM9B09NtnWnssXWAIVbYbZ7Jx7Ux2rP4cLaFEUKfwL1mCLmzVFXE?=
 =?us-ascii?Q?sifm9AuXIp4r7dVo4uf29Q19AURSQXn7nWETeuPeIKOp05akyY3kTOrULy1c?=
 =?us-ascii?Q?vVRT+wNgcTgIqniojXYDoiyxNTiPmFcywVqW7+J52HzoPFgQ8XrGW33L0u3N?=
 =?us-ascii?Q?Fq+7tAyXbtRQnDZFiTC5lr+v2ji5T5M4O9CZN+oKyyjNEebBHvelKnX6OyEc?=
 =?us-ascii?Q?riohYLLRljZUG2n15wCCBvA0CVb89xnnzqRlGvPCTyeT9oenayLyZA3Yo9aQ?=
 =?us-ascii?Q?YeCxvTNO5Y9hpSxCSUGbtkIxQ9SDm8IfsvT0Cr+/PLp7fNbEzSdyucDzqkO1?=
 =?us-ascii?Q?Jg6s35uYFZ9Fe5l+olEhEVFeamLUMlaH4c10ANMB99tnGtsR0gaZu7Ls/mWL?=
 =?us-ascii?Q?EBXme6gO48HysGO9YNVI1BnzNGkAvfDCm0UFTOjRGfmXFBVG/DMh4LZDc7XS?=
 =?us-ascii?Q?JBC09Z+uH+bAJgUqXpDurBdZhy2+WMCQKshl+mZMvcAJb7+mwjl0iPGcPMl/?=
 =?us-ascii?Q?UTT0i773gLZJ9HCpNoOoUloH7N/o222jFJwM46+mtWUg+9cMkty2hQK5mKh2?=
 =?us-ascii?Q?DDxVQDMlKABjDoBcjN8j2nznPo2j6XpyooOQHhEfe0jcD03AJKgP/CU6ibON?=
 =?us-ascii?Q?4QpGdLAm9IJRcFeVHFSjyrmrkHGFovf+Wznx0fG8vFgzbxmvyCqtZ1vEDzZP?=
 =?us-ascii?Q?C0ehHS1HNnMUVMSzLya4iozMhnzRCCgEjCkTSOjTv2Og9kYMhPbBgjMDHhVd?=
 =?us-ascii?Q?kki/RerSVCf82omRqC9dKJt+7jhn4KVVDC8ooODUC0qDW1Nbl/yDcaWb0S45?=
 =?us-ascii?Q?R8bw6sFzHAIUFK9NgHOpRzFf0DOq3Xql9J0gPVmUb5zoz0vLJ3rE1oZAnEZ7?=
 =?us-ascii?Q?BZW4PvB6wUdEOLF6OiZIk35Jbq4DnPxo60t9UxSuTPAoz9sslTNfiu5JOQut?=
 =?us-ascii?Q?rWARLL+T2VehiWGV+LWRYRmfUBBrZF3aFSLO3b54ds7ZgVtx6UXQFB3ecOe8?=
 =?us-ascii?Q?PJXKk16wJLrlRG3RfNeElFk4pUqs6s7lSJEaL7bJOXgrKlfCIgCSMSDPpOi6?=
 =?us-ascii?Q?jzwqt5OMgQRHUVNvEv2vrJ/8rNKDgeskHbvvSFYY9PPdKKUN9qPv8djeWpgk?=
 =?us-ascii?Q?gP/g+xM9pUYgJEXFMHh2vlX/NV2OkucHQ3PxiG+x8Nmg4ujQ17JVqNJR2yYa?=
 =?us-ascii?Q?whDignQbB/QROlRUNWWuzZSKQrbk1Zt3KoozhUrNAG8YdIT6bplmt/yo58ix?=
 =?us-ascii?Q?QRA6mdYaVY8kQVko0sw8wFNvM26dlEdS/AbFdJ4M3fUtw5v0aIFZ3ElrqL9V?=
 =?us-ascii?Q?YrtE4dBmVp8C9OiCYTsbIzJKC2th6ZFPEmY4AX+qvvwsPrJ7f0cZtkd/dQ3I?=
 =?us-ascii?Q?uJBwFnaD7H4ebL153IV17UahTerSWvUI8YUyv9PH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dbf4141-c78c-4fe8-7362-08db3106c7c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 10:08:59.4106
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B+KIycUjQWSnQI07jF4Tb9N8ZYfb0KFHHbeL0cCEieCk+DIylelY0N3mizUohL4YLqTmuv7Z3sLUEzrNQllI1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3919
X-Proofpoint-ORIG-GUID: eAM2zbAwG2YQr0eAOr3jfSDJcfBhpVNl
X-Proofpoint-GUID: eAM2zbAwG2YQr0eAOr3jfSDJcfBhpVNl
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-30_04,2023-03-30_01,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline.

> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Thursday, March 30, 2023 11:49 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> richardcochran@gmail.com; Hariprasad Kelam <hkelam@marvell.com>
> Subject: [EXT] Re: [net PATCH 3/7] octeontx2-af: Add validation for lmac =
type
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Wed, Mar 29, 2023 at 10:36:15PM +0530, Sai Krishna wrote:
> > From: Hariprasad Kelam <hkelam@marvell.com>
> >
> > Upon physical link change, firmware reports to the kernel about the
> > change along with the details like speed, lmac_type_id, etc.
> > Kernel derives lmac_type based on lmac_type_id received from firmware.
> >
> > In a few scenarios, firmware returns an invalid lmac_type_id, which is
> > resulting in below kernel panic. This patch adds the missing
> > validation of the lmac_type_id field.
> >
> > Internal error: Oops: 96000005 [#1] PREEMPT SMP
> > [   35.321595] Modules linked in:
> > [   35.328982] CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted
> > 5.4.210-g2e3169d8e1bc-dirty #17
> > [   35.337014] Hardware name: Marvell CN103XX board (DT)
> > [   35.344297] Workqueue: events work_for_cpu_fn
> > [   35.352730] pstate: 40400089 (nZcv daIf +PAN -UAO)
> > [   35.360267] pc : strncpy+0x10/0x30
> > [   35.366595] lr : cgx_link_change_handler+0x90/0x180
> >
> > Fixes: 61071a871ea6 ("octeontx2-af: Forward CGX link notifications to
> > PFs")
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> > ---
> >  drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > index 724df6398bbe..180aa84cf1c3 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > @@ -1231,6 +1231,13 @@ static inline void link_status_user_format(u64
> lstat,
> >  	linfo->an =3D FIELD_GET(RESP_LINKSTAT_AN, lstat);
> >  	linfo->fec =3D FIELD_GET(RESP_LINKSTAT_FEC, lstat);
> >  	linfo->lmac_type_id =3D FIELD_GET(RESP_LINKSTAT_LMAC_TYPE, lstat);
> > +
> > +	if (linfo->lmac_type_id >=3D LMAC_MODE_MAX) {
> > +		dev_err(&cgx->pdev->dev, "Unknown lmac_type_id %d
> reported by firmware on cgx port%d:%d",
> > +			linfo->lmac_type_id, cgx->cgx_id, lmac_id);
> > +		return;
>=20
> You are keeping old lmac_type, which is out-of-sync now.
> Why don't you do something like that?
>=20
> if (linfo->lmac_type_id >=3D LMAC_MODE_MAX) {
>   strncpy(linfo->lmac_type, "Unknown", LMACTYPE_STR_LEN - 1);
>   return;
> }
>=20
>=20
We will add the proposed change (Unknown). Since we need to know the firmwa=
re reported lmac type ID is proper or not, we will keep dev_err also.
> > +	}
> > +
> >  	lmac_string =3D cgx_lmactype_string[linfo->lmac_type_id];
> >  	strncpy(linfo->lmac_type, lmac_string, LMACTYPE_STR_LEN - 1);  }
> > --
> > 2.25.1
> >
Thanks,
Sai