Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Drewek, Wojciech" <wojciech.drewek@intel.com>
To:     Andrea Righi <andrea.righi@canonical.com>
CC:     Guillaume Nault <gnault@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: selftests: net: l2tp.sh regression starting with 6.1-rc1
Thread-Topic: selftests: net: l2tp.sh regression starting with 6.1-rc1
Thread-Index: AQHZYjl1GRPOFSRp8EO/z00nY9tXgq8RxqfwgAAajwCAAAHa8IAAFiQAgADot4CAACws0IAACTkAgAAEZGA=
Date:   Thu, 30 Mar 2023 10:12:20 +0000
Message-ID: <PH0PR11MB57823A4A408304220DECA0E7FD8E9@PH0PR11MB5782.namprd11.prod.outlook.com>
References: <ZCQt7hmodtUaBlCP@righiandr-XPS-13-7390>
 <MW4PR11MB57763144FE1BE9756FD3176BFD899@MW4PR11MB5776.namprd11.prod.outlook.com>
 <ZCRYpDehyDxsrnfi@debian>
 <MW4PR11MB5776F1B04976CB59D9FE41BFFD899@MW4PR11MB5776.namprd11.prod.outlook.com>
 <ZCRsxERSZiGf5H5e@debian> <ZCUv+8tbH3H5tZKe@righiandr-XPS-13-7390>
 <PH0PR11MB57829AF31406D3EA4B1D9112FD8E9@PH0PR11MB5782.namprd11.prod.outlook.com>
 <ZCVcxkCkgBmwjnIX@righiandr-XPS-13-7390>
In-Reply-To: <ZCVcxkCkgBmwjnIX@righiandr-XPS-13-7390>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qWHj8ncQ2Y5aMMke9tXmN2jMI4Yf4v0x1v699TGxwUXcB4MbFBsVlk8DwHc3?=
 =?us-ascii?Q?QY3rcsKzJmhwvuCIFTy2d4LAxbX1i/+39nWnhigIARBlCpv7WRs7X1d0uQlE?=
 =?us-ascii?Q?LO9DF1LaSg5rx8uuHVW0WQjh7n4wySDdThYPdOZC8TVE4ajwYKlKOG///rvJ?=
 =?us-ascii?Q?1Hm6c2CQaLJLEp5SR71Kbe9XQA4XedP1gF7OFa/9liY0oC6hdpZvLIwfQQEz?=
 =?us-ascii?Q?yL2Lse1bzUtUdQH72k64fF0HJL7g46E41UnSrWbVJ22AXqWHfJ7v5giES7nE?=
 =?us-ascii?Q?b21cXfPD9XyAk5mtuEftllln2+SEMwo9BjUOjP8urhxdy8xsT7ML8+eh1KKC?=
 =?us-ascii?Q?sdALR3BkKwo2kOKBJVLsjjihQOzp0B0NH8fKi4yex31QgX/Wf5442XNbe/LI?=
 =?us-ascii?Q?VJvJbfzDLSOEWMtx5hyHSVqSTkKLGCmm2EJHQrV3JujEY1uiFxBY2t+XtlqI?=
 =?us-ascii?Q?shX8HbocyrfPOOF5ieNUVA/hV5ON9qVhZGBDvuZRnIJqN0dgad6JxrahXyO3?=
 =?us-ascii?Q?A6r0yoqGFhUHLdzaQgKY56wMrV5PC9jB0peAa8uoHKgc5Ru+SDuzpb8zldjd?=
 =?us-ascii?Q?TdYRY3BzNQ0f+Pmp02ovkkrGrJB1k+pBbIf9OAxm9i4mUu52Ns5vVo3X4bUJ?=
 =?us-ascii?Q?cNcCYdYZaSXXJ5By6lAZr9viN6EuA6KcByMoo73tX29B48wS9gQExmkSDy8n?=
 =?us-ascii?Q?EGeTwoo/Dx1GNdfJ53ZDfdtctE7gogroZ6zAQ5bGARuDmVWBQtk2rPy69JFN?=
 =?us-ascii?Q?d29gvxirtoRkO6dTDeGAniolDL3jxtwEmzxBJvw4EOhlC56vgcOHQeo2O8JH?=
 =?us-ascii?Q?KREpm/4yBO2WCVOvKhQaNDU8xpxkqoXK/XjPOOKJgP3HFXZ/Z38X+7EoDVKW?=
 =?us-ascii?Q?6G9QobURstadmLhAqLKB+baVPaToudgd9o00SvCmenNfRbx84HOc4yy3O6CK?=
 =?us-ascii?Q?YSo1NcXbUIazcg5mIfbIonUnoPPgkCKLShPeYgKlG8fMztsmRedKYfaiY6Zn?=
 =?us-ascii?Q?RfD6FYwm9DR4FB+jmrvvXwFzYEyOuf323uwuUHyq/JQtS9VZIA/xll8t/4+U?=
 =?us-ascii?Q?hrvb73p6QJJqObE3x6dJ4rJkVi0j0xvEU6vP/Pbv2BxQuDszzBv/z/ypDho6?=
 =?us-ascii?Q?5vzlnXsePXPAq7qY2LiiXvm0Hz+OSzOU21OnFMaTyGTeND4UuTN9UdYGr4bR?=
 =?us-ascii?Q?8rV0Cy9pYN/DZ3dcXx616ZyZko9cFdMOpemdtT3zZ4oKdPpTXi+gnKr8tZPS?=
 =?us-ascii?Q?4w9iO1AIWujYASUZwMiD+CE9km59P+rPzDaFaUsHziyu7C2wB4bGiDIIIDBf?=
 =?us-ascii?Q?47ceEO2jCkreApzvl3CwrmX99MeUJwnoKSMm2ZeMpL2N2gIzmuNNfK2y1949?=
 =?us-ascii?Q?YMhxKevgwDFufbJZXAzjn/wMk5MhbMBpDpBWApXc35Rfpv2It9sLtJMWybJk?=
 =?us-ascii?Q?FkpQJVSwztSJ0lF6x7wTKBrkO7h6hj/AUxAXmq4IZ7TN3XarJr/Mi22gfQ6y?=
 =?us-ascii?Q?xhw+A3wVYpy4griDvJ/5BpijYY5MMhfPJP4prQ8Txhe22ev+BUU0P7dLKqjZ?=
 =?us-ascii?Q?E2vjvmGsOYGMh6o70X/OnT/oiqcN2IFpKg1zz5dj?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8c9cf2f-9c11-43ba-4012-08db31073feb
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 10:12:20.9607
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E98V6lxRCinY5EGGRFUlm1DI+ChZV89PUmV3jGGwxv0KBar3hS9fYGDvmJm4IAM/7XY0Kz/AF8/YPlXHw6BYGlqg9tG0WFQcociIopQRRso=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4557
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrea Righi <andrea.righi@canonical.com>
> Sent: czwartek, 30 marca 2023 11:56
> To: Drewek, Wojciech <wojciech.drewek@intel.com>
> Cc: Guillaume Nault <gnault@redhat.com>; David S. Miller <davem@davemloft=
.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Shuah Khan <=
shuah@kernel.org>; netdev@vger.kernel.org; linux-
> kselftest@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: selftests: net: l2tp.sh regression starting with 6.1-rc1
>=20
> On Thu, Mar 30, 2023 at 09:26:06AM +0000, Drewek, Wojciech wrote:
> >
> >
> > > -----Original Message-----
> > > From: Andrea Righi <andrea.righi@canonical.com>
> > > Sent: czwartek, 30 marca 2023 08:45
> > > To: Guillaume Nault <gnault@redhat.com>
> > > Cc: Drewek, Wojciech <wojciech.drewek@intel.com>; David S. Miller <da=
vem@davemloft.net>; Eric Dumazet
> > > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni =
<pabeni@redhat.com>; Shuah Khan
> <shuah@kernel.org>;
> > > netdev@vger.kernel.org; linux-kselftest@vger.kernel.org; linux-kernel=
@vger.kernel.org
> > > Subject: Re: selftests: net: l2tp.sh regression starting with 6.1-rc1
> > >
> > > On Wed, Mar 29, 2023 at 06:52:20PM +0200, Guillaume Nault wrote:
> > > > On Wed, Mar 29, 2023 at 03:39:13PM +0000, Drewek, Wojciech wrote:
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > -MODULE_ALIAS_NET_PF_PROTO_TYPE(PF_INET6, 2, IPPROTO_L2TP);
> > > > > > -MODULE_ALIAS_NET_PF_PROTO(PF_INET6, IPPROTO_L2TP);
> > > > > > +MODULE_ALIAS_NET_PF_PROTO_TYPE(PF_INET6, 2, 115 /* IPPROTO_L2T=
P */);
> > > > > > +MODULE_ALIAS_NET_PF_PROTO(PF_INET6, 115 /* IPPROTO_L2TP */);
> > > > >
> > > > > Btw, am I blind or the alias with type was wrong the whole time?
> > > > > pf goes first, then proto and type at the end according to the de=
finition of MODULE_ALIAS_NET_PF_PROTO_TYPE
> > > > > and here type (2) is 2nd and proto (115) is 3rd
> > > >
> > > > You're not blind :). The MODULE_ALIAS_NET_PF_PROTO_TYPE(...) is ind=
eed
> > > > wrong. Auto-loading the l2tp_ip and l2tp_ip6 modules only worked
> > > > because of the extra MODULE_ALIAS_NET_PF_PROTO() declaration (as
> > > > inet_create() and inet6_create() fallback to "net-pf-%d-proto-%d" i=
f
> > > > "net-pf-%d-proto-%d-type-%d" fails).
> > >
> > > At this point I think using 115 directly is probably the best solutio=
n,
> > > that is also what we do already with SOCK_DGRAM, but I would just upd=
ate
> > > the comment up above, instead of adding the inline comments.
> >
> > Agree,
> >
> > I verified the fix on my machine,
> > Do you want me to send the patch or you'll just send below one?
>=20
> Sent already. :)
>=20
> -Andrea

Thank you!