Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sai Krishna Gajula <saikrishnag@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: Re: [net PATCH 3/7] octeontx2-af: Add validation for lmac type
Thread-Topic: [net PATCH 3/7] octeontx2-af: Add validation for lmac type
Thread-Index: AQHZYvA698tMiSoOKkG9zrn76D6ClQ==
Date:   Thu, 30 Mar 2023 10:13:10 +0000
Message-ID: <BY3PR18MB47076BEBC13E5C0A36083C43A08E9@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20230329170619.183064-1-saikrishnag@marvell.com>
 <20230329170619.183064-4-saikrishnag@marvell.com>
 <20230330061840.GM831478@unreal>
In-Reply-To: <20230330061840.GM831478@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3MA3L1UpOQdUb2tDRekZBKl+ADYGrcI5DXjZvylIeuSc8ogGFgvvmgezqAhz?=
 =?us-ascii?Q?Qtg/HN4zXPUxK8gMxe5sP5Nw/2ghuoIRVAmFXxgxJJ5bU4PdBtLQqcRDlVec?=
 =?us-ascii?Q?VqQfPABnknmm3h1ohLWd32jFWWtmN2MZHXs+0dZL5GyzRwZvSqAYSEpu3rgG?=
 =?us-ascii?Q?9hQ5tZg9yybmko1pSY9Q5AK0DOm0xI5H3jMBVCFTN9pdmj3bMaLMotUwZ8o/?=
 =?us-ascii?Q?A9VYUh6TUwQKsrWpYXOzb48GhekksVLYyQSADVtOVGNboBqpghrn92vrYVad?=
 =?us-ascii?Q?7EgOc8rjy2jEkyQ++ozYiL6esgiD9jFzdkkP0TPQ9QRwRZlawAzusR+KOMCq?=
 =?us-ascii?Q?nbEwqaPuSV1cDr8ojBIoSWxsGWv+6rrnpeJz5dr67jiu/2h6vu+re2LqJhwj?=
 =?us-ascii?Q?vOzXqVi2mTBp4LhUmCuMsXiSAUPdPcT6vijtzuAr1pcjqWhIn+Sl7M/uQ5+E?=
 =?us-ascii?Q?zXjEp0oTUyM2Vv/Uafuon+9TjkEpmmSor0u8vxTwknTq1aH3DmF0pbjCuB7V?=
 =?us-ascii?Q?e3QeHUxBeXTAfNFKV9dTpAv5oyn4P5KiKdRMuh8aHetrr3dz0gIcXweqIYgc?=
 =?us-ascii?Q?aess4L/yRRVFze7JEiKDycxhtgkrtPMc0cvK52mQbj6MPDKBstqprMbjP/yR?=
 =?us-ascii?Q?2TStk0np+xsbbUOc7FRrz6xH2ZXt0daDW0aiavhmcXckbXKjOPze5P2AVum6?=
 =?us-ascii?Q?UuoCpFjyoDyQIIyy1mTCifdDW/vCJFX6nkgePR7pwJFFZAW4+CtQlXMy9M+v?=
 =?us-ascii?Q?9tl0B066pCss2xy8ZcnWSAnzCZXwbYBjj8qK6EyPmo6+d48yr07rtuFqvum2?=
 =?us-ascii?Q?c5gPCSDqWXuYN/lk3Tqfz4dnmdC5CjkcqXTY0zLlUMYe66Gy5IqVCjbeYDfc?=
 =?us-ascii?Q?nBxO7KBET0rSaOJjiPUVRC7+4G60kgYJC2wf5tD7ASmojdZkSomMAquAckDF?=
 =?us-ascii?Q?vkdEBTE21TpcfhwtzXraie59ASLexNqLMMQC9xCygPsC9jAGtot7ECyJQpjY?=
 =?us-ascii?Q?iqaYQ3uMffYlU2fQzf1Ce54OMxSH7zUq6uCJy/Oy4Q4XQSNNEzkOnA7LpknQ?=
 =?us-ascii?Q?0X3thh1OaLWegpKRGrwRsKmft/hWj/8vzBi7IxSFdmjUfFoudCVFCAI/gmZ1?=
 =?us-ascii?Q?NqWnruYsojGtrGQdcLGdUkQVfpV8dAoHDPlmW2ixN76KOzZSrBY2zABAxWCU?=
 =?us-ascii?Q?eWMZij5CKgGXs/VE1Adw6h9MXgHdc9SDfrVYC8R1Avns6AK5kMVIscWNQRAS?=
 =?us-ascii?Q?X+9K87mwnmx2COt3Ta4q0Ndcaf5e2g5AJ1BCeKJqhGQnbv+IY2AAA7gEOu4o?=
 =?us-ascii?Q?74yJXjR5gxMsyJhWV5DaALFSlys79C2BjX3xQqGxb1x9f5p+x1AFOy89NzCV?=
 =?us-ascii?Q?ndZSrbTr94wIFz5e55faRItlvqsGPCk4qnc18/aebLulOgy63wGnP94k3nDM?=
 =?us-ascii?Q?hTE5znifPbNQi8qEMVktZOQVYcr1mRdJVqCRrTujlWP4gcmfbP8ExxBXASjP?=
 =?us-ascii?Q?1CO0P8Gyk6LpcDn1piJPldSLbisoN0LcYh6v1REyg3dweeZRJElQFABpdJ1l?=
 =?us-ascii?Q?3wXqq2v9HapCPwsnKi9L/C1U+AdB9gp96tr1CZNv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 531f764c-2ddd-4828-2a36-08db31075d77
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 10:13:10.5370
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0AZ2m5hTpQFeDG/SSaeCf03IQkBeKwQqO0YYhzDOj6EJAKHXXI87GDmUPxfMTE2J9h/H/7CWDSCobL6dl6lhkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3919
X-Proofpoint-GUID: vvxJghEN0bJPHJpi2OKhBZRMRC5PTKrO
X-Proofpoint-ORIG-GUID: vvxJghEN0bJPHJpi2OKhBZRMRC5PTKrO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-30_04,2023-03-30_01,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please see inline,

> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Thursday, March 30, 2023 11:49 AM
> To: Sai Krishna Gajula <saikrishnag@marvell.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> richardcochran@gmail.com; Hariprasad Kelam <hkelam@marvell.com>
> Subject: Re: [net PATCH 3/7] octeontx2-af: Add validation for lmac type
=20
> > From: Hariprasad Kelam <hkelam@marvell.com>
> >
> > Upon physical link change, firmware reports to the kernel about the
> > change along with the details like speed, lmac_type_id, etc.
> > Kernel derives lmac_type based on lmac_type_id received from firmware.
> >
> > In a few scenarios, firmware returns an invalid lmac_type_id, which is
> > resulting in below kernel panic. This patch adds the missing
> > validation of the lmac_type_id field.
> >
> > Internal error: Oops: 96000005 [#1] PREEMPT SMP
> > [   35.321595] Modules linked in:
> > [   35.328982] CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted
> > 5.4.210-g2e3169d8e1bc-dirty #17
> > [   35.337014] Hardware name: Marvell CN103XX board (DT)
> > [   35.344297] Workqueue: events work_for_cpu_fn
> > [   35.352730] pstate: 40400089 (nZcv daIf +PAN -UAO)
> > [   35.360267] pc : strncpy+0x10/0x30
> > [   35.366595] lr : cgx_link_change_handler+0x90/0x180
> >
> > Fixes: 61071a871ea6 ("octeontx2-af: Forward CGX link notifications to
> > PFs")
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> > ---
> >  drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > index 724df6398bbe..180aa84cf1c3 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> > @@ -1231,6 +1231,13 @@ static inline void link_status_user_format(u64
> lstat,
> >  	linfo->an =3D FIELD_GET(RESP_LINKSTAT_AN, lstat);
> >  	linfo->fec =3D FIELD_GET(RESP_LINKSTAT_FEC, lstat);
> >  	linfo->lmac_type_id =3D FIELD_GET(RESP_LINKSTAT_LMAC_TYPE, lstat);
> > +
> > +	if (linfo->lmac_type_id >=3D LMAC_MODE_MAX) {
> > +		dev_err(&cgx->pdev->dev, "Unknown lmac_type_id %d
> reported by firmware on cgx port%d:%d",
> > +			linfo->lmac_type_id, cgx->cgx_id, lmac_id);
> > +		return;
>=20
> You are keeping old lmac_type, which is out-of-sync now.
> Why don't you do something like that?
>=20
> if (linfo->lmac_type_id >=3D LMAC_MODE_MAX) {
>   strncpy(linfo->lmac_type, "Unknown", LMACTYPE_STR_LEN - 1);
>   return;
> }
>=20
>=20
We will add the proposed change (Unknown). Since we need to know the firmwa=
re reported lmac type ID is proper or not, we will keep dev_err also.

Thanks,
Sai

> > +	}
> > +
> >  	lmac_string =3D cgx_lmactype_string[linfo->lmac_type_id];
> >  	strncpy(linfo->lmac_type, lmac_string, LMACTYPE_STR_LEN - 1);  }
> > --
> > 2.25.1
> >