Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 20.79.220.33 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.79.220.33; helo=de1-emailsignatures-cloud.codetwo.com; pr=C
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 104.47.22.43 as permitted sender) receiver=protection.outlook.com;
 client-ip=104.47.22.43; helo=CHE01-GV0-obe.outbound.protection.outlook.com;
 pr=C
From:   =?iso-8859-1?Q?Rodr=EDguez_Barbarin=2C_Jos=E9_Javier?= 
        <JoseJavier.Rodriguez@duagon.com>
To:     "morbidrsa@gmail.com" <morbidrsa@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "jth@kernel.org" <jth@kernel.org>,
        =?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?= 
        <Jorge.SanjuanGarcia@duagon.com>,
        =?iso-8859-1?Q?Rodr=EDguez_Barbarin=2C_Jos=E9_Javier?= 
        <JoseJavier.Rodriguez@duagon.com>
Subject: [PATCH v3 3/3] mcb-lpc: Reallocate memory region to avoid memory
 overlapping
Thread-Topic: [PATCH v3 3/3] mcb-lpc: Reallocate memory region to avoid memory
 overlapping
Thread-Index: AQHZYvVkYfgmX7xWCEK/WSKxu2oxrw==
Date:   Thu, 30 Mar 2023 10:50:07 +0000
Message-ID: <20230330104949.21918-4-josejavier.rodriguez@duagon.com>
References: <20230330104949.21918-1-josejavier.rodriguez@duagon.com>
In-Reply-To: <20230330104949.21918-1-josejavier.rodriguez@duagon.com>
Accept-Language: es-ES, en-US
Content-Language: en-US
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=duagon.com;
X-Microsoft-Antispam-Message-Info-Original: GJbFKF+jMI5CiMvbNP0/N0dNycBSJZxDqyw6v4jmaBuGeP3OP+jZMBnad+VmZ+TOrYjuxlbLl6x+pClo+fl71M0tTIcDgQdHu60vv1PJoGSaGslhJ5ER8mneJMs1N6ouftBXMnE87OVtfRzGyas9LU80FdASNKOJf2YYz9Z29i12bWa/0r9auJk+9nxliBc/TGctfZX5q7VVNa224avXdi80Dk14tOzMYwLq+I/7J/ryArFKN2jhzrC1hojGGNZeloJ3tQ1yuseCHUkMC9gfzV565n8b546HlSTPjcf7n4hucUGjt5FiL2DT1Wmu8EZpVVCQvAaRatB7cQhwuF52YTqf4T6w0W1qmiBKdymPuj0EYxJdpcCTo7cdDtrtZ5W5IL/g0NvEdSnxtrZsP0Rv6XcPhLLNR/BM0QZJtR16XEe13ej+YC4CQOV6e+Nal0zoaSd2Yhocc6PoxgNbngv+mc9Yuq/gz0IB//kXAE5W1t7eExegTWk0bgFgoypquHpkpqKOjxQnljetpugXzXoS5i1+P+D3BsaaIDA9FfGk8UNXJeaoooZuaCG1v0ggd8vqbAjoYmk4TjPP6uouwzhpWYgTguj1Up28YEaXAZ083u1rC8iJOgCbfx8p7GnhAgrv
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV0P278MB0996.CHEP278.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(376002)(39850400004)(346002)(451199021)(83380400001)(2906002)(5660300002)(8936002)(36756003)(38070700005)(38100700002)(86362001)(122000001)(6512007)(6506007)(316002)(64756008)(66446008)(54906003)(4326008)(66556008)(6486002)(8676002)(66946007)(76116006)(66476007)(26005)(91956017)(186003)(1076003)(71200400001)(107886003)(478600001)(41300700001)(2616005)(110136005);DIR:OUT;SFP:1102;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0741
X-SM-outgoing: yes
X-EOPAttributedMessage: 1
X-MS-Exchange-SkipListedInternetSender: ip=[104.47.22.43];domain=CHE01-GV0-obe.outbound.protection.outlook.com
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR01FT088.eop-EUR01.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: f6674e5a-f018-42d8-cc16-08db310c8726
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: 0W6oin+Qa6r1+pi6WUvZGY2wMxjeyMmxEaBDTiI4Gf1C5na0jiIYe+4FPp/3UZLI+qkqpE97Rbfqw8Sr5Zd96NcbUp2tuchbnWiNHRatHRIX5elgkaIfkSaOtqOgYRa/gVNDIRvVU9SvQk/zWDSUEcibPL8M82iGVTxcrBpcwNV4pph7BqRSPcDX79VtPVfjzvzAsbOiPn1FRDoIGq1FQ/k+cu8z+q+cdPJ6/ClSwE4O72ql9CVCVSj63II+Nyec1+f5WYoED3HW5Os13S3yzim/RVsIrC/6OcbOpg8ONtoJL8dd8BvEaYpwMRoHUr3JspwBzMJIf8W8bxOK4L6FbeCqzLTfEdisNmx+5u36h43QgHO+Q1MJzExfgCLBvn0brJbRb8aW4kE774xsDvusXtycZWrJJ29rKvZpf2UfCjqZUCQBhtl1jju4aN3YgZR3yizBP6hjaKImIvG0HmTgz4DrSyf/mdXEUPwOqjwX7g2k56mA4W6cl8vTSlarNKAe8QE7QIiVZwRr40PDTAODTjPRJWNPEk2O2asStFp8ZnJayyJp4Dro9ecurum+XeLtJVRP/O1W81UPceKsSxMtDm1DeosqJ+Tazj9fPE0BvBqGn/N5uBI8/Lytu11n9emSMfoFwXrcMvEjBWXWAEs/RpfMET0Uh/zagG4bXYKHjNtplVzK3/sTzQzCG3tG4N9Ccn1Oy5nNUeKBRWmXq3JXExt/FQtKFSw/xAxcoy8gB1qYK1Lg6pN+NulnNuVjlsqL069WC+k6bUjv6d/LFJWuwpJIPSPSDPEqKy+V6UzV5oisGYZ1uXVJG0QFsEAGh763
X-Forefront-Antispam-Report-Untrusted: CIP:91.135.65.126;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CHE01-GV0-obe.outbound.protection.outlook.com;PTR:mail-gv0che01lp2043.outbound.protection.outlook.com;CAT:NONE;SFS:(13230028)(136003)(346002)(39850400004)(376002)(396003)(451199021)(36840700001)(46966006)(478600001)(2616005)(6486002)(36756003)(83380400001)(47076005)(336012)(86362001)(40480700001)(156005)(36860700001)(32850700003)(7636003)(82740400003)(26005)(186003)(1076003)(6506007)(107886003)(41300700001)(2906002)(82310400005)(5660300002)(110136005)(54906003)(8936002)(316002)(4326008)(8676002)(70586007)(70206006)(6512007);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0122
X-CodeTwo-MessageID: 93522a64-d589-409a-b242-833b004d8109.20230330105011@de1-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR01FT047.eop-EUR01.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 9e2cf3bc-60c1-4a67-1a1b-08db310c88ac
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: FwneSbt6gj/lL/e5j1N6z4UtCnIGQBXvLW+PRHQGbAWkXF3MGeEVM8jKhSeBJTn1/KsyVsTRidCnUZiUsr9lyywqrZpFji3TeEYLURYAuCO+TQ+jlCDgJIKeyB1y3Xh9t66W16TuyBTeaZbxumPqSIyOW14OrVbOfl/r+8w4+z5B4ZUeaYX7aVFkPjej9UXZ7avsLfdUKvIQp2apXr6DTs0ENMQ15XQvUSeH0kEO0f1FgKGXw1eJBgYFB68vjJ03BYaWITyDWlanue67bu52SqOMve6GLrqNQQij+D9k+hC3lNmGI60H15gB9FDitVJ81NoT8tVgLlpw4M3PW/3KEGLabdTWjNmEXK/uTax+2rV9Dt5NegDuEcxqao9YJXe1Hz27g3/T0rBpnYZ4Bjf/MSMt1Q3IS9i+RehBpce2vwNxXg8MVnZSGl+CR/4NFYAo8aiZq98i5SiFQfaJXEz7DaJBl2gZ4nknrXk6y4umZNcAKTECYNr1T2y2DBuksrJCMgymkZ+94uS959Ran8gF8WPnH4AOuLvKtUik0/Cy1WnWje+4an3r6nTwcK0fl8xCNSZdWF6EGUMYDii2FUXc29ZJwvrD3PeKEu3WR5bpl2tyG3mBnL/zq9kpmu0MV2AqCsWDVlERZVAs4lmICD0bxSnReo3BTLJ7+YWNRCp8UFw=
X-Forefront-Antispam-Report: CIP:20.79.220.33;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:de1-emailsignatures-cloud.codetwo.com;PTR:de1-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230028)(39850400004)(136003)(346002)(376002)(396003)(451199021)(36840700001)(46966006)(2616005)(478600001)(47076005)(336012)(40480700001)(6486002)(83380400001)(186003)(36860700001)(110136005)(107886003)(316002)(54906003)(1076003)(6512007)(6506007)(26005)(41300700001)(82740400003)(7636003)(8936002)(4326008)(70206006)(5660300002)(8676002)(7596003)(70586007)(2906002)(86362001)(82310400005)(36756003);DIR:OUT;SFP:1102;
X-OriginatorOrg: duagon.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 10:50:13.1038
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 44677f31-4f0f-403b-c36f-08db310c8a3c
X-MS-Exchange-CrossTenant-Id: e5e7e96e-8a28-45d6-9093-a40dd5b51a57
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5e7e96e-8a28-45d6-9093-a40dd5b51a57;Ip=[20.79.220.33];Helo=[de1-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT047.eop-EUR01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB1122
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

mcb-lpc requests a fixed-size memory region to parse the chameleon
table, however, if the chameleon table is smaller that the allocated
region, it could overlap with the IP Cores' memory regions.

After parsing the chameleon table, drop/reallocate the memory region
with the actual chameleon table size.

Co-developed-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
Signed-off-by: Javier Rodriguez <josejavier.rodriguez@duagon.com>
---
 drivers/mcb/mcb-lpc.c | 35 +++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)

diff --git a/drivers/mcb/mcb-lpc.c b/drivers/mcb/mcb-lpc.c
index 53decd89876e..a851e0236464 100644
--- a/drivers/mcb/mcb-lpc.c
+++ b/drivers/mcb/mcb-lpc.c
@@ -23,7 +23,7 @@ static int mcb_lpc_probe(struct platform_device *pdev)
 {
 	struct resource *res;
 	struct priv *priv;
-	int ret =3D 0;
+	int ret =3D 0, table_size;
=20
 	priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -58,16 +58,43 @@ static int mcb_lpc_probe(struct platform_device *pdev)
=20
 	ret =3D chameleon_parse_cells(priv->bus, priv->mem->start, priv->base);
 	if (ret < 0) {
-		mcb_release_bus(priv->bus);
-		return ret;
+		goto out_mcb_bus;
 	}
=20
-	dev_dbg(&pdev->dev, "Found %d cells\n", ret);
+	table_size =3D ret;
+
+	if (table_size < CHAM_HEADER_SIZE) {
+		/* Release the previous resources */
+		devm_iounmap(&pdev->dev, priv->base);
+		devm_release_mem_region(&pdev->dev, priv->mem->start, resource_size(priv=
->mem));
+
+		/* Then, allocate it again with the actual chameleon table size */
+		res =3D devm_request_mem_region(&pdev->dev, priv->mem->start,
+					      table_size,
+					      KBUILD_MODNAME);
+		if (!res) {
+			dev_err(&pdev->dev, "Failed to request PCI memory\n");
+			ret =3D -EBUSY;
+			goto out_mcb_bus;
+		}
+
+		priv->base =3D devm_ioremap(&pdev->dev, priv->mem->start, table_size);
+		if (!priv->base) {
+			dev_err(&pdev->dev, "Cannot ioremap\n");
+			ret =3D -ENOMEM;
+			goto out_mcb_bus;
+		}
+
+		platform_set_drvdata(pdev, priv);
+	}
=20
 	mcb_bus_add_devices(priv->bus);
=20
 	return 0;
=20
+out_mcb_bus:
+	mcb_release_bus(priv->bus);
+	return ret;
 }
=20
 static int mcb_lpc_remove(struct platform_device *pdev)
--=20
2.34.1