Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 11:49:46 +0100
From:   Gary Guo <gary@garyguo.net>
To:     y86-dev@protonmail.com
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <alice@ryhl.io>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v3 03/13] rust: types: add `Opaque::raw_get`
Message-ID: <20230330114946.696c8e72.gary@garyguo.net>
In-Reply-To: <20230329223239.138757-4-y86-dev@protonmail.com>
References: <20230329223239.138757-1-y86-dev@protonmail.com>
        <20230329223239.138757-4-y86-dev@protonmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g/j+Eh9ieQ6wKCn3+QlL56JMVQKwix63XdScrbBw845Ti+WzlG5vUTUwXO9N?=
 =?us-ascii?Q?8zSOYXvHRXrSantbIlIv4E5ha/My+/xkQ6HE+jk6fvAZtLqY6gzJfJEMQwQO?=
 =?us-ascii?Q?b5KxsbvfeKC8HIoDyqVGAdqVlsumYvvE46MYFwpC7ug8oVJrj5gqDEnLHWJH?=
 =?us-ascii?Q?lISMMJgiBwCEFHpMDPOy1lK0iAp8XWBs1FqiGQ+17FYPPhrTHSw3foRRMmCL?=
 =?us-ascii?Q?Mhv5gU1CQhNpM/PvRyTPHvZcPp7INQ693o0NcHUwfzTu0cwcMZ4Cx1rghT2g?=
 =?us-ascii?Q?QzWaz+0VS5M90lwu3CPRTRWAyYFQfKYIlLx1YugZqJawisRKgelx8dt49bwQ?=
 =?us-ascii?Q?aMMDyGncCZDqPiBhSw2IHp6Gq2t4wtvy2787jODhw7Ae7D76VvegvKku5zTx?=
 =?us-ascii?Q?TmHx73TwWMK1NoqCAR2iqIPZqCZPYLX+7UnWQbjol7sT1Vb765fg/Hyjb4PX?=
 =?us-ascii?Q?mbM/Dse23OWbrmJO8jNvdGpXIdMcFnEKNG/DnkXHctWFm9GVIEdoZtYjAjVP?=
 =?us-ascii?Q?JeI2vIE8RrqHkKMP1a2ZNJvVoaWOxIzfa9vwUrKUnVPRk3eG3+BoPBAO4vUU?=
 =?us-ascii?Q?PKCq8N/rJXjWX2+/L0joG1xv8MqcgIcuBGIpHAvP+l2KVv05SslGonJHvN9e?=
 =?us-ascii?Q?VtxlOigk5LtZNaaPmmYBX/L2bCDbmKYfODll3vWJX1TfCeh2we326WfrLB/R?=
 =?us-ascii?Q?Ad/CY/uYuNqzlp17aPL8WEXUEYfaWMttn18MKbtr3CmH19jdCItlMsRotEWH?=
 =?us-ascii?Q?LpwM5/sB9cZI4ZNV2DXXfvVMX1v2jXbhC/s90OTObzsjzCFY0EhU5Lg+By2h?=
 =?us-ascii?Q?AQAIUap6Jqy6B5HksMQPG3VVGVOws4uP/wvV0BW9rZR7nyEKfwabyFWX+FDl?=
 =?us-ascii?Q?XQGEF6Ccu1VpnTS3MRUaefD1mFyzZhWY1EU9cSpUltC3UeVP6JCTT61UkJbz?=
 =?us-ascii?Q?2qjRU2LPbFVlaZaAOAmwOypuHWiggZq0TbDwAYD8kCBiDQAbzsDVpCdc9Qah?=
 =?us-ascii?Q?f7bvL7EbNnczdpaAS6SLaWBE3bLRVRNySzc/toDrHFLh33eFuVg0KtMgcVEJ?=
 =?us-ascii?Q?geL45hMtYqj/B7xPlFyPinDbjlPESDGd0WQ49OSGfdYNRotdl3zCmtfDLWSr?=
 =?us-ascii?Q?s9Shu2u2YNuiH/LUJmpTpEmCrgYg+uUNv2IHdNpBks4+9t2idwHp+79/qICc?=
 =?us-ascii?Q?fF3883n4Ad+ejg/NieBErJHLximcctEFXQSRz/gJiv2KT00TbPxdi8+UCseP?=
 =?us-ascii?Q?Ne2IZAf5b3GqBdP5BRmxuLH/2OFXCNSplo+hLuGfFeiO9O9QDBLh8dipUSsU?=
 =?us-ascii?Q?1jSGGzCqctU9qNA88iq3wTq2NhYnBoRzD4UA2esauOmoa2RpAVyU8YcJtic5?=
 =?us-ascii?Q?MdNP99DYzDMee6DcXVnrzK2SPnwC6pEjvTU1JuHkdwaoAfqgf74FzmbG+fLf?=
 =?us-ascii?Q?Q7Tqh+Tt3VDfCOOtzpeELolUJK4TMfKKPEahpm0hKsiankZCjQfJe+ahq/lN?=
 =?us-ascii?Q?9XB2qZntY7XpyjuAatb6i0/73RXF+ykL5jVezq+atE/u2jljSMP5yIDULays?=
 =?us-ascii?Q?lhNR7WGnQZwh+x/MZZwOlBOdKijGNAYrewLmzYVx?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 40d36b12-299b-42fd-b3a7-08db310c8acd
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 10:50:14.3347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /0jmTXnTNOMZV81IHKBOXAc3wMPpWzyhdPo5ThiR6S442cZV/ZA4W440o27zWf0frTpoYpp+bpq0gxwkuNZWEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6601
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 29 Mar 2023 22:33:03 +0000
y86-dev@protonmail.com wrote:

> From: Benno Lossin <y86-dev@protonmail.com>
> 
> This function mirrors `UnsafeCell::raw_get`. It avoids creating a
> reference and allows solely using raw pointers.
> The `pin-init` API will be using this, since uninitialized memory
> requires raw pointers.
> 
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/types.rs | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs
> index 9d0fdbc55843..ff2b2fac951d 100644
> --- a/rust/kernel/types.rs
> +++ b/rust/kernel/types.rs
> @@ -238,6 +238,14 @@ impl<T> Opaque<T> {
>      pub fn get(&self) -> *mut T {
>          UnsafeCell::raw_get(self.0.as_ptr())
>      }
> +
> +    /// Gets the value behind `this`.
> +    ///
> +    /// This function is useful to get access to the value without creating intermediate
> +    /// references.
> +    pub const fn raw_get(this: *const Self) -> *mut T {
> +        UnsafeCell::raw_get(this.cast::<UnsafeCell<T>>())
> +    }
>  }
> 
>  /// A sum type that always holds either a value of type `L` or `R`.
> --
> 2.39.2
> 
>