Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: wSEEvWKjltsQoA4+qesVaucTOQBL8PH1E9tHcTY4QNuPSO7gRUZI+BcDm5JGcBawkUhK+9kAOl
 FMPJW2hjlN7VhVo0rPzuA7SZvVHnGKm165xlCYkH9zfbu4Ri3rWgNDRvfZn6Lbq1QwQW1rWek8
 GMTzmNF+UiLtkT88fdtLb+K35dwCGDzR0wamdNo1+1F5k5Jw/NbBpsdfVoZgWC/rj8MFRjKxjx
 N14v8sDRTgb19en3nGE//GFKhvf/amOgeYd3XxzezTEJ8ntgAK313Amixbr5TARWxZwjHrwY0W
 fyU=
IronPort-SDR: a+EdcWho6Mkh1CPUP+0refOTY70iBvf/Z7MNMtWYQTDDQAhECAv8ydb7yqyiY2mgklXY+L8Xdf
 RYoo9j2E7O8yngCFQIVBXtNHQwCIS3mYr8qejWCJj2z3Phu/J/oN1LQu6gewo6oLKDNUjrNYLN
 eyDKqA4cPcDKMrqu/oE7rL31sgOaWhU+s3D2TcwnMfipIDKCJbjl21LqOshM6tdBpFtJ9G6CVx
 MwRfH04FFPZ31PNnksY6IHk9F8m9/boQRDy6UxDG6va8n0WcdbEdIoONHyX4J7P4IKRibojA5r
 rQg=
WDCIronportException: Internal
Message-ID: <97a2129c-b1d8-de74-014a-07e89ae95b30@opensource.wdc.com>
Date:   Thu, 30 Mar 2023 20:00:54 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] scsi: target: return -ENOMEM when kzalloc failed
Content-Language: en-US
To:     Chaitanya Kulkarni <chaitanyak@nvidia.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
References: <20230330023834.97455-1-jiapeng.chong@linux.alibaba.com>
 <73695d8e-a779-3c9c-5a46-b5a23381dff2@nvidia.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <73695d8e-a779-3c9c-5a46-b5a23381dff2@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/30/23 16:59, Chaitanya Kulkarni wrote:
> On 3/29/23 19:38, Jiapeng Chong wrote:
>> The driver is using -1 instead of the -ENOMEM defined macro to specify
>> that a buffer allocation failed.
>>
>> drivers/target/iscsi/iscsi_target.c:691 iscsi_target_init_module() warn: returning -1 instead of -ENOMEM is sloppy.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4644
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> ---
>>   drivers/target/iscsi/iscsi_target.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
>> index 834cce50f9b0..d3a40c3caaf5 100644
>> --- a/drivers/target/iscsi/iscsi_target.c
>> +++ b/drivers/target/iscsi/iscsi_target.c
>> @@ -688,7 +688,7 @@ static int __init iscsi_target_init_module(void)
>>   	pr_debug("iSCSI-Target "ISCSIT_VERSION"\n");
>>   	iscsit_global = kzalloc(sizeof(*iscsit_global), GFP_KERNEL);
>>   	if (!iscsit_global)
>> -		return -1;
>> +		return -ENOMEM;
>>   
>>   	spin_lock_init(&iscsit_global->ts_bitmap_lock);
>>   	mutex_init(&auth_id_lock);
> 
> you can also just use goto out, it has return -ENOMEM, no biggy..
> Also, it will be useful to print the error message here as we
> are making this change..

Printing an error message for allocation failures is frowned upon. Checkpatch
will complain.

-- 
Damien Le Moal
Western Digital Research