Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] ubifs: Free memory for tmpfile name
To:     =?UTF-8?Q?M=c3=a5rten_Lindahl?= <marten.lindahl@axis.com>,
        Richard Weinberger <richard@nod.at>
CC:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <kernel@axis.com>
References: <20230329-memleak-fix-v2-1-cb8d9394300b@axis.com>
From:   Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <72ffd9c6-e203-be55-6663-768262fb611e@huawei.com>
Date:   Thu, 30 Mar 2023 19:05:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20230329-memleak-fix-v2-1-cb8d9394300b@axis.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

> When opening a ubifs tmpfile on an encrypted directory, function
> fscrypt_setup_filename allocates memory for the name that is to be
> stored in the directory entry, but after the name has been copied to the
> directory entry inode, the memory is not freed.
> 
> When running kmemleak on it we see that it is registered as a leak. The
> report below is triggered by a simple program 'tmpfile' just opening a
> tmpfile:
> 
>    unreferenced object 0xffff88810178f380 (size 32):
>      comm "tmpfile", pid 509, jiffies 4294934744 (age 1524.742s)
>      backtrace:
>        __kmem_cache_alloc_node
>        __kmalloc
>        fscrypt_setup_filename
>        ubifs_tmpfile
>        vfs_tmpfile
>        path_openat
> 
> Free this memory after it has been copied to the inode.
> 
> Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com>
> ---
> Changes in v2:
> - Call fscrypt_free_filename after ubifs_release_budget
> - Link to v1: https://lore.kernel.org/r/20230329-memleak-fix-v1-1-7133da56ea8f@axis.com
> ---
>   fs/ubifs/dir.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>

> 
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index 0f29cf201136..7dd6dd34b84c 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -492,6 +492,7 @@ static int ubifs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir,
>   	unlock_2_inodes(dir, inode);
>   
>   	ubifs_release_budget(c, &req);
> +	fscrypt_free_filename(&nm);
>   
>   	return finish_open_simple(file, 0);
>   
> 
> ---
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
> change-id: 20230329-memleak-fix-87a01daf469e
> 
> Best regards,
>