Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 12:09:11 +0100
From:   Gary Guo <gary@garyguo.net>
To:     y86-dev@protonmail.com
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <alice@ryhl.io>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v3 13/13] rust: sync: add functions for initializing
 `UniqueArc<MaybeUninit<T>>`
Message-ID: <20230330120911.12c50468.gary@garyguo.net>
In-Reply-To: <20230329223239.138757-14-y86-dev@protonmail.com>
References: <20230329223239.138757-14-y86-dev@protonmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m7eKTlX94HJBhSi93euyJNuz+2gcH/EEUzDVy/lXz0HntblSmQ/xf7SoTO0o?=
 =?us-ascii?Q?WaUxnNZnmNZshdVGlUxKTawYCLrD8U0ZRCmtzpV5ZcywDaTmrCYvh1ClwY+M?=
 =?us-ascii?Q?1CY/rGpYOKxrwednYYiiVlyC/Ixxi8t4Rlh4tLF+o4/10vNH/Yy7nngGoOUo?=
 =?us-ascii?Q?K2lB790ZDrruBgOAw0swnraaO5cJP+OVc4IFezC3BztKGymjCXhGzm9DxWaT?=
 =?us-ascii?Q?fwyQ+bnqf81uYgJAxv1hY8XbaZtrgxhfmT+LH93Fb7qNvq5vYcXTCtxAVThM?=
 =?us-ascii?Q?F6hcFAG3so2Ma1qM6FgJABHWjPxWUcJ7J6NHvxwqKBTIbtVsZmLE8dHIU/Ls?=
 =?us-ascii?Q?ANR5CoJBW5kFQ//kC2BcA9gJ8zUmRgvzJxaffXOA+VvRC+IynJVlGEY2lGcd?=
 =?us-ascii?Q?uxHdfNPNCbmVvLzk1odJT6CpkNW7q9twoE7XPtbb9qGYeYenO3+P6mhPcHtT?=
 =?us-ascii?Q?jMliQaXHjv953eRaeHb0Yc5gFLmmsKZp/XelTZdCA5aGqhpA3QVA19tTVUr2?=
 =?us-ascii?Q?XD8e7zXUlr9xYwZ598KtLod5Bn6OQqKKQQlzDScN7ezDqnevs/6ntdNCF6nR?=
 =?us-ascii?Q?+JD3gVunwgjsJ8rJwi5ej26JtB4vq9fmAW6mipydGWaKj2rmY8+6zTlZBucw?=
 =?us-ascii?Q?gJbNW9KMpkrc45M0+XmP11mlGe8hubAXldf0YblOj2ZULMCEa9VNUty/5zT0?=
 =?us-ascii?Q?Xyma77bgJnC3WzP1LMcjpF7cUDuCJDBJaIxtp0A96b4siDR4m3q9zB+lAv4j?=
 =?us-ascii?Q?WSBwx6K/EH7rVINvWfpMDUoo+7wYt08RRDs6Bk/iiIqUEwps2Yc163aAZHMf?=
 =?us-ascii?Q?iDswr5lptG26YCsVuyPPp5xYRWYzna4Vjcbgq1X/wT75J/GGvO4DwHLYoolm?=
 =?us-ascii?Q?C6ve9qe9H/Ef6/nnzP9JmcY15e3lXDf17cPWPECcK+wfbBtFFbBsGZD/wxgo?=
 =?us-ascii?Q?P0GHZPReJrYDjY1vf3YmMmtMRMY/VFaa6LyqYm3CER6xO4Uy98tKRZtZrzxV?=
 =?us-ascii?Q?10qbXnj2L1B0FCIyUu9TVePVlMPqIMfK2BcFLTLMKP3WuNUD5LtQrrwKf7eb?=
 =?us-ascii?Q?gz96NI7mqd8I7tAuqHf6T1tWquNnASV0yWc3KClexFUsTvX3efkkiTT5R7rG?=
 =?us-ascii?Q?IBxqmq0Kw3QqTIcCOha6VQcdIhea6D2ouG0hVDjp+ThRe+cB4VP0hK9gK4YR?=
 =?us-ascii?Q?dsreMEfi2YRM3jMrmCS++Pi5LxufmvazHqP06pdDuhYG2GZmthkgqMOh2+IJ?=
 =?us-ascii?Q?+vGUFrS/JBpeUv/qQg6sWkRw50GBNCzQqq5nbcnoA6pGv2KyFJRW8p8Y8A58?=
 =?us-ascii?Q?TGygpvI81XqjmS7j1Sdg/nrbnz1w1pwjItXtuTJc6YQMBWWb0tRZaVmUHLBF?=
 =?us-ascii?Q?+TXHQkk7eSgBvduTDRUwME4VajCc1h4cZrTmmN/hyaiTtgxEn4EHOJysAKMw?=
 =?us-ascii?Q?8QhBazBaheAJOJkaG3ya2o0IvKkn5TxvDx10z/iSgjXOeHc3pLuxC5ebxu1n?=
 =?us-ascii?Q?MmU+w1bF5+6M3bWOPKZoQSQMiUvHxgxw+OXu4KYEhxEX0C3jBlC5onyU+uuA?=
 =?us-ascii?Q?S2t8q1w0et8CR1IYg1HSNsny6sXE4eHioyeGn1P/?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b28171e-8be7-4c0b-593e-08db310f3138
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 11:09:12.4453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZTApT2c7hFA3aaMxLmLh5+xBKD7hQuP9GGrrAZm/w9tfqSeNCuFeNWt5e1/wV1L63c30Q2cMbG6CsCSBVTEztA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO6P265MB6332
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 29 Mar 2023 22:33:53 +0000
y86-dev@protonmail.com wrote:

> From: Benno Lossin <y86-dev@protonmail.com>
> 
> Add two functions `init_with` and `pin_init_with` to
> `UniqueArc<MaybeUninit<T>>` to initialize the memory of already allocated
> `UniqueArc`s. This is useful when you want to allocate memory check some
> condition inside of a context where allocation is forbidden and then
> conditionally initialize an object.
> 
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/sync/arc.rs | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 4ed6329a5e5f..64b0e9d67025 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -540,6 +540,30 @@ impl<T> UniqueArc<MaybeUninit<T>> {
>              inner: unsafe { Arc::from_inner(inner.cast()) },
>          }
>      }
> +
> +    /// Initialize `self` using the given initializer.
> +    pub fn init_with<E>(mut self, init: impl Init<T, E>) -> core::result::Result<UniqueArc<T>, E> {
> +        // SAFETY: The supplied pointer is valid for initialization.
> +        match unsafe { init.__init(self.as_mut_ptr()) } {
> +            // SAFETY: Initialization completed successfully.
> +            Ok(()) => Ok(unsafe { self.assume_init() }),
> +            Err(err) => Err(err),
> +        }
> +    }
> +
> +    /// Pin-initialize `self` using the given pin-initializer.
> +    pub fn pin_init_with<E>(
> +        mut self,
> +        init: impl PinInit<T, E>,
> +    ) -> core::result::Result<Pin<UniqueArc<T>>, E> {
> +        // SAFETY: The supplied pointer is valid for initialization and we will later pin the value
> +        // to ensure it does not move.
> +        match unsafe { init.__pinned_init(self.as_mut_ptr()) } {
> +            // SAFETY: Initialization completed successfully.
> +            Ok(()) => Ok(unsafe { self.assume_init() }.into()),
> +            Err(err) => Err(err),
> +        }
> +    }
>  }
> 
>  impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {
> --
> 2.39.2
> 
>