Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e727403-a566-8c48-9367-5daa7c87def7@linux.intel.com>
Date:   Thu, 30 Mar 2023 14:11:44 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH] xhci: use pm_ptr() instead of #ifdef for CONFIG_PM
 conditionals
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Josue David Hernandez Gutierrez 
        <josue.d.hernandez.gutierrez@intel.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Alan Stern <stern@rowland.harvard.edu>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230328131114.1296430-1-arnd@kernel.org>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
In-Reply-To: <20230328131114.1296430-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28.3.2023 16.10, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A recent patch caused an unused-function warning in builds with
> CONFIG_PM disabled, after the function became marked 'static':
> 
> drivers/usb/host/xhci-pci.c:91:13: error: 'xhci_msix_sync_irqs' defined but not used [-Werror=unused-function]
>     91 | static void xhci_msix_sync_irqs(struct xhci_hcd *xhci)
>        |             ^~~~~~~~~~~~~~~~~~~
> 
> This could be solved by adding another #ifdef, but as there is
> a trend towards removing CONFIG_PM checks in favor of helper
> macros, do the same conversion here and use pm_ptr() to get
> either a function pointer or NULL but avoid the warning.
> 
> As the hidden functions reference some other symbols, make
> sure those are visible at compile time, at the minimal cost of
> a few extra bytes for 'struct usb_device'.
> 
> Fixes: 9abe15d55dcc ("xhci: Move xhci MSI sync function to to xhci-pci")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for this.
Looks like Greg already picked it.

-Mathias