Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac3ec611-f7f5-af08-ec25-00c820d73b87@igalia.com>
Date:   Thu, 30 Mar 2023 08:33:58 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] .gitignore: Exclude KUnit config dot-files
Content-Language: en-US
To:     Javier Martinez Canillas <javierm@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     linux-kselftest@vger.kernel.org, David Gow <davidgow@google.com>,
        Maxime Ripard <maxime@cerno.tech>,
        Enric Balletbo i Serra <eballetbo@redhat.com>,
        kunit-dev@googlegroups.com, Daniel Latypov <dlatypov@google.com>,
        Brendan Higgins <brendanhiggins@google.com>,
        Alex Gaynor <alex.gaynor@gmail.com>, Andrew Davis <afd@ti.com>,
        Kees Cook <keescook@chromium.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@google.com>
References: <20230330112743.2331141-1-javierm@redhat.com>
From:   =?UTF-8?Q?Ma=c3=adra_Canal?= <mcanal@igalia.com>
In-Reply-To: <20230330112743.2331141-1-javierm@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Javier,

On 3/30/23 08:27, Javier Martinez Canillas wrote:
> There's a rule to ignore all the dot-files (.*) but we want to exclude the
> config files used by KUnit (.kunitconfig) since those are usually added to
> allow executing test suites without having to enable custom config symbols.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

This seems like a pretty nice improvement for the KUnit development.

Reviewed-by: Maíra Canal <mcanal@igalia.com>

Best Regards,
- Maíra Canal

> ---
> 
>   .gitignore | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 70ec6037fa7a..7f86e0837909 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -103,6 +103,7 @@ modules.order
>   !.get_maintainer.ignore
>   !.gitattributes
>   !.gitignore
> +!.kunitconfig
>   !.mailmap
>   !.rustfmt.toml
>   
> 
> base-commit: ffe78bbd512166e0ef1cc4858010b128c510ed7d