Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff48b15c-f8ce-b971-c840-81458715d82b@linaro.org>
Date:   Thu, 30 Mar 2023 14:36:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2] thermal: tegra-bpmp: Handle offline zones
Content-Language: en-US
To:     Mikko Perttunen <cyndis@kapsi.fi>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
Cc:     Mikko Perttunen <mperttunen@nvidia.com>, linux-pm@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230330094904.2589428-1-cyndis@kapsi.fi>
 <a09d8edf-9db1-0037-15a4-7ce329b82bf2@linaro.org>
 <204e0435-c544-8727-e892-9fc69b8d691d@kapsi.fi>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <204e0435-c544-8727-e892-9fc69b8d691d@kapsi.fi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 30/03/2023 12:06, Mikko Perttunen wrote:
> On 3/30/23 13:03, Daniel Lezcano wrote:
>> On 30/03/2023 11:49, Mikko Perttunen wrote:
>>> From: Mikko Perttunen <mperttunen@nvidia.com>
>>>
>>> Thermal zones located in power domains may not be accessible when
>>> the domain is powergated. In this situation, reading the temperature
>>> will return -BPMP_EFAULT. When evaluating trips, BPMP will internally
>>> use -256C as the temperature for offline zones.
>>
>>> For smooth operation, for offline zones, return -EAGAIN when reading
>>> the temperature and allow registration of zones even if they are
>>> offline during probe.
>>
>> I think it makes more sense to check if the power domain associated 
>> with the device is powered up and if not return -EPROBE_DEFER.
> 
> The power domains in question are related to computer vision engines 
> that only get powered on when in use, possibly never if the user doesn't 
> run a computer vision workload on the system. We still want other 
> thermal zones to be available.

Ok, I see the point.

I'm worried about the semantic of the errors returned, the translation 
from BPMP_EFAULT to EAGAIN and the assumption it is a disabled (may be 
forever) thermal zone.

What does the documentation say for the error msg.rx.ret == -BPMP_EFAULT?


>>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>>> ---
>>> v2:
>>> * Adjusted commit message.
>>> * Patch 2/2 dropped for now since it is more controversial,
>>>    and this patch is more critical.
>>>
>>>   drivers/thermal/tegra/tegra-bpmp-thermal.c | 9 ++++++++-
>>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/thermal/tegra/tegra-bpmp-thermal.c 
>>> b/drivers/thermal/tegra/tegra-bpmp-thermal.c
>>> index f5fd4018f72f..4ffc3bb3bf35 100644
>>> --- a/drivers/thermal/tegra/tegra-bpmp-thermal.c
>>> +++ b/drivers/thermal/tegra/tegra-bpmp-thermal.c
>>> @@ -52,6 +52,8 @@ static int __tegra_bpmp_thermal_get_temp(struct 
>>> tegra_bpmp_thermal_zone *zone,
>>>       err = tegra_bpmp_transfer(zone->tegra->bpmp, &msg);
>>>       if (err)
>>>           return err;
>>> +    if (msg.rx.ret == -BPMP_EFAULT)
>>> +        return -EAGAIN;
>>>       if (msg.rx.ret)
>>>           return -EINVAL;
>>> @@ -259,7 +261,12 @@ static int tegra_bpmp_thermal_probe(struct 
>>> platform_device *pdev)
>>>           zone->tegra = tegra;
>>>           err = __tegra_bpmp_thermal_get_temp(zone, &temp);
>>> -        if (err < 0) {
>>> +
>>> +        /*
>>> +         * Sensors in powergated domains may temporarily fail to be 
>>> read
>>> +         * (-EAGAIN), but will become accessible when the domain is 
>>> powered on.
>>> +         */
>>> +        if (err < 0 && err != -EAGAIN) {
>>>               devm_kfree(&pdev->dev, zone);
>>>               continue;
>>>           }
>>
> 

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog