Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230308131452.383914-1-peternewman@google.com>
 <20230308131452.383914-3-peternewman@google.com> <f103ec28-01b4-d4ca-f6e9-d557ea4efb81@intel.com>
In-Reply-To: <f103ec28-01b4-d4ca-f6e9-d557ea4efb81@intel.com>
From:   Peter Newman <peternewman@google.com>
Date:   Thu, 30 Mar 2023 14:50:26 +0200
Message-ID: <CALPaoChkEkH_oKfUXut6WtXZiK6K8gM1eLk+2NWXkhJsAHtzCw@mail.gmail.com>
Subject: Re: [PATCH v4 2/3] x86/resctrl: Parameterize rdt_move_group_tasks()
 task matching
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     fenghua.yu@intel.com, Babu.Moger@amd.com, bp@alien8.de,
        dave.hansen@linux.intel.com, eranian@google.com,
        gupasani@google.com, hpa@zytor.com, james.morse@arm.com,
        linux-kernel@vger.kernel.org, mingo@redhat.com, skodak@google.com,
        tglx@linutronix.de, tony.luck@intel.com, x86@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Reinette,

On Thu, Mar 23, 2023 at 7:02=E2=80=AFPM Reinette Chatre
<reinette.chatre@intel.com> wrote:
> On 3/8/2023 5:14 AM, Peter Newman wrote:
> > +/*
> > + * If @from is NULL, then all tasks in the systems are moved unconditi=
onally
> > + * (used for teardown).
>
> Could this description be expanded to describe what the matching does? Ju=
st jumping
> in with the above sentence is quite cryptic.
>
> > + */
> > +static bool rmdir_match(struct task_struct *t, struct rdtgroup *from)
>
> Could the function's name please reflect what the function does as oppose=
d to
> what the current users are doing at the time they call it? Perhaps
> something like "task_in_any_group()" (thinking ahead about a possible
> "task_in_mon_group()" for the next patch, please feel free to change).
> Also note that the "from" is another naming that reflects the usage as
> opposed to what the function does. It could just be "rdtgrp".

I read over the behavior of this function more carefully to try to come
up with a more descriptive name and realized that for MON groups it
behaves identically to the new one I created for rename().

The original rdt_move_group_tasks() was actually fine all along so I'm
just going to drop this patch.

-Peter