Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2090350rwl; Thu, 30 Mar 2023 06:02:50 -0700 (PDT) X-Google-Smtp-Source: AKy350aQYGDNKbnmIMSkB74CE0kk+njPBOMuG8AxYbt5Gq3HqlDjxw2EC8swC5jJdySkwv8cxTCq X-Received: by 2002:a05:6a20:8f14:b0:d3:a13a:4c06 with SMTP id b20-20020a056a208f1400b000d3a13a4c06mr2622695pzk.2.1680181370549; Thu, 30 Mar 2023 06:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680181370; cv=none; d=google.com; s=arc-20160816; b=nWnB0IiswQIOK7GPfUH+eBi+2oX801oy02uaKdWBtoX/t27/tAsy7IUZZ0yscpvPMP H0L4GZ7BN5CpKWRFOLkHtwpo11QRJ2zgXThsSobM2ruAAcoH4KpcAGeHLeYbhPKRx3fx 1c1PqVPNIT9NG1c+/B+LavbHhPNUBGpUnCG0grGU+YVfwLpvit4rkXjCaiuT4AwhEYHR K2FjhUT+0PGXY+ozh1Fx3MsmsxiL3z2dBibWcYiqvdgR1j7A5vtM64739lCEcaJwx1Lk shpREfOzs4zXZugAmzTejzoDJYCs7ZMrHmTIEdLFppfaqATuYrRFIfQDk4KiaCuxx2sn ZVtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=DX3wDmHIixcxvaALsy0YbJKYN0BXc1D/jOeMFwLU+xE=; b=PVIabMb4zXoUmUYdWer1pgHc8JlNc80C+bEJHZeyWzz+5AsTI68g8FP+GYK7hEhi6c Qb+F/b5WYDQNEQhceK9+rb/lQWy6/3cXM7hJbvhnjGGJ3gdySET/n8fxoskwKPHfwzDl A2iUSwAZqUIORfcVLgi/7BQG1Rn/yoqSbFKWRoZR+hY6jVWgYRVxFHfaeLycnpCcLLGv MED5DdKlhHzOJtwaXPJFCFqGEgxaLVKPHrDk6rDo9iOqmOtCbVJx6N2DJiJJIBnKSOWL iTwtNtR7eApdvG3exRjACfGzMxtQbKpgZYSxZClXRgoJBNKsOK2mtvOfxuolFUz8uc0o UIBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y193-20020a638aca000000b0050be067284bsi23136007pgd.556.2023.03.30.06.02.34; Thu, 30 Mar 2023 06:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbjC3M7i (ORCPT + 99 others); Thu, 30 Mar 2023 08:59:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbjC3M7e (ORCPT ); Thu, 30 Mar 2023 08:59:34 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AE43F974B; Thu, 30 Mar 2023 05:59:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F407F80FE; Thu, 30 Mar 2023 12:59:32 +0000 (UTC) Date: Thu, 30 Mar 2023 15:59:31 +0300 From: Tony Lindgren To: Greg Kroah-Hartman Cc: Jiri Slaby , Andy Shevchenko , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v9 1/1] serial: core: Start managing serial controllers to enable runtime PM Message-ID: <20230330125931.GT7501@atomide.com> References: <20230323071051.2184-1-tony@atomide.com> <20230330113231.GR7501@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg Kroah-Hartman [230330 12:52]: > On Thu, Mar 30, 2023 at 02:32:31PM +0300, Tony Lindgren wrote: > > * Greg Kroah-Hartman [230329 09:08]: > > > On Thu, Mar 23, 2023 at 09:10:47AM +0200, Tony Lindgren wrote: > > > > --- /dev/null > > > > +++ b/drivers/tty/serial/serial_base.c > > > > @@ -0,0 +1,142 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > > > Given that the driver core is "GPL-2.0-only", why is this -or-later? > > > > Thanks for noticing, the intention was to set it to what serial_core.c has: > > > > $ git grep -e SPDX -e MODULE_LICENSE drivers/tty/serial/serial_core.c > > drivers/tty/serial/serial_core.c:// SPDX-License-Identifier: GPL-2.0+ > > drivers/tty/serial/serial_core.c:MODULE_LICENSE("GPL"); > > Doesn't mean you have to copy it, it's your choice :) In this case my preference is to use the same as for serial_core.c. This is so folks can start moving serial port specific functions from serial_core.c to serial_port.c. And not have to worry about the possible differences with various licenses at that point :) Tony