Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 14:00:04 +0100
From:   Lee Jones <lee@kernel.org>
To:     Tom Rix <trix@redhat.com>
Cc:     pavel@ucw.cz, quic_fenglinw@quicinc.com,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs
 storage-class-specifier to static
Message-ID: <20230330130004.GN434339@google.com>
References: <20230317191341.1670660-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230317191341.1670660-1-trix@redhat.com>
Precedence: bulk

On Fri, 17 Mar 2023, Tom Rix wrote:

> smatch reports
> drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
>   symbol 'mvflash_3ch_regs' was not declared. Should it be static?
> drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
>   symbol 'mvflash_4ch_regs' was not declared. Should it be static?
>
> These variables are only used in leds-qcom-flash.c,
> so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/leds/flash/leds-qcom-flash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I fixed-up some spelling / formatting issues and ...

Applied, thanks

--
Lee Jones [李琼斯]