Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 15:14:00 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Jiri Slaby <jirislaby@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-omap@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v9 1/1] serial: core: Start managing serial controllers
 to enable runtime PM
Message-ID: <ZCWLGLNxj-02ALA1@kroah.com>
References: <20230323071051.2184-1-tony@atomide.com>
 <ZCQAF-nrrsfBtviT@kroah.com>
 <20230330113231.GR7501@atomide.com>
 <ZCWF_Envuh3Qnaxm@kroah.com>
 <20230330125931.GT7501@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330125931.GT7501@atomide.com>
Precedence: bulk

On Thu, Mar 30, 2023 at 03:59:31PM +0300, Tony Lindgren wrote:
> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230330 12:52]:
> > On Thu, Mar 30, 2023 at 02:32:31PM +0300, Tony Lindgren wrote:
> > > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230329 09:08]:
> > > > On Thu, Mar 23, 2023 at 09:10:47AM +0200, Tony Lindgren wrote:
> > > > > --- /dev/null
> > > > > +++ b/drivers/tty/serial/serial_base.c
> > > > > @@ -0,0 +1,142 @@
> > > > > +// SPDX-License-Identifier: GPL-2.0-or-later
> > > > 
> > > > Given that the driver core is "GPL-2.0-only", why is this -or-later?
> > > 
> > > Thanks for noticing, the intention was to set it to what serial_core.c has:
> > > 
> > > $ git grep -e SPDX -e MODULE_LICENSE drivers/tty/serial/serial_core.c
> > > drivers/tty/serial/serial_core.c:// SPDX-License-Identifier: GPL-2.0+
> > > drivers/tty/serial/serial_core.c:MODULE_LICENSE("GPL");
> > 
> > Doesn't mean you have to copy it, it's your choice :)
> 
> In this case my preference is to use the same as for serial_core.c. This is
> so folks can start moving serial port specific functions from serial_core.c
> to serial_port.c. And not have to worry about the possible differences with
> various licenses at that point :)

That's great, no objection from me, sorry, but I had to ask, the "no
fun" part of my job...

greg k-h