Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2129640rwl; Thu, 30 Mar 2023 06:28:32 -0700 (PDT) X-Google-Smtp-Source: AKy350b5sHgCC2fKpWGM+5/ruN/P4MpsUaYWtIxYY6vUHuGioGqDiwg+afNyW5fgEeMByTuMW3p/ X-Received: by 2002:a17:90a:284f:b0:237:47b0:30d3 with SMTP id p15-20020a17090a284f00b0023747b030d3mr2352005pjf.4.1680182912457; Thu, 30 Mar 2023 06:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680182912; cv=none; d=google.com; s=arc-20160816; b=FFjenNofWmzMkqIps5NkxL/W44X/hmUI53PgjN6WcZUDAn2/VSxfAVftfRQ6NtpspN azBoacDkaR8jyeR/OnhAedw15pA20F11A1k7fZo5qqhnKhxlEzAeCgVraHBxE8TB3F1o jhXrej40VrLLP7gEdKHqiSU/G1x9WDVLO8lZEUzCTcjRUACx6+LslJdtm+4/2j6VRk2n XeIlUqW54CZr8NF0O1/Oof3tcba6zg+LftVszmHPDAwwTJioaRztb9EZG143ZyMfiyI3 glzQZkSFhAhwOP1GQxYzCRCtAki40WdjqkIKiuQW4R3WjGOWaV1TIB0pZVrFvi6u3ea8 QCbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NI4FESraZEkkjXEH1RDepht3xII2qK/Qn8q4vtkr8sY=; b=cJrc2OoYbWSs3BVA8uPWT/nYVrBnXcacwcO+VRAzpGmVqORaELP2AAuixe7cICbh2e Ni7xle1YjsEkOU+wBh1lJKgczappUREtHcp2Ymb0PIF620T6bKbFpE45FMF8QgiFoB5I uWAxRCz5t18nR8MqZS4N6R3khh6KZOxqtYLglr8YOfim0amqOTe6CR3mpbf6uMpc0bxb UuSb6RoYw0XPTSlQG/eaZJ/ZNnkIhpEtlQ1+KcEqMIKodVl9k29xhv9iu8HZFbrKp30V /o/Q2rGcHzgPKCSIQO6kd0HSq9b8RBRYT7OXB3ayYJ6XXgyxyA9kjvwTECmRxqSb6sdE 1Fqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R+OLtVKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n8-20020a654888000000b005134209f98bsi1288335pgs.480.2023.03.30.06.28.20; Thu, 30 Mar 2023 06:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R+OLtVKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231939AbjC3N0X (ORCPT + 99 others); Thu, 30 Mar 2023 09:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbjC3N0U (ORCPT ); Thu, 30 Mar 2023 09:26:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D37B1721; Thu, 30 Mar 2023 06:26:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDC896206D; Thu, 30 Mar 2023 13:26:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B5FBC433EF; Thu, 30 Mar 2023 13:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680182764; bh=dSIOoybE1W349DqL4UmHGGA/bEYIiW88os5hr4nt+qw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+OLtVKyiCUyYQ3N5jvrPvyoLeNKKOVrhnnbvL4NknIQya4La+DQOtAZyLt7nYQmX jEeWR/ruYZV5SIxrL3qdYOLQk874y01CzLG1zTSIyjUorGVbXK5oMPS1bEAyk1ewCn 8h+NEkK0YGC/KK16STOZKguycIhMYGV13T4k7ce3n4wZ3Xrd1QvYEqMVHh5xHg51Qq /c5VaNaSeseXlrNKGkTwghrUDhX8nOCLyLLBLHNM/R+b+9HPYsuLleF1TVyCl3WO75 h0j9Fw3zf1s8wVOvo3aiIE8y+rwWM+ScXFt8qgTJUjG20CBQDOdPewRsOENGgd9MG/ RLABjmBEsYxPw== Date: Thu, 30 Mar 2023 14:26:00 +0100 From: Lee Jones To: Min Li Cc: richardcochran@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Min Li Subject: Re: [PATCH mfd v2 1/3] mfd: rsmu: support 32-bit address space Message-ID: <20230330132600.GR434339@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2023, Min Li wrote: > From: Min Li > > We used to assume 0x2010xxxx address. Now that we > need to access 0x2011xxxx address, we need to > support read/write the whole 32-bit address space. > > Also defined RSMU_MAX_WRITE_COUNT and > RSMU_MAX_READ_COUNT for readability > > Signed-off-by: Min Li > --- > changelog > -change commit message to include defining RSMU_MAX_WRITE/WRITE_COUNT > > drivers/mfd/rsmu.h | 2 + > drivers/mfd/rsmu_i2c.c | 172 +++++++++++++++++++++++++++++++-------- > drivers/mfd/rsmu_spi.c | 52 +++++++----- > include/linux/mfd/rsmu.h | 5 +- > 4 files changed, 175 insertions(+), 56 deletions(-) I changed the commit message a little and reworded/moved a comment and: Applied, thanks -- Lee Jones [李琼斯]