Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d843a75-543d-1da2-89b1-ec256eecb009@axis.com>
Date:   Thu, 30 Mar 2023 15:29:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Reset mv88e6393x watchdog
 register
Content-Language: en-US
To:     =?UTF-8?Q?Marek_Beh=c3=ban?= <marek.behun@nic.cz>,
        Andrew Lunn <andrew@lunn.ch>
CC:     Gustav Ekelund <gustav.ekelund@axis.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <kernel@axis.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230328115511.400145-1-gustav.ekelund@axis.com>
 <20230328120604.zawfeskqs4yhlze6@kandell>
 <9ba1722a-8dd7-4d6d-bade-b4c702c8387f@lunn.ch>
 <20230328124754.oscahd3wtod6vkfy@kandell>
 <c92234f1-099b-29a0-f093-c54c046d304a@axis.com>
 <be2b5084-9cab-4cc7-ba50-a53dd71dfea5@lunn.ch>
 <20230328144742.vty3cpmgmsdyjiia@kandell>
From:   Gustav Ekelund <gustaek@axis.com>
In-Reply-To: <20230328144742.vty3cpmgmsdyjiia@kandell>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk5EU2pkOTkyRXF2aWpZRjEzYlU0RTBMZ3I3VVpsbUJXN0dsQ0FKS01LSWl1?=
 =?utf-8?B?ODFOSDBIKzIvbVFEOFI3WWJPME96UU9KLytDbHNVNWxiR1cwRmZieGYrVGJZ?=
 =?utf-8?B?N1pXbE5SbHo5cVZ0c0lLZ3dGbERRWmFzWEVvUXV6K0JYMStIdVFwNCtzY0hB?=
 =?utf-8?B?ejZ0T25rTExwMkdYK3paMkgxNXlXdXlCbHFtczc1bWFWTTZGaEplRU9aOUhy?=
 =?utf-8?B?L2JLaFdwM214cVc2ZUt0Y0hHL1I4Tjk4WEtBZ3l3K0FjTFFZc3hWcXpXcnVi?=
 =?utf-8?B?N0hKMnJUY1VHd2dHYUJ5bWZCeGg2eVZ6dDdXc0tndVBLdGFELzJPZnA3MEsw?=
 =?utf-8?B?SGk0b2twb0kyM3diSUdBVHU0K2ZSYVRPbWNZL0xZMkt4dkwwRllqL3JZN1Qv?=
 =?utf-8?B?L0hYV1lSYjJBZGIyVCtXb0M4NzZPUFNvTGlWVTMzRVpLY0I3N2ZKNGJjV3Ra?=
 =?utf-8?B?Rk5sY1JrbzNKc000ZFB6TUJISjJ1UTZtTk9OZ3NSckdacWthVVQxQUhLN3lz?=
 =?utf-8?B?UzVCRTRTSUIzdk1VbFBKNE9DR2wrRXkzWVdkQTkxYW9RaytOaVpIazN0NDNQ?=
 =?utf-8?B?SjNjaEt2b25sWGU2SWxLYmp5dTF3SkYzeGlZUzg3eENDeVZuUElFWUt3WkV3?=
 =?utf-8?B?VWxrL1FOeEwxZjkyVGxiK3JCZ1gzUHpLdXUzMGZuOHp6VjFFaU1CZ08vWloy?=
 =?utf-8?B?ZDQ3dTcrWHNVcWJsYTJwVi9yOTNaTXltKzVUWVZwVERiRUl4aFdsc3Y5ZVJO?=
 =?utf-8?B?QkxOaTA5OUhzOXJZVjVCTXMxNTZNUDFNMHo5M0l3dUhkV080akE1QlRxaUgx?=
 =?utf-8?B?V1JPZXEzYjdmQWc2WVlDTXExN2dWN1VFemYycWRUc2c5MDZhWmRVMm9sUlBB?=
 =?utf-8?B?aDYwSXlkbjgzejVjditCMGZDbllMQU9sMy8rWm91KzBPNEJpRkplY2M3YU42?=
 =?utf-8?B?TTc0UEJvdk9CM2VBUmZHSVZBRE84ekg5WldZNGFDODN4ZldhaUNnZlE5V2xV?=
 =?utf-8?B?MU5OSTEvdkVxOWNFUVoxVlpiV0JtQldIbzA0NzVNT0dOQjROYkZsNm5USWQ5?=
 =?utf-8?B?YUZxdnpTSUloYXV3ZGMrbUpmZUtLVm9RY1YrN1pJc0JWd3ZFVGVvQVFBMXlE?=
 =?utf-8?B?VGM4azVucytuRUNCWVkya25wRGt1a1IzL2FxZXFTc0ZDaWVVNUR1eHZST1Nl?=
 =?utf-8?B?aUxaRkc3OE1lUElPT0pEWFJwRUlpYXA1L3pWZnJibFlNZnFYdFMzd0J1UWNm?=
 =?utf-8?B?TWxmc1VYc0FHVmRPTi9wc0ZIWE43Rnphbjk2aDJMUHQ1NzEzdGFSeGNrV0gw?=
 =?utf-8?B?SWtuZVJEazFTSU45TlRVOURnazZqZC9xUHc4elBydUhOUHo0cUlUTUJpMGlS?=
 =?utf-8?B?N2hPZkpnMU50OUI1bEFnZnpVRFdZbDRwdWpySmpRQkdnYnRGV1JIUjEvcnNF?=
 =?utf-8?B?RlFFYzJnejV5Y1BYMGJRMnVXL1F3TFByS0JrNEwyck15QW0rYk9XR240TEc0?=
 =?utf-8?B?Q2Z0VjBWVzRUZCtRcmN3dnFsZzR6L1g3aVJNc1BueEprNXZBK2d2bjQ3b1pj?=
 =?utf-8?B?YWQvMThESzJOcGt2UXB2MG8zYjVNclEzbjVHdUJkN2I0ZzgzaFZTanp3QzQz?=
 =?utf-8?B?aEZvOFJCNFFEY1VkL3NBVG5aNEhYRjJUYnF1MHcrRzFlcVMrZUdMc0RUSVVJ?=
 =?utf-8?B?NnpneXk5VXJKV0l2N3JJMHZEeERLOTRqUElFcTJjKzNWeHhNWUdUY1ZkOHpr?=
 =?utf-8?B?TVRWM1l1S0lwTm9tdVdwQVhGRldlRFRzUHp0Q0t0MVFDZ2E2ekdHOW9EczZ6?=
 =?utf-8?B?dDZsRFQzYWlneThIakVLdWxtam9xVkxvRE5ZMXFWSzkzbDJsT0h4Q04yN3R1?=
 =?utf-8?B?T3UvQkhqNkE2aGxrTFNJWnJpS0cvSFhTOExzWVJxd3ZsZjdXUEZFTlQzeTB6?=
 =?utf-8?B?OURTNnh3TzkxY2YwS1QwdUJwWXdLcU5qVWR5R3pkYkNCQXRNMG5NVXRrcVVU?=
 =?utf-8?B?alZNdzMrWTd2SHJnTW5BU1ZVMnN5ZDRtYi9UU0tHSy91UDk5QXBnbFl0L3R6?=
 =?utf-8?B?ZU85UDJ6UmRiYTA1RjJVRG9jNWo5YVFJdDVLTXVwZ0g5elVGSCtmY21nSjdV?=
 =?utf-8?Q?9d5s=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f5e054d0-91ea-4c1a-075c-08db3122d7ff
X-MS-Exchange-CrossTenant-AuthSource: DB7PR02MB4074.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 13:29:52.7653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OxOOGOVBvPLzpNoGJB/2NaOynMZlZOk+2+CeX7BqDraXMgQkSuSEd2+7iylmQNgr0HSb3jt17nAZMarvB+n39A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB7382
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/28/23 16:47, Marek Behún wrote:
> On Tue, Mar 28, 2023 at 03:45:51PM +0200, Andrew Lunn wrote:
>> On Tue, Mar 28, 2023 at 03:34:03PM +0200, Gustav Ekelund wrote:
>>
>>> 1) Marvell has confirmed that 6393x (Amethyst) differs from 6390 (Peridot)
>>> with quote: “I tried this on my board and see G2 offset 0x1B index 12 bit 0
>>> does not clear, I also tried doing a SWReset and the bit is still 1. I did
>>> try the same on a Peridot board and it clears as advertised.”
>>>
>>> 2) Marvell are not aware of any other stuck bits, but has confirmed that the
>>> WD event bits are not cleared on SW reset which is indeed contradictory to
>>> what the data sheet suggests.
>>
>> Hi Gustav
>>
>> Please expand the commit message with a summary of this
>> information. It answers the questions both Marek and i have been
>> asking, so deserves to be in the commit message.
>>
>> 	Andrew
> 
> Maybe also add a comment next to the code writing to the register, that
> this is due to an yet unreleased erratum on 6393x.
> 
> Marek
Hi Marek and Andrew

As you pointed out, it is only the force WD bit that is writeable and
the others are read-only. Just needed to clarify that the patch is only
meant to solve clearing the force WD event bit (bit 0).
I will clarify this in the commit as well.

The errata is allegedly planned to be documented in their next version
of release notes.

Thank you for reviewing!

Best regards
Gustav