Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 21:05:05 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Shakeel Butt <shakeelb@google.com>
Cc:     Feng Tang <feng.tang@intel.com>, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Randy Dunlap <rdunlap@infradead.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Joe Mario <jmario@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Eric Dumazet <edumazet@google.com>, dave.hansen@intel.com,
        ying.huang@intel.com, tim.c.chen@intel.com, andi.kleen@intel.com
Subject: Re: [PATCH v2] Documentation: Add document for false sharing
Message-ID: <ZCWXET8MPoyUc/Md@debian.me>
References: <20230329073322.323177-1-feng.tang@intel.com>
 <ZCUPxMQPJ8ETvUbM@debian.me>
 <CALvZod48Fwua_VJvnzHatF-J4YRWqfMFnYjYN6W0_ioLtPZEfA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VZOl/c00MbQzw8H5"
Content-Disposition: inline
In-Reply-To: <CALvZod48Fwua_VJvnzHatF-J4YRWqfMFnYjYN6W0_ioLtPZEfA@mail.gmail.com>
Precedence: bulk


--VZOl/c00MbQzw8H5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 29, 2023 at 09:51:56PM -0700, Shakeel Butt wrote:
> > > +* Turn hot global data to 'per-cpu data + global data' when possible,
> > > +  or reasonably increase the threshold for syncing per-cpu data to
> > > +  global data, to reduce or postpone the 'write' to that global data.
> > > +
> > > +  - Commit 520f897a3554 ("ext4: use percpu_counters for extent_statu=
s cache hits/misses")
> > > +  - Commit 56f3547bfa4d ("mm: adjust vm_committed_as_batch according=
 to vm overcommit policy")
> > > +
> >
> > Here's what I mean by bridging conjunctions to example commits as I rev=
iewed
> > in v1 [1]:
> >
>=20
> This is too much and unneeded nitpicking. The patch looks good as is.

As ESL people, I feel there is a gap when a description paragraph is
followed immediately by some sort of lists without bridging (conjunction
between them). I expect a smooth transition in this case. Even though
before the list it is written "(with examples)", I think the conjunction
is needed anyway.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--VZOl/c00MbQzw8H5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHQEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZCWXDgAKCRD2uYlJVVFO
o9YPAQCFZN6kjI3Mdb9a70VW/VfydKaJJrE3NzGtp5OKIPNmoQD1F2wNzJ8QDEFZ
fq6YjgBUMnNm9WIwZQVuHeB+hZBbAQ==
=Qtoy
-----END PGP SIGNATURE-----

--VZOl/c00MbQzw8H5--