Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 15:06:28 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>, rafael@kernel.org,
        Colin Foster <colin.foster@in-advantage.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee@kernel.org>, davem@davemloft.net,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        thomas.petazzoni@bootlin.com
Subject: Re: [RFC 2/7] regmap: check for alignment on translated register
 addresses
Message-ID: <ZCWXZF3rOucT1M7c@sirena.org.uk>
References: <20230324093644.464704-1-maxime.chevallier@bootlin.com>
 <20230324093644.464704-3-maxime.chevallier@bootlin.com>
 <ZB3xJ4/FTEwHyVyY@sirena.org.uk>
 <20230330114546.13472135@pc-7.home>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RrmrRms1shZeGUqK"
Content-Disposition: inline
In-Reply-To: <20230330114546.13472135@pc-7.home>
Precedence: bulk


--RrmrRms1shZeGUqK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Mar 30, 2023 at 11:45:46AM +0200, Maxime Chevallier wrote:
> Mark Brown <broonie@kernel.org> wrote:

> > It is not at all clear to me that the combination of stride and
> > downshift particularly makes sense, and especially not that the
> > stride should be applied after downshifting rather than to what
> > the user is passing in.

> I agree on the part where the ordering of "adding and offset, then
> down/upshifting" isn't natural. This is the order in which operations
> are done today, and from what I could gather, only the ocelot-spi MFD
> driver uses both of these operations.

Right.  I don't think the ordering is particularly intentional,
like I say it's not clear that combinding the two makes sense so
I think it just wasn't considered at all.

--RrmrRms1shZeGUqK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQll2MACgkQJNaLcl1U
h9BpMQf/WhPnIKZo18DLfF0CsOhxPsBoDZOKPIGOi4LPOsxO5AUzT5/NbJsE16F7
JNclev+MkS5gIU1TdqfxOKjMEHT5ObqROfalEhpQ9wGTW5QO7Uczya0ZeBEHHEqN
Zd/E6pnmodtVU+wpG9a5onaSHif4E2PWL6ZaYT199hjLX5alGOicmnO9CcIQFgZo
i3IT+SFMKtUxyMCnSDryJyHM8YlctXSMs9bZ0xBVK9tQE8qqIHl7FclV/sPh7DV2
/eL1bcoSs0xOu/VgJHUJwEFog3ocjhIei3P6HfNcBbv0oRhBi2XgybeDqYxuDXm0
NUgyywuwcoZfWXhA7FMjpaMg+GoYEQ==
=JvNb
-----END PGP SIGNATURE-----

--RrmrRms1shZeGUqK--