Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 09:59:21 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Vignesh Raghavendra <vigneshr@ti.com>
CC:     Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Bjorn Andersson <quic_bjorande@quicinc.com>,
        Arnd Bergmann <arnd@arndb.de>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 0/2] arm64: dts: ti: Fixes for Beagleplay SD
Message-ID: <20230330145921.5pnmcjgwl5wllhvq@await>
References: <20230330105921.3639185-1-vigneshr@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230330105921.3639185-1-vigneshr@ti.com>
Precedence: bulk

On 16:29-20230330, Vignesh Raghavendra wrote:
> Couple of fixups on top of ti-next branch:
> 
> The SD supply on Beagle is really coming from PMIC LDO1 even though its
> controllable via GPIO, hence fix the DT accordingly, this also means
> PMIC regulator drivers need to be built-in to allow SD card rootfs
> 
> Nishanth,
> Better to squash into respetive commits if possible
> 
> Vignesh Raghavendra (2):
>   arm64: configs: defconfig: Make TPS65219 regulator built-in
>   arm64: dts: ti: k3-am625-beagleplay: Fixup SD card supply regulator
> 
>  arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
>  arch/arm64/configs/defconfig                   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.40.0
> 
Thanks Vignesh, I will do the fixup.

Chatting with Roger offline, also realized that the board circuitry will
need the following change as it is using a 1/3 voltage divider on SoC's
USB1 as well: I will add this fixup while at it.

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index f75e79e54dfc..a4eb54722743 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -484,6 +484,7 @@ &usb0 {
 };
 
 &usbss1 {
+	ti,vbus-divider;
 	status = "okay";
 };
 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D