Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6dac0c4b-a792-849b-97be-31ad3a527e7b@amd.com>
Date:   Thu, 30 Mar 2023 11:39:05 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] drm/amdkfd: remove unused sq_int_priv variable
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com,
        "Kim, Jonathan" <Jonathan.Kim@amd.com>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20230330152040.1838353-1-trix@redhat.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20230330152040.1838353-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjljWE55K1NoRWoyZGpuKzFSY1pMTUorVjc0TDNiY0kxbUxLTjR3dmNPYTlL?=
 =?utf-8?B?MnhtVEhOV3VKak5sWlZlMzVzQndIbFpiazQ3TlRmZW5VN0pNRjR2K2ZHQTZR?=
 =?utf-8?B?L3NESmRRTHhBZml5cExteXBFSFNYS2JTdTNQSC9pd1loRnVnQy80Y2RNaTBa?=
 =?utf-8?B?dGNJdXY1WTZzbDQzTTZQRUxoR0RqSHB1Tlc3VlMxeS9LMDVCQklQTlVjRy9Z?=
 =?utf-8?B?bEVxbnp0azR1MzZDMkFpOEU1QzNBRHh2SUhhSTlPVjBvS3JVTmtqSTdtZHRL?=
 =?utf-8?B?cXY4bS81blVpc05nR2E0YkFmWUI2L0lUR0dsSERPVnFYYVRmYzRkNkR6dDZF?=
 =?utf-8?B?RlhWK2ZkaU9WZ1VaYTlIMTR0b05yb1RWellXT1JkZy84WXlSUHowQlEwb0NG?=
 =?utf-8?B?MjJoZWhQNk0xbjBSQkdKSk81L0x1MW9rb3BSanRmdEY4NndwenlwVU4rNjdC?=
 =?utf-8?B?Uit6cGZLS01BRCtuQXVtZHM0TW9TbkNsTW1oRk1obmpvaUxDNGZDV0MvVENL?=
 =?utf-8?B?ZC9sdEtXd214U01vVlc2UTRNVTZET1J2TWRPTjhWcVVORnQ2ZmdoekY4WnE2?=
 =?utf-8?B?dkJHVDFPSDZWT0dqRUV0U0NzL2pybnE2bElGRlBwRTQ0N2wvVHNNZVFjTlVS?=
 =?utf-8?B?WVpqM3J6TjFKWVdJaEdZWGhjWHlnOTl2K0NwM1BVLzNnZ3RlNGpFVGV1VUVt?=
 =?utf-8?B?Y0dkTU9pOG5ZUWN1T2RqajAxdllpY3FlZkoxclpHOUVpUm5acldyWklKSURa?=
 =?utf-8?B?ejNoeERnOGh5ZVY0a0dhbWJlWWNGcE1UVHE1dXd2dTA4SU5GT1JuYkp5R3Nn?=
 =?utf-8?B?VDBLNy9pR09EN0ZtL2ZHU3hBd0hjd0hwRGZPd0swQkNyYktYSW85RjlCTml5?=
 =?utf-8?B?S3l0SXVJbHE1UGtqTU9QRXBsS0hUK284ZW5jS21ZYXJzcFYwOTJDYUVxeSt2?=
 =?utf-8?B?R1Naam91RitXcHlycXJycE5UOUFockZDQ282S1hzem9YU2NJeXB4WTl2cTNr?=
 =?utf-8?B?L2p0alRUb041KzNkVEEyU2JRWVJqcXlEdzV6eUhNUnpsejRBT2ZkeGFaMzBL?=
 =?utf-8?B?NE9lYjRPamVrZ1dybjNReTZjYnVsZmFqNVlSdkZObURnY293TWRaRktVSWl5?=
 =?utf-8?B?TVQ5bVVDVmtGUTBXY2lBcDAwZTN4NFVpNUNnMmFFRmVVa2FMQXBSRW54R0J1?=
 =?utf-8?B?MkJBRlpyVHAvL3gwc0h4ZkhlL0hYSUhZbUxzbDVDSG1aUTk5UUYwUkNZZmJs?=
 =?utf-8?B?UW5WSHc4VjFvN0hZUmk4aEswWis2d1RRKzNvNnJycXBHdS9RVGJtWnRPZkdt?=
 =?utf-8?B?eTVXalUraWhLMEdBclREWUpRVUIydkdJcm1rNHBGd0ZKa1NCc040WGp0QTJI?=
 =?utf-8?B?aDF3SG53blplcmtvYU01L2RWdVZ5czlPVW9GQ2U2bnVLYkYwMnVpQ3lkanpa?=
 =?utf-8?B?c2hJSTVJUDZvZEd4eWh3cmdIMXg0YjFINnRYaXJPWTF0bHVjTWllYk14Zi94?=
 =?utf-8?B?cTdxd2V0SklLbkpadStRbFVBaEF1dndtRHZsZExOYnl0bDFZWnVWWWljcVJl?=
 =?utf-8?B?TCtjOCtqREVsd0kyeFpiUW4vR3BlVWNGMWtmVHhuZXA3a0syRnNjMDJxaVBF?=
 =?utf-8?B?dHhUWUR1TDZ3aDFaZERCcEpHTTRvSU9XUmxNak1aYVJyaHVpajZtZGpadVln?=
 =?utf-8?B?UVFlbWZMUHZNd0l5WXFlVXY2UVp2K2d6TWlxWittZXQwWTJRK0ZMRnIyWWxB?=
 =?utf-8?B?cWFUTm56V3FXd3dLUUF4WWJNeXVLQm01a2p6U1djSDVjUlV3R1hpL1BhVm9B?=
 =?utf-8?B?NmJSRVhqQlArSmdxaXNnem0vYlpja2FZSTBDTjNyelNwdi9sbUk3bURCMzh2?=
 =?utf-8?B?NnNaOG1jRURlMEpjQmVJd290MlFVUVIrL3cxV3hJVS9OQ05rWmpUV1R4Z0M0?=
 =?utf-8?B?Wng4MFg5d092UWN3WmhheXJ5RjZGNzVJQ0kzdHR5blc1UThsYjFOYXVWQmps?=
 =?utf-8?B?NmtXUEdmY2tkbWhYbWpVL1g0bWhHQThkMHh3dVRXaS9Zb2dSNFNKamw2N1ZJ?=
 =?utf-8?B?d1lHdWFTZkI2MnFPT2IyQ2FZeEhHS09zQ3piVXZZVndQeGdKVTV6TXdUZDdF?=
 =?utf-8?Q?+I1X9sEFfEQOarLcYvDcyPsCp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4afb4611-a003-4be9-01c2-08db3134e681
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 15:39:08.0938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sBB51qP1A7Uz/07TI15r+TXWxGJMuBmcF0YQaZ01M0l2OaAbmfOiITfNG2vfc8Vu8kWFuDQNZ0hlhLDyxIGkaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8071
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2023-03-30 um 11:20 schrieb Tom Rix:
> clang with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_int_process_v11.c:282:38: error: variable
>    'sq_int_priv' set but not used [-Werror,-Wunused-but-set-variable]
>          uint8_t sq_int_enc, sq_int_errtype, sq_int_priv;
>                                              ^
> This variable is not used so remove it.

Hi Jon,

I think your debugger patches are going to start using this. Can you 
comment?

I'd prefer not to apply this patch now, as Jon's patches are expected to 
land soon, once Alex is done upstreaming GFX 9.4.3 support.

Regards,
   Felix


>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> index 0d53f6067422..bbd646c0dee7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> @@ -279,7 +279,7 @@ static void event_interrupt_wq_v11(struct kfd_dev *dev,
>   {
>   	uint16_t source_id, client_id, ring_id, pasid, vmid;
>   	uint32_t context_id0, context_id1;
> -	uint8_t sq_int_enc, sq_int_errtype, sq_int_priv;
> +	uint8_t sq_int_enc, sq_int_errtype;
>   	struct kfd_vm_fault_info info = {0};
>   	struct kfd_hsa_memory_exception_data exception_data;
>   
> @@ -348,13 +348,6 @@ static void event_interrupt_wq_v11(struct kfd_dev *dev,
>   				break;
>   			case SQ_INTERRUPT_WORD_ENCODING_INST:
>   				print_sq_intr_info_inst(context_id0, context_id1);
> -				sq_int_priv = REG_GET_FIELD(context_id0,
> -						SQ_INTERRUPT_WORD_WAVE_CTXID0, PRIV);
> -				/*if (sq_int_priv && (kfd_set_dbg_ev_from_interrupt(dev, pasid,
> -						KFD_CTXID0_DOORBELL_ID(context_id0),
> -						KFD_CTXID0_TRAP_CODE(context_id0),
> -						NULL, 0)))
> -					return;*/
>   				break;
>   			case SQ_INTERRUPT_WORD_ENCODING_ERROR:
>   				print_sq_intr_info_error(context_id0, context_id1);