Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2314074rwl; Thu, 30 Mar 2023 08:41:40 -0700 (PDT) X-Google-Smtp-Source: AKy350YHw0rUspwWxyO8ZAzH5bH+uSJ3ELn72XYhZ1fuUB+UCmhy7RLUy/xFXxu8VovxKc4eVn7l X-Received: by 2002:a05:6402:42c2:b0:502:ffd:74a1 with SMTP id i2-20020a05640242c200b005020ffd74a1mr24950424edc.2.1680190900498; Thu, 30 Mar 2023 08:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680190900; cv=none; d=google.com; s=arc-20160816; b=cVzN2j4j7GHfsscWOaKmk3A6tiWKBe0EBwOy3v03DHc5LXvY+AYackiaAclgJeNMxz mhqI37ZSyrJC5y80VozV+GJRjJjO8a2/OgcGPf60uJsPK2uGFyIeOmKhYSm5+JVdwZsc mTq7/0kXix6WLvGAQZwJyvhzkG28AdNhEJwqqtcxbIG3/K/HoFbiOmxb3LmCsv28axwR mvOSj6c06AtqNgTQmiuNx59UJu+U0TDNg5VxOhaBaxHzR6pBZRZDliIQGfYgIoGexLkr 3XI7mSEpOl6iUJjjTJ44c5JSJQLQJ8y75sMg3YQLU4SixEWq+O8DOD4zYRnKBdnheGt3 QoHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9d2xNkI182FSfUTEEQGgCIjsGqMFhkkwFqqsxTc2i34=; b=zf2pSjII8zw2Jo07/mNXaNfbw1HWgOOW840R+Ugrd8Cgys68iE7oNj/ATLvTmH6US7 sZOmGD20yXQzz54h1NB0mhyL628HRTnNydhDcU19ke2WSBr+qlouiW85RX+gQsImnKsh Bkk15jOzwWHFXYGjnjZ8uEZ9TTZfVzvveB+sxN27S6ilnBcOxn03cRiCPpTlo5ZFYYO7 OI7idfFUBXcJwNMXlEsmlq/W+1/cL0Ny9YyOAwtI1LtgPPppm/BIuKmF5XXcW9oNRExg kqTNWym0y42SQxVtIsv7eL75U3u6uLcyUBfZDqm4vIbguZ4GMm4EuZf0ReU6l/8Umb2z +4BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="Emg1W/eR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020aa7c145000000b004fd2b0fa78esi72386edp.393.2023.03.30.08.41.11; Thu, 30 Mar 2023 08:41:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="Emg1W/eR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233242AbjC3PlC (ORCPT + 99 others); Thu, 30 Mar 2023 11:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233171AbjC3Pk6 (ORCPT ); Thu, 30 Mar 2023 11:40:58 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0A19186; Thu, 30 Mar 2023 08:40:52 -0700 (PDT) Received: from benjamin-XPS-13-9310.. (unknown [IPv6:2a01:e0a:120:3210:792c:96d5:14:366a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 536A16603182; Thu, 30 Mar 2023 16:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680190851; bh=0gSs5OxGpVrI0GSprqLN8IwnNdNN4hRC00SXIrAsmbo=; h=From:To:Cc:Subject:Date:From; b=Emg1W/eRLE4JXvYR90A0eGar0dEtm6OpBVSbSN68DfWRDKaaqsMTquGiPxtC5qk6l 6i9R13tTYcNLfvTAqJYifdTZPHoOikqlaytfF5+lvHcmspZOYkEi0EkNiOs7Du5L41 RAMWTP0XmKgL5YaSTfkVURrkHoyMdGk8cK2i6tjLKzoIU/OGtoI4635w0HblzuCBCu kofu0cikT2wuPvW/ToiqGqCfRCW05IbgGRMv2j2ZeT2WHtqAlAUXlA0z+XvdOjS9nw jnbZJVip/YXEKIjQrkOoir2Fpu2yCVP673eSbOV+LDI1e86gpxyP4988CmYG33Vxep 1WiDbswVaso1w== From: Benjamin Gaignard To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH v5 00/13] AV1 stateless decoder for RK3588 Date: Thu, 30 Mar 2023 17:40:30 +0200 Message-Id: <20230330154043.1250736-1-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series implement AV1 stateless decoder for RK3588 SoC. The hardware support 8 and 10 bits bitstreams up to 7680x4320. AV1 feature like film grain or scaling are done by the postprocessor. The driver can produce NV12_4L4, NV12_10LE40_4L4, NV12 and P010 pixels formats. Even if Rockchip have named the hardware VPU981 it looks like a VC9000 but with a different registers mapping. The series is based on Hans's br-v6.4f branch + "media: Add AV1 uAPI" patch v7. The full branch can be found here: https://gitlab.collabora.com/linux/for-upstream/-/commits/rk3588_av1_decoder_v5 Fluster score is: 200/239 while testing AV1-TEST-VECTORS with GStreamer-AV1-V4L2SL-Gst1.0. The failing tests are: - the 2 tests with 2 spatial layers: few errors in luma/chroma values - tests with resolution < hardware limit (64x64) - 10bits film grain test: bad macroblocks while decoding, the same 8bits test is working fine. Changes in v5: - Add a patch to initialize bit_depth field of V4L2_CTRL_TYPE_AV1_SEQUENCE ioctl. Changes in v4: - Squash "Save bit depth for AV1 decoder" and "Check AV1 bitstreams bit depth" patches. - Double motion vectors buffer size. - Fix the various errors reported by Hans. Changes in v3: - Fix arrays loops limites. - Remove unused field. - Reset raw pixel formats list when bit depth or film grain feature values change. - Enable post-processor P010 support Changes in v2: - Remove useless +1 in sbs computation. - Describe NV12_10LE40_4L4 pixels format. - Post-processor could generate P010. - Fix comments done on v1. - The last patch make sure that only post-processed formats are used when film grain feature is enabled. Benjamin Benjamin Gaignard (12): dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible media: Add NV12_10LE40_4L4 pixel format media: verisilicon: Get bit depth for V4L2_PIX_FMT_NV12_10LE40_4L4 media: verisilicon: Add AV1 decoder mode and controls media: verisilicon: Check AV1 bitstreams bit depth media: verisilicon: Compute motion vectors size for AV1 frames media: verisilicon: Add AV1 entropy helpers media: verisilicon: Add Rockchip AV1 decoder media: verisilicon: Add film grain feature to AV1 driver media: verisilicon: Enable AV1 decoder on rk3588 media: verisilicon: Conditionally ignore native formats media: AV1: Make sure that bit depth in correctly initialize Nicolas Dufresne (1): v4l2-common: Add support for fractional bpp .../bindings/media/rockchip-vpu.yaml | 1 + .../media/v4l/pixfmt-yuv-planar.rst | 4 + drivers/media/platform/verisilicon/Makefile | 3 + drivers/media/platform/verisilicon/hantro.h | 8 + .../media/platform/verisilicon/hantro_drv.c | 68 +- .../media/platform/verisilicon/hantro_hw.h | 102 + .../platform/verisilicon/hantro_postproc.c | 9 +- .../media/platform/verisilicon/hantro_v4l2.c | 67 +- .../media/platform/verisilicon/hantro_v4l2.h | 5 +- .../verisilicon/rockchip_av1_entropymode.c | 4424 +++++++++++++++++ .../verisilicon/rockchip_av1_entropymode.h | 272 + .../verisilicon/rockchip_av1_filmgrain.c | 401 ++ .../verisilicon/rockchip_av1_filmgrain.h | 36 + .../verisilicon/rockchip_vpu981_hw_av1_dec.c | 2234 +++++++++ .../verisilicon/rockchip_vpu981_regs.h | 477 ++ .../platform/verisilicon/rockchip_vpu_hw.c | 134 + drivers/media/v4l2-core/v4l2-common.c | 149 +- drivers/media/v4l2-core/v4l2-ctrls-core.c | 5 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/media/v4l2-common.h | 2 + include/uapi/linux/videodev2.h | 1 + 21 files changed, 8306 insertions(+), 97 deletions(-) create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_entropymode.c create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_entropymode.h create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_filmgrain.c create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_filmgrain.h create mode 100644 drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c create mode 100644 drivers/media/platform/verisilicon/rockchip_vpu981_regs.h -- 2.34.1