Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 18:01:54 +0200
Message-ID: <878rfekz2l.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Dan Carpenter <error27@gmail.com>
Cc:     Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Luis Chamberlain <mcgrof@kernel.org>,
        linux-kselftest@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Russ Weight <russell.h.weight@intel.com>,
        Takashi Iwai <tiwai@suse.de>,
        Tianfei zhang <tianfei.zhang@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Colin Ian King <colin.i.king@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [BUG] [PATCH RFC v2] selftests/firmware: copious kernel memory leaks in test_fw_run_batch_request()
In-Reply-To: <5b103196-68d0-4d42-aa66-779af4d78532@kili.mountain>
References: <97e284be-5018-9d18-feb2-7ec4b08c06fd@alu.unizg.hr>
        <26fd581a-1b9f-4960-8457-61d725511cee@kili.mountain>
        <dce6ffbe-7580-db1a-dd24-798be27b3a26@alu.unizg.hr>
        <5b103196-68d0-4d42-aa66-779af4d78532@kili.mountain>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 30 Mar 2023 17:44:42 +0200,
Dan Carpenter wrote:
> 
> I admire your enthusiam.  :)  What about if we just did this?  Does it
> help with the leaks?
> 
> regards,
> dan carpenter
> 
> diff --git a/lib/test_firmware.c b/lib/test_firmware.c
> index 05ed84c2fc4c..626b836895f4 100644
> --- a/lib/test_firmware.c
> +++ b/lib/test_firmware.c
> @@ -895,6 +895,9 @@ static ssize_t trigger_batched_requests_store(struct device *dev,
>  
>  	mutex_lock(&test_fw_mutex);
>  
> +	if (test_fw_config->reqs)
> +		return -EBUSY;
> +

This leaves the mutex locked.
It should be the following instead, I suppose?

	if (test_fw_config->reqs) {
		rc = -EBUSY;
		goto out_unlock;
	}


Takashi