Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2370042rwl; Thu, 30 Mar 2023 09:21:13 -0700 (PDT) X-Google-Smtp-Source: AKy350Yc1hIV+hSs+x+uI+aOjIbvRwYyOGDXEMXzLpERKMitJSE1MwfSQ2CwFn2DbCjDm7ph3ecO X-Received: by 2002:a05:6402:1d48:b0:4bb:afe3:e0a with SMTP id dz8-20020a0564021d4800b004bbafe30e0amr3701631edb.3.1680193272806; Thu, 30 Mar 2023 09:21:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680193272; cv=none; d=google.com; s=arc-20160816; b=vT7vmHXwgwcgv05cdmZ2tbhCniSER5dtB4Cdgt1KuE1jki89S20wG304cbn8MVYU1M R1DmLOtKb+Cnw9SzX8ta5AYVVA7Lz5wyHo8icLW/LASeY13LcTGfb/+usJt1kSg2boBO uJHAlNKdcukcyNDapUFyjfFItnkwxQcBXHxVky4TggeF0vSboNr8JToMZXpJxmQeBZNk Rt/D4rt0HcS3C92aTZYTvFizLj78qC/CGvqYniZ9XbzNqYNfWgrWhUVv5d9B5QGzRCXt HQ0WXo8mNoWsBl11++qsVRGh/nSKjM9v8v/9F3bRM3TP0WUsWeBZecUqQhj5pM/GHGZE W85g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+uoV5v6CqOx8UahMldl1SNoEMpf5o51HySMS9jGjZPg=; b=Omn+N3Ns8y3zf04gfAqnatKfTy8iqNHEaDcloWiaLjONJKY+hkzNzvUQrXDGpo0GP0 MR4gX2lkMgsRXjvI0qbaWku0GNBf0z9gyi60x+HRGvTGcbNBD1jEjPqGg7VMTK9MAvOY yT4SUD0fi0qEpePLno2HkCYmy5A7STrm2cxxfycb8s/7bIK3j2wMju7j5K5NrCABTUE9 R3sls5IDG0AioekBlgOJTvlvxcHhoUy4c/OwDUYGDWw/Q3LvdSZyp/o0TzIR1qR5wT7z aJ8zJ5rHVzNVrZmFUHd0dYkseyU8JSf1G+LkwaiflPAZRUiUx1zuctg3RIb34IuCLJxU Go+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m6OZfS5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bq3-20020a056402214300b004af50024631si141413edb.433.2023.03.30.09.20.34; Thu, 30 Mar 2023 09:21:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m6OZfS5Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbjC3QFU (ORCPT + 99 others); Thu, 30 Mar 2023 12:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbjC3QFT (ORCPT ); Thu, 30 Mar 2023 12:05:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF7AA900D; Thu, 30 Mar 2023 09:05:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4644662110; Thu, 30 Mar 2023 16:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26820C433D2; Thu, 30 Mar 2023 16:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680192316; bh=viaViRHbOUE2fhuaH9npts1s3lqVVfNzJID7p/qGxNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m6OZfS5Z2VvyJAEylOF2nv/gh9VcA5FP+BQRkidlgpB/DisvueL3Sd/6WTynINVHl +n7axNxIfrchWxNOAnb1Ej6EVtw4BaFq0Sdnqmopp1uO5TBTiiqE+l7OeYcJJCkxrr MDCQUrjfXukhfzXX+LeDpypxjeMOUAs/lPFCBJ93hmMbD2L13rdvW2zawmYSLP5OQ6 wOdrM08QFaR3WJPoVfXxiUSLOVZO2b1ELtzeVPh+Y0bFea+2RQg6QIHuriF0h5WAME 61J3oK4B7sxLfoeMZIy9ssFDi3CEgSEnWEwN859ZDCv+fxpHc4SarvuLZZa1suYQVW P36jrUUrMRJBQ== Date: Thu, 30 Mar 2023 17:05:10 +0100 From: Lee Jones To: Herve Codina Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v5 2/5] mfd: Add support for the Lantiq PEF2256 framer Message-ID: <20230330160510.GB489249@google.com> References: <20230328092645.634375-1-herve.codina@bootlin.com> <20230328092645.634375-3-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230328092645.634375-3-herve.codina@bootlin.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Mar 2023, Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an analog E1/T1/J1 line and the > digital PCM system highway/H.100 bus. My goodness! It's been a long time since I've seen anything quite like this. My suggestion to you: * Split this up into components that fit functional subsystems * Run checkpatch.pl * Remove all of the debug prints * Move all of the defines out to a header file * Be more verbose in your documentation / comments * Consider using simple-mfd to probe child devices. > Signed-off-by: Herve Codina > --- > drivers/mfd/Kconfig | 17 + > drivers/mfd/Makefile | 1 + > drivers/mfd/pef2256.c | 1355 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/pef2256.h | 28 + > 4 files changed, 1401 insertions(+) > create mode 100644 drivers/mfd/pef2256.c > create mode 100644 include/linux/mfd/pef2256.h -- Lee Jones [李琼斯]