Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 13:27:35 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Bhavya Kapoor <b-kapoor@ti.com>
CC:     Apurva Nandan <a-nandan@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Kumar, Udit" <u-kumar1@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4-evm: Add eMMC mmc0 support
Message-ID: <20230330182735.2lkuplsqcjku5enh@unnoticed>
References: <20230327083100.12587-1-a-nandan@ti.com>
 <f3be8f20-fe56-489e-440c-53ca66f00508@ti.com>
 <20230330152406.fmpri7nnzybf7uqh@jubilance>
 <8f4e8265-da64-1e53-e1ed-b925e0326cad@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8f4e8265-da64-1e53-e1ed-b925e0326cad@ti.com>
Precedence: bulk

On 23:14-20230330, Bhavya Kapoor wrote:
> 
> On 30/03/23 20:54, Nishanth Menon wrote:
> > On 11:50-20230330, Bhavya Kapoor wrote:
> >> On 27/03/23 14:01, Apurva Nandan wrote:
> >>> Add support for eMMC card connected to main sdhci0 instance.
> >>>
> >>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> >> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
> >>
> >>> ---
> >>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 9 +++++++++
> >>>   1 file changed, 9 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> index 7480f37e89e8..1622a01a4667 100644
> >>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> >>> @@ -21,6 +21,7 @@ chosen {
> >>>
> >>>   	aliases {
> >>>   		serial2 = &main_uart8;
> >>> +		mmc0 = &main_sdhci0;
> >>>   		mmc1 = &main_sdhci1;
> >>>   		i2c0 = &main_i2c0;
> >>>   	};
> >>> @@ -225,6 +226,14 @@ exp2: gpio@22 {
> >>>   	};
> >>>   };
> >>>
> >>> +&main_sdhci0 {
> >>> +	/* eMMC */
> >>> +	status = "okay";
> >>> +	non-removable;
> >>> +	ti,driver-strength-ohm = <50>;
> >>> +	disable-wp;
> >>> +};
> >>> +
> >>>   &main_sdhci1 {
> >>>   	/* SD card */
> >>>   	status = "okay";
> >>> --
> >>> 2.34.1
> >> Looks correct to me.
> >
> > Don't you need pinmux?
> >
> Hi Nishanth, pinmux is not needed since there is no mux options for emmc pins (mmc0) in datasheet.
> 
> ?-> Kindly refer to datasheet for same : https://www.ti.com/lit/ds/symlink/tda4vh-q1.pdf?ts=1680197698102&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FTDA4VH-Q1%253FkeyMatch%253DTDA4VH%2BDATASHEET

Aah, yes - thanks for clarifying.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D