Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160646.3106903-1-peterx@redhat.com>
In-Reply-To: <20230330160646.3106903-1-peterx@redhat.com>
From:   Axel Rasmussen <axelrasmussen@google.com>
Date:   Thu, 30 Mar 2023 12:07:24 -0700
Message-ID: <CAJHvVciUGEfdgTLHUxAxCpKxXbMt202nsPhArsckHm7bDOdqFg@mail.gmail.com>
Subject: Re: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 30, 2023 at 9:06=E2=80=AFAM Peter Xu <peterx@redhat.com> wrote:
>
> Dump a summary after running whatever test specified.  Useful for human
> runners to identify any kind of failures (besides exit code).
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/se=
lftests/mm/run_vmtests.sh
> index c0f93b668c0c..9cc33984aa9f 100644
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -5,6 +5,9 @@
>  # Kselftest framework requirement - SKIP code is 4.
>  ksft_skip=3D4
>
> +count_pass=3D0
> +count_fail=3D0
> +count_skip=3D0
>  exitcode=3D0
>
>  usage() {
> @@ -149,11 +152,14 @@ run_test() {
>                 "$@"
>                 local ret=3D$?
>                 if [ $ret -eq 0 ]; then
> +                       count_pass=3D$(( $count_pass + 1 ))

Actually, inside $(( )) there's no need to prefix variable names with
$ too. Running "shellcheck" over the script written this way will
generate a warning.

Same applies below.

>                         echo "[PASS]"
>                 elif [ $ret -eq $ksft_skip ]; then
> +                       count_skip=3D$(( $count_skip + 1 ))
>                         echo "[SKIP]"
>                         exitcode=3D$ksft_skip
>                 else
> +                       count_fail=3D$(( $count_fail + 1 ))
>                         echo "[FAIL]"
>                         exitcode=3D1
>                 fi
> @@ -279,4 +285,6 @@ CATEGORY=3D"soft_dirty" run_test ./soft-dirty
>  # COW tests
>  CATEGORY=3D"cow" run_test ./cow
>
> +echo "SUMMARY: PASS=3D${count_pass} SKIP=3D${count_skip} FAIL=3D${count_=
fail}"
> +
>  exit $exitcode
> --
> 2.39.1
>

Besides the nitpick:

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>