Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp79868rwl; Thu, 30 Mar 2023 12:26:53 -0700 (PDT) X-Google-Smtp-Source: AKy350b/+Fa6GOts/AK4gphuqXd8wWPAloBHFpjCqT+yJbIH3OVGtS1R4CGFh+9g2fUgCDmBEf0t X-Received: by 2002:a17:903:647:b0:19a:7217:32af with SMTP id kh7-20020a170903064700b0019a721732afmr3367984plb.5.1680204412961; Thu, 30 Mar 2023 12:26:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680204412; cv=none; d=google.com; s=arc-20160816; b=THxtDnANq0cnAVYcNI9CKrBt2I+WD11pKm7f/FgRSV73TfDDtlEKC6VBZm0LKR36O7 xj50M4kJTcTctkzuoCEyo8K/2McAVNFRg0V3TQN51M+6ih4cY3sRa51fa2K/gr7Y9dfN 6+K5Mhi9CE/T7eavYUoVCTrDkfr60HFAX1Ux+vUmFeZRbh4GanmxZjtU8RkmAstExgJa FxLRE2y+TqcWXk2+l8RDtI1ZmNHIgLS8ZjRW1YCfV3VuMRt3KOfloS8Yc9juzBe88A08 wGE3HHYfSMOFD2EHeXPD/A+9JDpr70iw14wwnl/3lhdqz8NWBRxpqEF01C5Y+yUQ2O4F P5fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=HBqpSW6QK4EA+LClEvnqsikCHd1YVrQiiftMR2XV5Rc=; b=0wirwtaeW/oLVNGg8O3MJR83GljHErnjpXPHGpuRztIbk/ivCsOUJQr8DpdvEDplCo aZW/vwXNk9sRjq/ZVrLhUTNYS9VpTyBZKkUmNNLZSAulG8l3aZd6YHF2bJfMaAb0UyIT WZUVfiUdcrFA0stGZSzctCidN3lbEfo8PN9fAS62z/L5hL1W5uJSPOXuHk9hNX1JYdXi q2eSGOiSgv+bhjgWeIS0d9uaVAzd1gRBxfVx0slehHJ2VLDoJHFarkJf7IYikyEORNq0 9UiPw8bbaqB5Wc6WY0j70s5+BLMhzMWRRt0I8IU59Le+Zxe8w1fC5taAywR8V8+2RUje pFNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CXeQaZnn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a17090301d100b001a24efe1f14si289763plh.78.2023.03.30.12.26.25; Thu, 30 Mar 2023 12:26:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CXeQaZnn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232157AbjC3TZR (ORCPT + 99 others); Thu, 30 Mar 2023 15:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbjC3TZH (ORCPT ); Thu, 30 Mar 2023 15:25:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C63FF742 for ; Thu, 30 Mar 2023 12:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680204254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBqpSW6QK4EA+LClEvnqsikCHd1YVrQiiftMR2XV5Rc=; b=CXeQaZnnJus+YpVIjfyzfmyvnzSdWS4iQ0U+28GIZqN9yNSYb+gOCfztXf4NSxPWAz5c4J HAeJx+BwbhnHdei2LdEH2wwp4Ei8TmwfC4zvb6pZNFVEvtOSDwAJkCI5DvYxrKvLc/ATEF TlvQzAe0cbTO2tLUJIluSA7cEdvvE/Y= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-eoSboot9PE-gPZNSEAAw5g-1; Thu, 30 Mar 2023 15:24:13 -0400 X-MC-Unique: eoSboot9PE-gPZNSEAAw5g-1 Received: by mail-ed1-f69.google.com with SMTP id a40-20020a509eab000000b005024c025bf4so16194567edf.14 for ; Thu, 30 Mar 2023 12:24:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680204252; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HBqpSW6QK4EA+LClEvnqsikCHd1YVrQiiftMR2XV5Rc=; b=mUDuqP2fnQCcIFc443DKLGLZFMAw2Mjo2Z9YLlwC2Bam55tFQsBV/4/nxb9T8ByGOc d0wpRoo70IwtjAKYES1W8wiieG1/YabNU3w+Jz8FNOirJjsRPLwiBEwrYGDxIGUQr3bD YR1hTQ6KeQKBHlJtHTGbZ4ux/Oohl3sOimlZH1/eHTy4lOx45kG6K8Izd1kiSzrRPcj3 GnmkkJood89FqtbQzDiY1M2edgofRQqXYncZETuC6LK9bj2KRLb9S/N4vp8w4QckPViw CJzjYgD/YY9TmQHa2KLSeV7gsE3AUWU1OlbSi+LQ9YmXgct8RxNFVUDxTdsGLWO/V6Eo 57Ew== X-Gm-Message-State: AAQBX9doPRTtftmjC2TAspL6Ds4i+SUVtGa11tcsZJq6NawC+D7BLCxK CFtoLNzr+NrWPo8BWwzgtEbTPHkVgwsCli3ALKaZsfoSv0BJ35JpUNwchMh4Je9UsNhppCTjjMY zAXiN28wvAwJEg2zK8HjoUz/K X-Received: by 2002:a17:906:f29a:b0:933:816c:abb9 with SMTP id gu26-20020a170906f29a00b00933816cabb9mr6510538ejb.36.1680204251870; Thu, 30 Mar 2023 12:24:11 -0700 (PDT) X-Received: by 2002:a17:906:f29a:b0:933:816c:abb9 with SMTP id gu26-20020a170906f29a00b00933816cabb9mr6510517ejb.36.1680204251499; Thu, 30 Mar 2023 12:24:11 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id h27-20020a50cddb000000b004c19f1891fasm264876edj.59.2023.03.30.12.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 12:24:10 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 38E96A22D4A; Thu, 30 Mar 2023 21:24:10 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jesper Dangaard Brouer , bpf@vger.kernel.org, Stanislav Fomichev Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, alexandr.lobakin@intel.com, larysa.zaremba@intel.com, xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com, yoong.siang.song@intel.com, boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com, john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net Subject: Re: [xdp-hints] [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash In-Reply-To: <168019602958.3557870.9960387532660882277.stgit@firesoul> References: <168019602958.3557870.9960387532660882277.stgit@firesoul> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 30 Mar 2023 21:24:10 +0200 Message-ID: <87o7oam49x.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jesper Dangaard Brouer writes: > Notice targeted 6.3-rc kernel via bpf git tree. > > Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value, > but doesn't provide information on the RSS hash type (part of 6.3-rc). > > This patchset proposal is to change the function call signature via adding > a pointer value argument for provide the RSS hash type. > > Alternatively we disable bpf_xdp_metadata_rx_hash() in 6.3-rc, and have > more time to nitpick the RSS hash-type bits. LGTM; for the series: Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen